Page MenuHomePhabricator

Form to delete images should have an id, too
Closed, ResolvedPublic

Description

Patch to add 'deleteconfirm' id to FileDeleteForm, the same name as in Article::confirmDelete. Might make sense to merge those functions.


Version: 1.14.x
Severity: enhancement

Details

Reference
bz15629

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:23 PM
bzimport set Reference to bz15629.

Add id to form on image deletion

Attached:

Used a different id (added the mw- prefix and -img- to help differentiate from the other page). Done in r40972

I don't see the need to differenciate them, as they're conceptually equivalent for the user (only contents of the comobox change) but ok. I have added the check for the second case to my scripts.
Thanks