Phabricator comment/anchor links broken sometimes when they are collapsed in the "large number of changes" yellow bar
Open, Needs TriagePublic

Description

T164990#3262187 links to a comment that gets hidden behind the yellow "There are a very large number of changes, so older changes are hidden." thing. In the past, the changes got automatically unhidden in that case, that does not seem to be working anymore (Chrome 61, Ubuntu 16.04) - the viewport is positioned at the top of the document, the old comments remain collapsed, and even after manually opening them, the comment is not highlighted in any way (making the link pretty much useless).

This seems to happen when the comment is hidden behind multiple layers of yellow bars (ie. clicking on the yellow bar just once would not load it). It seems like a single load is happening - compare T164990#3262187 and T164990, the second has way more comments hidden.

Related Objects

Tgr created this task.Oct 5 2017, 7:03 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 5 2017, 7:03 AM
Aklapper renamed this task from Phabricator comment links broken sometimes to Phabricator comment/anchor links broken sometimes when they are collapsed in the "large number of changes" yellow bar.Oct 5 2017, 10:58 AM
Aklapper edited projects, added Phabricator (Upstream); removed Phabricator.
Restricted Application added a project: Upstream. · View Herald TranscriptOct 5 2017, 10:58 AM