Page MenuHomePhabricator

Restore highlighting of target comment in Phabricator
Closed, ResolvedPublic

Description

Phabricator used to have a yellow highlight for the target comment (when following T123#456 style links, or sharing the comment permalink which can be found on the comment date in the upper right corner), which was quite useful because (at least on Chrome) such comments don't seem to be positioned in any deterministic way. This highlighting does not seem to work anymore. Not sure if this is an upstream issue or an instance issue.

Event Timeline

T177456: Phabricator comment/anchor links broken sometimes when they are collapsed in the "large number of changes" yellow bar is somewhat related (but has been the case for a long time; the lack of highlighting started a few months ago, I think).

Aklapper edited projects, added Phabricator (Upstream); removed Phabricator.

I'm boldly declining this. If web browsers don't position an anchor correctly, then those web browsers should get fixed, as that seems to be the actual underlying problem here.

If web browsers don't position an anchor correctly, then those web browsers should get fixed, as that seems to be the actual underlying problem here.

Is it? I can't see the yellow highlight of the comment/action either. A la T233867#5874205 should show that comment highlighted in yellow. My browser brings me to it correctly, but the comment isn't highlighted.

Sorry if my previous comment was not clear: I don't see any yellow highlight, and I also do not see why it's needed.

You don't because it's gone :) There was one previously. It was nice to bring the user's attention to the specific comment they were being linked to.

Aklapper triaged this task as Lowest priority.Feb 18 2020, 8:14 AM
epriestley moved this task from Backlog to Patch merged upstream on the Upstream board.
epriestley subscribed.

It [the yellow highlight] was nice to bring the user's attention to the specific comment they were being linked to.

I'm not entirely sure where in history this got lost, but its removal was unintended. I've restored this behavior in https://secure.phabricator.com/D21213.

Screen Shot 2020-05-04 at 10.02.11 AM.png (241×1 px, 61 KB)