1.35.0-wmf.19 deployment blockers
Closed, ResolvedPublicRelease
Actions

Assigned To

Authored By

	• mmodell
	Sep 25 2019, 10:14 PM

Details

Backup Train Conductor: Jdforrester-WMF
Release Version: 1.35.0-wmf.19
Release Date: Feb 10 2020, 12:00 AM

2020 week 07 1.35-wmf.19 Changes wmf/1.35.0-wmf.19

This MediaWiki Train Deployment is scheduled for the week of Monday, February 10th:

Monday February 10th	Tuesday, February 11th	Wednesday, February 12th	Thursday, February 13th	Friday
Backports only.	Branch `wmf.19` and deploy to Group 0 Wikis.	Deploy `wmf.19` to Group 1 Wikis.	Deploy `wmf.19` to all Wikis.	No deployments on fridays

See https://wikitech.wikimedia.org/wiki/Deployments for full schedule.

How this works

Any serious bugs affecting wmf.19 should be added as subtasks beneath this one.
- Use this form to create one.
Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
If you have a risky change in this week's train add a comment to this task using the Risky patch template
For more info about deployment blockers, see Holding the train.

Other Deployments

Previous: 1.35.0-wmf.18

Next: 1.35.0-wmf.20

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved	Release	dduvall	T233867 1.35.0-wmf.19 deployment blockers
Resolved	PRODUCTION ERROR	Jakob_WMDE	T244562 Internal error on beta Commons Special:RecentChanges: Cache key contains characters that are not allowed
Resolved	PRODUCTION ERROR	dbarratt	T244937 [Regression 1.35.0-wmf.19] i/p/IndexPager.php:* PHP Warning: implode(): Invalid arguments passed
Resolved		dbarratt	T244941 IndexPager: Cast properties passed to implode to arrays
Resolved	PRODUCTION ERROR	Daimona	T245159 PHP Warning: htmlspecialchars() expects string (from WikiPage.php)
Resolved	PRODUCTION ERROR	Daimona	T245178 Fatal: Argument to LogPage::getTitleLink() must be Language, StubUserLang given (via LogPage.php)
Resolved	PRODUCTION ERROR	dduvall	T245202 RESTBase 500 spike of all /page/related/ hits following 1.35.0-wmf.19 all-wiki deployment

Event Timeline

• mmodell created this task.Sep 25 2019, 10:14 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 25 2019, 10:14 PM

thcipriani assigned this task to dduvall.Jan 16 2020, 10:09 PM

thcipriani triaged this task as Medium priority.

thcipriani updated Other Assignee, added: Jdforrester-WMF.

thcipriani added a project: Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)).

thcipriani moved this task from INBOX to Deployment on the Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)) board.

Krinkle added a subtask: T244440: Action API returns null for unset bool parameter.Feb 6 2020, 1:09 PM

Anomie mentioned this in T244440: Action API returns null for unset bool parameter.Feb 6 2020, 2:44 PM

Anomie closed subtask T244440: Action API returns null for unset bool parameter as Resolved.Feb 6 2020, 3:37 PM

Jdforrester-WMF removed a subtask: T244440: Action API returns null for unset bool parameter.Feb 6 2020, 5:19 PM

Addshore added a subtask: T244562: Internal error on beta Commons Special:RecentChanges: Cache key contains characters that are not allowed.Feb 7 2020, 10:27 AM

Addshore closed subtask T244562: Internal error on beta Commons Special:RecentChanges: Cache key contains characters that are not allowed as Resolved.Feb 7 2020, 4:24 PM

Ladsgroup subscribed.Feb 10 2020, 11:42 AM

Change 571322 had a related patch set uploaded (by 20after4; owner: 20after4):
[operations/mediawiki-config@master] group0 wikis to 1.35.0-wmf.18 refs T233867

https://gerrit.wikimedia.org/r/571322

Change 571322 merged by jenkins-bot:
[operations/mediawiki-config@master] group0 wikis to 1.35.0-wmf.18 refs T233867

https://gerrit.wikimedia.org/r/571322

Mentioned in SAL (#wikimedia-operations) [2020-02-10T18:25:03Z] <twentyafterfour@deploy1001> rebuilt and synchronized wikiversions files: group0 wikis to 1.35.0-wmf.18 refs T233867

• Mholloway subscribed.Feb 10 2020, 6:28 PM

Mentioned in SAL (#wikimedia-releng) [2020-02-11T18:24:06Z] <marxarelli> 1.35.0-wmf.19 was branched at 3ac2e9ff045dc081317c9184dc83cf863fd518be for T233867

Mentioned in SAL (#wikimedia-operations) [2020-02-11T19:35:54Z] <marxarelli> running scap clean --delete for old wmf branches wmf.11, wmf.14, wmf.15, wmf.16 (T233867)

Mentioned in SAL (#wikimedia-operations) [2020-02-11T21:01:00Z] <marxarelli> completed group0 to 1.35.0-wmf.19 (T233867)

dbarratt closed subtask T244937: [Regression 1.35.0-wmf.19] i/p/IndexPager.php:* PHP Warning: implode(): Invalid arguments passed as Resolved.Feb 12 2020, 4:05 PM

Jdforrester-WMF added a subtask: T244941: IndexPager: Cast properties passed to implode to arrays.Feb 12 2020, 5:57 PM

Jdforrester-WMF removed a project: Patch-For-Review.

greg mentioned this in T245089: Restore highlighting of target comment in Phabricator.Feb 13 2020, 7:34 AM

Krinkle added a subtask: T245159: PHP Warning: htmlspecialchars() expects string (from WikiPage.php).Feb 13 2020, 3:09 PM

Krinkle added a subtask: T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`".Feb 13 2020, 4:53 PM

Krinkle added a subtask: T245178: Fatal: Argument to LogPage::getTitleLink() must be Language, StubUserLang given (via LogPage.php).Feb 13 2020, 5:24 PM

Jdforrester-WMF closed subtask T245178: Fatal: Argument to LogPage::getTitleLink() must be Language, StubUserLang given (via LogPage.php) as Resolved.Feb 13 2020, 7:48 PM

Jdforrester-WMF closed subtask T245159: PHP Warning: htmlspecialchars() expects string (from WikiPage.php) as Resolved.Feb 13 2020, 7:56 PM

dduvall removed a subtask: T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`".Feb 13 2020, 8:25 PM

Mentioned in SAL (#wikimedia-operations) [2020-02-13T20:33:48Z] <marxarelli> rollback to group1 due to 500 spike (2k/min) (T233867)

matmarex mentioned this in T244870: Deploy v1.0 via query string parameter to target wikis .Feb 18 2020, 2:24 PM

Mentioned in SAL (#wikimedia-operations) [2020-02-18T17:47:21Z] <marxarelli> re-rolling wmf.19 to all wikis (T233867) with eyes particularly on (T245202)

Stashbot mentioned this in T245202: RESTBase 500 spike of all /page/related/ hits following 1.35.0-wmf.19 all-wiki deployment.Feb 18 2020, 5:47 PM

Mentioned in SAL (#wikimedia-operations) [2020-02-18T17:52:28Z] <dduvall@deploy1001> rebuilt and synchronized wikiversions files: Re-roll all wikis to 1.35.0-wmf.19 (T233867)

Mentioned in SAL (#wikimedia-operations) [2020-02-18T18:01:14Z] <marxarelli> completed promotion of 1.35.0-wmf.19 to all wikis (T233867)

dduvall closed this task as Resolved.Feb 18 2020, 6:02 PM

dduvall closed subtask T245202: RESTBase 500 spike of all /page/related/ hits following 1.35.0-wmf.19 all-wiki deployment as Resolved.

I know this task is closed, but T245553 (core's <gallery mode=slideshow> not working at all) seems quite a regression, and not sure who 'maintains' that... :-/ Ideas welcome.

@Aklapper should T245553 be blocker for this week's train (T233868), if it's a regression?

1.35.0-wmf.19 deployment blockersClosed, ResolvedPublicReleaseActions