Page MenuHomePhabricator

IndexPager: Cast properties passed to implode to arrays
Closed, ResolvedPublic

Description

$mLastShown, $mFirstShown and $mPastTheEndIndex should be arrays since T244492, but classes that override doQuery do not all honour this.

We should fix the individual cases, but can avoid errors in the meantime by casting to array as each property is passed to implode.

Details

Related Gerrit Patches:

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, Feb 12, 12:37 AM

Change 571608 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/core@master] IndexPager: Cast properties passed to implode to arrays

https://gerrit.wikimedia.org/r/571608

Change 571608 merged by jenkins-bot:
[mediawiki/core@master] IndexPager: Cast properties passed to implode to arrays

https://gerrit.wikimedia.org/r/571608

Change 571614 had a related patch set uploaded (by Catrope; owner: Tchanders):
[mediawiki/core@wmf/1.35.0-wmf.19] IndexPager: Cast properties passed to implode to arrays

https://gerrit.wikimedia.org/r/571614

dbarratt closed this task as Resolved.Wed, Feb 12, 4:22 PM
dbarratt claimed this task.

Change 571614 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.19] IndexPager: Cast properties passed to implode to arrays

https://gerrit.wikimedia.org/r/571614

Mentioned in SAL (#wikimedia-operations) [2020-02-12T17:57:21Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.19/includes/pager/IndexPager.php: T244941 IndexPager: Cast properties passed to implode to arrays (duration: 01m 03s)