$mLastShown, $mFirstShown and $mPastTheEndIndex should be arrays since T244492, but classes that override doQuery do not all honour this.
We should fix the individual cases, but can avoid errors in the meantime by casting to array as each property is passed to implode.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Release | • dduvall | T233867 1.35.0-wmf.19 deployment blockers | ||
| Resolved | dbarratt | T244941 IndexPager: Cast properties passed to implode to arrays |
Change 571608 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/core@master] IndexPager: Cast properties passed to implode to arrays
Change 571608 merged by jenkins-bot:
[mediawiki/core@master] IndexPager: Cast properties passed to implode to arrays
Change 571614 had a related patch set uploaded (by Catrope; owner: Tchanders):
[mediawiki/core@wmf/1.35.0-wmf.19] IndexPager: Cast properties passed to implode to arrays
Change 571614 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.19] IndexPager: Cast properties passed to implode to arrays
Mentioned in SAL (#wikimedia-operations) [2020-02-12T17:57:21Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.19/includes/pager/IndexPager.php: T244941 IndexPager: Cast properties passed to implode to arrays (duration: 01m 03s)