Error message
Impact
Notes
Provisionally blaming 36ed224b8f40394507a64311eacda7302225a058 or 6786aa5d8e2e87f00a3b1f81d9684ff4eac676ef.
Description
Description
Details
Details
Stack Trace
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Release | • dduvall | T233867 1.35.0-wmf.19 deployment blockers | ||
| Resolved | PRODUCTION ERROR | dbarratt | T244937 [Regression 1.35.0-wmf.19] i/p/IndexPager.php:* PHP Warning: implode(): Invalid arguments passed |
Event Timeline
Comment Actions
This is a regression from rMW6786aa5d8e2e: Support pagination on multiple columns in the IndexPager, caused by the fact that ImageHistoryPseudoPager completely reimplements doQuery(), including code that lives in IndexPager::extractResultInfo(), which was modified in an incompatible way.
Comment Actions
Change 571595 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@master] ImageHistoryPseudoPager: Update doQuery() for IndexPager changes
Comment Actions
Change 571595 merged by jenkins-bot:
[mediawiki/core@master] ImageHistoryPseudoPager: Update doQuery() for IndexPager changes
Comment Actions
Change 571605 had a related patch set uploaded (by Jforrester; owner: Catrope):
[mediawiki/core@wmf/1.35.0-wmf.19] ImageHistoryPseudoPager: Update doQuery() for IndexPager changes
Comment Actions
As @dmaza points out, Flow's HistoryPager is another case, slightly more fiddly to fix since the property needs to not be an array when passed to UUID::create(). While we work this out, we can fix it by doing T244941.
@Jdforrester-WMF presumably that's a train blocker too.
Comment Actions
Change 571605 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.19] ImageHistoryPseudoPager: Update doQuery() for IndexPager changes
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2020-02-12T00:44:43Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.19/includes/page/ImageHistoryPseudoPager.php: T244937 ImageHistoryPseudoPager: Update doQuery() for IndexPager changes (duration: 01m 03s)