Page MenuHomePhabricator

dmaza (Dayllan Maza)
Software Engineer

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jul 10 2017, 7:20 PM (105 w, 3 d)
Availability
Available
IRC Nick
DMaza
LDAP User
Dmaza
MediaWiki User
DMaza (WMF) [ Global Accounts ]

Recent Activity

Tue, Jul 16

dmaza added a comment to T224468: Block list and log incorrectly report "cannot edit own talk page" for some blocks.

If a user tries to save ipb_allow_usertalk in a way that does not conform with those rules, an error message should be shown and the block should not be saved.

Or maybe just do the thing that is expected, rather than throwing an error (because if the form field is in a disabled state, you wont be able to resolve the error).
In other words, DWIM.

Tue, Jul 16, 2:26 PM · Anti-Harassment (The Letter Song), MediaWiki-User-management

Thu, Jul 11

dmaza added a comment to T220163: Allow user to mute notifications from Special:Mute page.

@dmaza @dbarratt I agree it seems repetitive. We can make the user's name bold in the sentence above to make it a bit more prominent but let's go with ...from this user for now.

Thu, Jul 11, 10:59 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song)
dmaza moved T220163: Allow user to mute notifications from Special:Mute page from Review to In Progress on the Anti-Harassment (The Letter Song) board.
Thu, Jul 11, 7:37 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song)
dmaza moved T224468: Block list and log incorrectly report "cannot edit own talk page" for some blocks from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
Thu, Jul 11, 5:17 PM · Anti-Harassment (The Letter Song), MediaWiki-User-management
dmaza claimed T224468: Block list and log incorrectly report "cannot edit own talk page" for some blocks.
Thu, Jul 11, 5:17 PM · Anti-Harassment (The Letter Song), MediaWiki-User-management
dmaza updated the task description for T224468: Block list and log incorrectly report "cannot edit own talk page" for some blocks.
Thu, Jul 11, 5:17 PM · Anti-Harassment (The Letter Song), MediaWiki-User-management
dmaza added a comment to T220163: Allow user to mute notifications from Special:Mute page.

Instead of saying "Mute emails from this user" and "Mute emails from this user" would it be better to say: "Mute emails from user ABC" and "Mute notifications from user ABC"?
I was just wondering because when I first come to the page, my brain skips the first line entirely and I read the options, which use this and then I have to figure out what this is.

Thu, Jul 11, 3:24 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song)
dmaza moved T218270: Mute: Add links to the Tools menu on user pages to mute/unmute user from In Progress to Review on the Anti-Harassment (The Letter Song) board.
Thu, Jul 11, 4:28 AM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), MediaWiki-Email, Notifications, Growth-Team
dmaza updated the task description for T218270: Mute: Add links to the Tools menu on user pages to mute/unmute user.
Thu, Jul 11, 4:18 AM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), MediaWiki-Email, Notifications, Growth-Team

Wed, Jul 10

dmaza added a comment to T227199: 'Editing their own talk page' option has no effect when editing not selected.

If the issue is that after unchecking "Editing", "Editing their own [...]" remains checked (although disabled), that will/should be fixed on T221117: Special:Block checkboxes should remember checked state. I personally don't see a problem other than what's described on T221117

Wed, Jul 10, 2:47 PM · User-RhinosF1, Anti-Harassment, MediaWiki-User-management
dmaza added a comment to T227199: 'Editing their own talk page' option has no effect when editing not selected.

I'm a bit confused as to what is the issue here

Expected Result:
Either:
Grey 'Editing their own talk page' when editing blocks are disabled

Isn't this what's happening right now?

Wed, Jul 10, 1:11 PM · User-RhinosF1, Anti-Harassment, MediaWiki-User-management

Mon, Jul 8

dmaza moved T218270: Mute: Add links to the Tools menu on user pages to mute/unmute user from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
Mon, Jul 8, 7:49 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), MediaWiki-Email, Notifications, Growth-Team
dmaza claimed T218270: Mute: Add links to the Tools menu on user pages to mute/unmute user.
Mon, Jul 8, 7:49 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), MediaWiki-Email, Notifications, Growth-Team
dmaza moved T220163: Allow user to mute notifications from Special:Mute page from In Progress to Review on the Anti-Harassment (The Letter Song) board.
Mon, Jul 8, 7:12 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song)
dmaza added a comment to T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.

@dmaza I prefer the non-prefixed version as I think User: is unnecessary context.

Mon, Jul 8, 3:06 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Email
dmaza added a comment to T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.

@Niharika Just to confirm. Should the form header include User: as part of the text or just the username?
E.g
"Please select your mute preferences for ‪User:Vandal‬."
vs
"Please select your mute preferences for Vandal‬."

Mon, Jul 8, 1:35 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Email

Thu, Jul 4

dmaza added a comment to T226853: Hash all pageTokens or temporary identifiers from the EL Sanitization white-list for AHT.

@Niharika : Does AHT have any EventLogging schemas that are whitelisted?

I'm not sure. @dbarratt, @dmaza - do you know?

Thu, Jul 4, 3:09 AM · Anti-Harassment, Product-Analytics, Analytics

Tue, Jul 2

dmaza added a comment to T220163: Allow user to mute notifications from Special:Mute page.

@Niharika this task introduces a few changes that conflict with the error messages we added on T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser

Tue, Jul 2, 8:05 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song)

Thu, Jun 27

dmaza added a comment to T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.

@dmaza The email footer I see now (in my MUA at least) is: To manage email preferences for Steve please visit <http://192.168.122.72/T218265/index.php/Special:Mute/Steve>.

Thu, Jun 27, 1:27 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Email

Wed, Jun 26

dmaza added a comment to T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.

@Niharika emails from Special:EmailUser are in plain/text. Currently the default email footer looks as follow if I use the plain msg:

This email was sent by Admin to Vandal by the "Email this user" function at devwiki. If you reply to this email, your email will be sent directly to the original sender, revealing your email address to them.
[http://dev.wiki.local.wmftest.net:8080/wiki/Special:Mute/Admin Manage email preferences for ‪Admin‬.]
Wed, Jun 26, 1:00 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Email

Fri, Jun 21

dmaza claimed T220163: Allow user to mute notifications from Special:Mute page.
Fri, Jun 21, 12:32 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song)
dmaza moved T220163: Allow user to mute notifications from Special:Mute page from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
Fri, Jun 21, 12:32 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song)

Thu, Jun 20

dmaza moved T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser from In Progress to Review on the Anti-Harassment (Lāmed - ל) board.
Thu, Jun 20, 4:27 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Email

Jun 5 2019

dmaza added a comment to T206163: Restrictions of overlapping blocks should be merged on enforcement.

+1 for CompositeBlock. IMO the name fits/describes how the object behaves (https://en.wikipedia.org/wiki/Composite_pattern)

Jun 5 2019, 9:47 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), Patch-For-Review, MediaWiki-User-management
dmaza moved T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser from Ready to In Progress on the Anti-Harassment (Lāmed - ל) board.
Jun 5 2019, 6:14 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Email

Jun 3 2019

dmaza added a comment to T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.

@dmaza I updated the task description. The things in bold are new. Did I manage to answer everything?
Sorry that the scope on this ticket keeps changing. :(

Jun 3 2019, 4:47 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Email
dmaza updated the task description for T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.
Jun 3 2019, 4:41 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Email
dmaza closed T221371: 'Thanks' are completely blocked when a user is partially blocked as Resolved.
Jun 3 2019, 4:32 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Anti-Harassment (Kaf - כ), Growth-Team, Thanks
dmaza closed T224613: Update Interaction Timeline to use the new actor table as Resolved.
Jun 3 2019, 4:32 PM · InteractionTimeline, Anti-Harassment (Kaf - כ)

May 31 2019

dmaza added a comment to T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.

@dbarratt @Niharika @aezell Can any of you update the task description and summarize how this should look/behave/text in the page and so on? I'm not 100% sure what's the consensus here.

May 31 2019, 5:28 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Email
dmaza added a comment to T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.

No. My point is that we need to make them checkboxes now, and avoid using verbs when arriving at this page.

This is what I was doing initially and we talked and agreed on not using a checkbox because there is only one option and it was bad UX (merging the lists or no)

May 31 2019, 12:53 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Email
dmaza added a comment to T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.

@dmaza I agree with David that "mute" by itself is ambiguous here. We should indicate that they are attempting to mute emails. So, for the first case, it should be like: "You have requested to mute emails from User:Vandal" and similarly for others.

Sure

May 31 2019, 4:57 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Email

May 30 2019

dmaza added a comment to T224613: Update Interaction Timeline to use the new actor table.

https://github.com/wikimedia/InteractionTimeline/pull/100

May 30 2019, 9:49 PM · InteractionTimeline, Anti-Harassment (Kaf - כ)
dmaza moved T224613: Update Interaction Timeline to use the new actor table from In Progress to Review on the Anti-Harassment (Kaf - כ) board.
May 30 2019, 9:48 PM · InteractionTimeline, Anti-Harassment (Kaf - כ)
dmaza claimed T224613: Update Interaction Timeline to use the new actor table.
May 30 2019, 12:35 PM · InteractionTimeline, Anti-Harassment (Kaf - כ)
dmaza moved T224613: Update Interaction Timeline to use the new actor table from Ready to In Progress on the Anti-Harassment (Kaf - כ) board.
May 30 2019, 12:35 PM · InteractionTimeline, Anti-Harassment (Kaf - כ)

May 28 2019

dmaza added a comment to T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.

Her are all the screens for this feature (so far)

May 28 2019, 9:01 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Email

May 24 2019

dmaza added a comment to T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.

@Niharika After discussing with @dbarratt we agreed that for this task it is not necessary to have a checkbox since the only available option will be to mute or unmute emails (for now). We propose to have a message indicating what action would happen depending if the user is already muted or not.

May 24 2019, 10:24 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Email
dmaza added a comment to T224245: Create a way to save preference options wherever they are set by GlobalPreferences without disruption.

@dbarratt I meant to check on GlobalPreferences not on core. Same thing @Mooeypoo is suggesting but checking against what we already have on the db instead of a config

May 24 2019, 5:18 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Community-Tech (Kanban (Q1 2019-20)), Patch-For-Review, Anti-Harassment, MediaWiki-extensions-GlobalPreferences
dmaza added a comment to T224245: Create a way to save preference options wherever they are set by GlobalPreferences without disruption.

I think I already asked this but it escapes me if I did. Why was it that we can't check if a given option is already a global preference or a local exception?
In other words, when saving "whatever-option" on onUserSaveOptions we could determine if it is a global preference and/or if it has a local override and make the changes wherever they need to be done.
Considering that the choice to make something a global or a local exception is made by the user I would say that it will be expected that any changes to those options will be stored based on the user's choice.

May 24 2019, 5:03 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Community-Tech (Kanban (Q1 2019-20)), Patch-For-Review, Anti-Harassment, MediaWiki-extensions-GlobalPreferences

May 17 2019

dmaza added a comment to T223646: Create a policy on importing global classes.

You could also create a new topic on https://www.mediawiki.org/wiki/Manual_talk:Coding_conventions/PHP. It might add more visibility.

May 17 2019, 7:07 PM · MediaWiki-Codesniffer, Code-Health

May 3 2019

dmaza added a comment to T222388: Create a mechanism for SpecialPages and API modules to have dependencies injected into them.

I think that supporting the definition to be either a callable or a string would be ideal (so a combination of your suggestions). It will make it backward compatible and we can start migrating into DI in incremental changes. SpecialPageFactory::getPage() already supports a string or a callable so a "quick" change would be to make $coreList non-static and adjust the SpecialPageFactory accordingly.
I'm not sure about Api Modules 'cause I haven't seen how that works

May 3 2019, 8:15 PM · Core Platform Team (Code Health (TEC13)), MediaWiki-ServiceContainer, MediaWiki-API, MediaWiki-Special-pages, TechCom, Technical-Debt

May 2 2019

dmaza added a comment to T222281: Add a way to disable a users session and log them out when blocking.

i did say feature flag originally ;)

You did, sorry I missed it :)

May 2 2019, 8:40 PM · MediaWiki-User-management
dmaza added a project to T222281: Add a way to disable a users session and log them out when blocking: Anti-Harassment.
May 2 2019, 2:05 AM · MediaWiki-User-management
dmaza added a comment to T222281: Add a way to disable a users session and log them out when blocking.

Copying over the "in-patch" comment for better discussion

May 2 2019, 2:04 AM · MediaWiki-User-management

Apr 29 2019

dmaza claimed T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.
Apr 29 2019, 2:58 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Email
dmaza moved T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser from Ready to In Progress on the Anti-Harassment (Teth - ט) board.
Apr 29 2019, 2:58 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Email
dmaza closed T219684: BlockRestriction should be a service instead of a singleton as Resolved.
Apr 29 2019, 2:57 PM · MW-1.33-notes, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Anti-Harassment (Teth - ט), Patch-For-Review, MediaWiki-User-management, Technical-Debt
dmaza closed T219684: BlockRestriction should be a service instead of a singleton, a subtask of T221383: SpecialBlock should not be aware of the container, as Resolved.
Apr 29 2019, 2:57 PM · Technical-Debt, MediaWiki-User-management
dmaza closed T219684: BlockRestriction should be a service instead of a singleton, a subtask of T221680: BlockListPager should not be aware of the container, as Resolved.
Apr 29 2019, 2:57 PM · Technical-Debt, MediaWiki-User-management
dmaza closed T219684: BlockRestriction should be a service instead of a singleton, a subtask of T221722: ApiQueryBlocks should not be aware of the container, as Resolved.
Apr 29 2019, 2:57 PM · Technical-Debt, MediaWiki-User-management, MediaWiki-API
dmaza moved T219684: BlockRestriction should be a service instead of a singleton from Review to Done on the Anti-Harassment (Teth - ט) board.
Apr 29 2019, 2:56 PM · MW-1.33-notes, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Anti-Harassment (Teth - ט), Patch-For-Review, MediaWiki-User-management, Technical-Debt

Apr 24 2019

dmaza closed T214214: Disable block notice tracking as Resolved.
Apr 24 2019, 8:09 PM · MW-1.33-notes, Anti-Harassment (Teth - ט), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30)
dmaza moved T214214: Disable block notice tracking from In Progress to Done on the Anti-Harassment (Teth - ט) board.
Apr 24 2019, 8:08 PM · MW-1.33-notes, Anti-Harassment (Teth - ט), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30)
dmaza moved T214214: Disable block notice tracking from In Progress to Done on the Anti-Harassment (Heth - ח) board.
Apr 24 2019, 6:20 PM · MW-1.33-notes, Anti-Harassment (Teth - ט), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30)

Apr 19 2019

dmaza added a comment to T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.

It might also be a good idea to provide more info about mute (https://www.mediawiki.org/wiki/Help:Notifications#mute) and/or more information on how they can see their current email/mute list on Special:Preferences

Apr 19 2019, 8:56 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Email

Apr 17 2019

dmaza moved T193768: Remove debug logic when a Cookie is set for IP Blocks from In Progress to Done on the Anti-Harassment (Heth - ח) board.
Apr 17 2019, 2:34 PM · Patch-For-Review, Anti-Harassment (Heth - ח), Technical-Debt, MediaWiki-User-management
dmaza added a comment to T214214: Disable block notice tracking.

Apr 17 2019, 2:42 AM · MW-1.33-notes, Anti-Harassment (Teth - ט), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30)
dmaza claimed T214214: Disable block notice tracking.
Apr 17 2019, 2:20 AM · MW-1.33-notes, Anti-Harassment (Teth - ט), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30)
dmaza moved T214214: Disable block notice tracking from Ready to In Progress on the Anti-Harassment (Heth - ח) board.
Apr 17 2019, 2:20 AM · MW-1.33-notes, Anti-Harassment (Teth - ט), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30)
dmaza closed T193768: Remove debug logic when a Cookie is set for IP Blocks as Resolved.

Resolved on T218596: Remove stats for measuring when blocks are tracked with a Cookie

Apr 17 2019, 2:19 AM · Patch-For-Review, Anti-Harassment (Heth - ח), Technical-Debt, MediaWiki-User-management
dmaza claimed T193768: Remove debug logic when a Cookie is set for IP Blocks.
Apr 17 2019, 2:13 AM · Patch-For-Review, Anti-Harassment (Heth - ח), Technical-Debt, MediaWiki-User-management
dmaza moved T193768: Remove debug logic when a Cookie is set for IP Blocks from Ready to In Progress on the Anti-Harassment (Heth - ח) board.
Apr 17 2019, 2:13 AM · Patch-For-Review, Anti-Harassment (Heth - ח), Technical-Debt, MediaWiki-User-management

Apr 16 2019

dmaza added a comment to T191549: Allow users to filter Special:BlockList on include/exclude partial blocks.

I'm going with No matching blocks found for the requested IP address or username

Apr 16 2019, 2:30 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Anti-Harassment (Heth - ח), Patch-For-Review, MediaWiki-User-management

Apr 15 2019

dmaza updated subscribers of T191549: Allow users to filter Special:BlockList on include/exclude partial blocks.

If someone is sitewide blocked, and the list is filtered to their username with block type Partial, the message says "The requested IP address or username is not blocked." This is not true any more. Should we change that message (ipblocklist-no-results) to something like: "No blocks found for the requested IP address or username."?

Apr 15 2019, 8:06 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Anti-Harassment (Heth - ח), Patch-For-Review, MediaWiki-User-management

Apr 9 2019

dmaza moved T219684: BlockRestriction should be a service instead of a singleton from Ready to In Progress on the Anti-Harassment (Zayin - ז) board.
Apr 9 2019, 9:25 PM · MW-1.33-notes, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Anti-Harassment (Teth - ט), Patch-For-Review, MediaWiki-User-management, Technical-Debt
dmaza claimed T219684: BlockRestriction should be a service instead of a singleton.
Apr 9 2019, 9:24 PM · MW-1.33-notes, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Anti-Harassment (Teth - ט), Patch-For-Review, MediaWiki-User-management, Technical-Debt
dmaza added a comment to T219684: BlockRestriction should be a service instead of a singleton.

When did we introduce this? If we introduced it in a previous (and published) release, we might need to deprecate for the upcoming one? ... But if it's in between releases it's probably fine.
Either way, the deprecation should be super straight forward even if we do it because, as you pointed out, no one uses it this way outside our code.

Apr 9 2019, 8:40 PM · MW-1.33-notes, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Anti-Harassment (Teth - ט), Patch-For-Review, MediaWiki-User-management, Technical-Debt
dmaza added a comment to T219684: BlockRestriction should be a service instead of a singleton.

@dmaza Also, any dependencies (config, database, etc.) should be injected rather than making the service aware of the container.

Apr 9 2019, 8:38 PM · MW-1.33-notes, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Anti-Harassment (Teth - ט), Patch-For-Review, MediaWiki-User-management, Technical-Debt
dmaza added a comment to T219684: BlockRestriction should be a service instead of a singleton.

What is the plan here exactly? Is there any deprecation process that we have to go through?
Do we want to rename the BlockRestriction class to something else?

Apr 9 2019, 8:10 PM · MW-1.33-notes, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Anti-Harassment (Teth - ט), Patch-For-Review, MediaWiki-User-management, Technical-Debt
dmaza moved T191549: Allow users to filter Special:BlockList on include/exclude partial blocks from In Progress to Review on the Anti-Harassment (Zayin - ז) board.
Apr 9 2019, 7:57 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Anti-Harassment (Heth - ח), Patch-For-Review, MediaWiki-User-management
dmaza added a comment to T219441: Introduce a BlockManager service for getting and combining the blocks that apply to a user/IP.

@daniel are there any name conventions to follow for this "servicification" we are doing? Or any other conventions for that matter?
"Store, Service, Manager", are we using those names interchangeably?

Apr 9 2019, 4:31 PM · Anti-Harassment (Yōd - י), MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Core Platform Team Backlog (Watching / External), MediaWiki-User-management

Apr 5 2019

dmaza claimed T191549: Allow users to filter Special:BlockList on include/exclude partial blocks.
Apr 5 2019, 2:44 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Anti-Harassment (Heth - ח), Patch-For-Review, MediaWiki-User-management
dmaza moved T191549: Allow users to filter Special:BlockList on include/exclude partial blocks from Cards ready for development to Zayin - ז on the Anti-Harassment board.
Apr 5 2019, 2:43 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Anti-Harassment (Heth - ח), Patch-For-Review, MediaWiki-User-management

Apr 4 2019

dmaza closed T219218: Deploy partial blocks to French Wikipedia as Resolved.
Apr 4 2019, 6:55 PM · Anti-Harassment (Zayin - ז), MediaWiki-User-management
dmaza closed T219218: Deploy partial blocks to French Wikipedia, a subtask of T218626: [Epic] Partial block rollout, as Resolved.
Apr 4 2019, 6:55 PM · Epic, MediaWiki-User-management, User-notice, Wikimedia-Site-requests, Anti-Harassment
dmaza closed T219327: Deploy partial blocks on Polish wikipedia as Resolved.
Apr 4 2019, 6:55 PM · User-notice, Anti-Harassment (Zayin - ז), MediaWiki-User-management
dmaza closed T219327: Deploy partial blocks on Polish wikipedia, a subtask of T218626: [Epic] Partial block rollout, as Resolved.
Apr 4 2019, 6:54 PM · Epic, MediaWiki-User-management, User-notice, Wikimedia-Site-requests, Anti-Harassment
dmaza moved T219218: Deploy partial blocks to French Wikipedia from Review to Done on the Anti-Harassment (Zayin - ז) board.
Apr 4 2019, 6:54 PM · Anti-Harassment (Zayin - ז), MediaWiki-User-management
dmaza moved T219327: Deploy partial blocks on Polish wikipedia from Review to Done on the Anti-Harassment (Zayin - ז) board.
Apr 4 2019, 6:54 PM · User-notice, Anti-Harassment (Zayin - ז), MediaWiki-User-management

Apr 3 2019

dmaza moved T219218: Deploy partial blocks to French Wikipedia from Ready to Review on the Anti-Harassment (Zayin - ז) board.
Apr 3 2019, 8:08 PM · Anti-Harassment (Zayin - ז), MediaWiki-User-management
dmaza moved T219327: Deploy partial blocks on Polish wikipedia from Ready to Review on the Anti-Harassment (Zayin - ז) board.
Apr 3 2019, 8:08 PM · User-notice, Anti-Harassment (Zayin - ז), MediaWiki-User-management
dmaza claimed T219218: Deploy partial blocks to French Wikipedia.
Apr 3 2019, 8:08 PM · Anti-Harassment (Zayin - ז), MediaWiki-User-management
dmaza claimed T219327: Deploy partial blocks on Polish wikipedia.
Apr 3 2019, 8:08 PM · User-notice, Anti-Harassment (Zayin - ז), MediaWiki-User-management
dmaza updated the task description for T219327: Deploy partial blocks on Polish wikipedia.
Apr 3 2019, 8:07 PM · User-notice, Anti-Harassment (Zayin - ז), MediaWiki-User-management
dmaza updated the task description for T219218: Deploy partial blocks to French Wikipedia.
Apr 3 2019, 8:07 PM · Anti-Harassment (Zayin - ז), MediaWiki-User-management
dmaza moved T218554: Make sure the "Account creation" checkbox on the Special:Block form reflects the wpCreateAccount query param from In Progress to Review on the Anti-Harassment (Zayin - ז) board.
Apr 3 2019, 7:43 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Anti-Harassment (Zayin - ז), Documentation, MediaWiki-User-management
dmaza closed T208731: Clean up and Refactoring of the class Block Checklist(?) as Declined.

Declined in favor of T219441: Introduce a BlockManager service for getting and combining the blocks that apply to a user/IP

Apr 3 2019, 3:11 PM · MediaWiki-User-management
dmaza added a comment to T219441: Introduce a BlockManager service for getting and combining the blocks that apply to a user/IP.

Also, please consider splitting BlockManager and BlockStore. BlockStore would have all the things that touch the database, while BlockManager builds on top of BlockStore and does all the things related to cookies and sessions and such.

Apr 3 2019, 3:07 PM · Anti-Harassment (Yōd - י), MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Core Platform Team Backlog (Watching / External), MediaWiki-User-management

Apr 2 2019

dmaza added a comment to T216831: Disabling JavaScript on Special:Block allows you to block user from "Special" namespace (namespace=-1).

I feel like that's still a bug. We shouldn't allow for non-existing namespaces to be saved. At the very least we shouldn't display an empty namespace in the BlockList.

Apr 2 2019, 2:05 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Anti-Harassment (Zayin - ז), MediaWiki-User-management

Apr 1 2019

dmaza moved T219441: Introduce a BlockManager service for getting and combining the blocks that apply to a user/IP from Ready to In Progress on the Anti-Harassment (Zayin - ז) board.
Apr 1 2019, 8:08 PM · Anti-Harassment (Yōd - י), MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Core Platform Team Backlog (Watching / External), MediaWiki-User-management
dmaza moved T218554: Make sure the "Account creation" checkbox on the Special:Block form reflects the wpCreateAccount query param from Ready to In Progress on the Anti-Harassment (Zayin - ז) board.
Apr 1 2019, 8:07 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Anti-Harassment (Zayin - ז), Documentation, MediaWiki-User-management
dmaza claimed T218554: Make sure the "Account creation" checkbox on the Special:Block form reflects the wpCreateAccount query param.
Apr 1 2019, 8:07 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Anti-Harassment (Zayin - ז), Documentation, MediaWiki-User-management

Mar 29 2019

dmaza moved T219305: Partially blocked admins are unable to undelete pages from In Progress to Review on the Anti-Harassment (Zayin - ז) board.
Mar 29 2019, 5:18 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Anti-Harassment (Zayin - ז)

Mar 28 2019

dmaza added a comment to T219305: Partially blocked admins are unable to undelete pages.

Right so basically a partially blocked user with the undelete right should be to restore any page. They'll just be unable to do any other actions on it once it is restored (if the id happens to be the same after restoration)

Mar 28 2019, 9:35 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Anti-Harassment (Zayin - ז)
dmaza claimed T219305: Partially blocked admins are unable to undelete pages.
Mar 28 2019, 8:26 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Anti-Harassment (Zayin - ז)
dmaza moved T219305: Partially blocked admins are unable to undelete pages from Ready to In Progress on the Anti-Harassment (Zayin - ז) board.
Mar 28 2019, 8:26 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Anti-Harassment (Zayin - ז)
dmaza moved T216831: Disabling JavaScript on Special:Block allows you to block user from "Special" namespace (namespace=-1) from In Progress to Review on the Anti-Harassment (Zayin - ז) board.
Mar 28 2019, 8:26 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Anti-Harassment (Zayin - ז), MediaWiki-User-management

Mar 27 2019

dmaza moved T219327: Deploy partial blocks on Polish wikipedia from In Progress to Ready on the Anti-Harassment (Zayin - ז) board.
Mar 27 2019, 8:16 PM · User-notice, Anti-Harassment (Zayin - ז), MediaWiki-User-management
dmaza moved T219218: Deploy partial blocks to French Wikipedia from In Progress to Ready on the Anti-Harassment (Zayin - ז) board.
Mar 27 2019, 8:16 PM · Anti-Harassment (Zayin - ז), MediaWiki-User-management