Page MenuHomePhabricator

dmaza (Dayllan Maza)
Software Engineer

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jul 10 2017, 7:20 PM (126 w, 5 d)
Availability
Available
IRC Nick
DMaza
LDAP User
Dmaza
MediaWiki User
DMaza (WMF) [ Global Accounts ]

Recent Activity

Fri, Dec 13

dmaza added a comment to T238827: Reorganise preliminary check service for paginated results.

My apologies for the misunderstanding then.

Fri, Dec 13, 6:20 PM · Patch-For-Review, Anti-Harassment (The Letter Song), CheckUser
dmaza added a comment to T240530: CU 2.0: Filtering from data in Preliminary check, Compare and Timeline tabs.

Actually you are right. A cross makes more sense here since we are excluding from the search in this case

Fri, Dec 13, 3:29 AM · CheckUser
dmaza added a comment to T240300: Introduce a temporary banner on Special:Block to inform users about upcoming partial blocks deploy.

I don't think so. The messages are ready to be translated. I just did es :)

Fri, Dec 13, 3:26 AM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Anti-Harassment (The Letter Song)

Thu, Dec 12

dmaza updated the task description for T212392: Edit block and save without making changes should not display "XYZUser" is already blocked.".
Thu, Dec 12, 10:02 PM · MediaWiki-User-management
dmaza added a comment to T212392: Edit block and save without making changes should not display "XYZUser" is already blocked.".
In T212392, @dmaza wrote:

... no changes to the block should take you to the "Block succeed" page

If you did not change anything, then there's nothing that "succeed". Taking person to a success page without doing anything seems misleading to me.
The suggestion by Tbolliger is apt here. If there's no changes to the block at all, the block button should remain disabled.
That sends clear message you should either change something and save, or leave it as it's (no chnage, no save) and navigate away.

Thu, Dec 12, 10:01 PM · MediaWiki-User-management
dmaza added a comment to T238714: CU 2.0: Fetch information to be displayed in Compare tab.

So just to be clear, what goes inside the parenthesis in the IP column should be UA independent. Right?

Thu, Dec 12, 8:54 PM · Patch-For-Review, Anti-Harassment (The Letter Song), CheckUser
dmaza added a comment to T238827: Reorganise preliminary check service for paginated results.

We really need to get more things in writing 'cause I recall having this conversation with someone at some point and completely forgot about it. Having had this information while we were deciding to use a pager or a fake wrapper would have significantly speed the decision and make it easy and obvious (at least to me)

Thu, Dec 12, 8:50 PM · Patch-For-Review, Anti-Harassment (The Letter Song), CheckUser
dmaza added a comment to T240530: CU 2.0: Filtering from data in Preliminary check, Compare and Timeline tabs.

Which icon is better — trash, cross, funnel?

AFAIK a funnel is generally understood as "filter".

Thu, Dec 12, 8:06 PM · CheckUser
dmaza moved T240585: "Undefined variable: globalUser" submitting Special:Investigate form without CentralAuth from Ready to Review on the Anti-Harassment (The Letter Song) board.
Thu, Dec 12, 6:55 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Anti-Harassment (The Letter Song), CheckUser
dmaza moved T240585: "Undefined variable: globalUser" submitting Special:Investigate form without CentralAuth from Untriaged to The Letter Song on the Anti-Harassment board.
Thu, Dec 12, 6:54 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Anti-Harassment (The Letter Song), CheckUser
dmaza claimed T240585: "Undefined variable: globalUser" submitting Special:Investigate form without CentralAuth.
Thu, Dec 12, 6:50 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Anti-Harassment (The Letter Song), CheckUser
dmaza moved T240300: Introduce a temporary banner on Special:Block to inform users about upcoming partial blocks deploy from In Progress to Review on the Anti-Harassment (The Letter Song) board.
Thu, Dec 12, 5:14 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Anti-Harassment (The Letter Song)

Tue, Dec 10

dmaza claimed T240300: Introduce a temporary banner on Special:Block to inform users about upcoming partial blocks deploy.
Tue, Dec 10, 8:53 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Anti-Harassment (The Letter Song)
dmaza moved T240300: Introduce a temporary banner on Special:Block to inform users about upcoming partial blocks deploy from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
Tue, Dec 10, 8:53 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Anti-Harassment (The Letter Song)

Mon, Dec 2

dmaza added a comment to T238714: CU 2.0: Fetch information to be displayed in Compare tab.

Edits from the same IP are likely logged-out edits from the same user, relevant to the SPI, thus imo it makes sense to include those edits.
If IP Editing Privacy Enhancement moves forward, these edits will belong to an auto-generated user handle, anyway.

Mon, Dec 2, 6:12 PM · Patch-For-Review, Anti-Harassment (The Letter Song), CheckUser

Wed, Nov 27

dmaza added a comment to T238714: CU 2.0: Fetch information to be displayed in Compare tab.

@Prtksxna @Niharika
Using the first row on the example table, when we say 1.2.3.4 - 17 edits (10 from 3 other users), the way I see it it breaks down as follows:

  • Banana made 17 edits
  • Other users made 10 edits
  • The total of edits from that IP is 27
Wed, Nov 27, 9:04 PM · Patch-For-Review, Anti-Harassment (The Letter Song), CheckUser
dmaza added a comment to T237296: CheckUser 2.0: Create service and methods for new CU extension.

@dmaza Submitting the Special:Investigate form on a wiki without CentralAuth, I see in the logs:

[error] [f7d4d69c1c92ecf5b9e28a69] /core/index.php/Special:Investigate   ErrorException from line 83 of /var/www/html/core/extensions/CheckUser/src/PreliminaryCheckService.php: PHP Notice: Undefined variable: globalUser
#0 /var/www/html/core/extensions/CheckUser/src/PreliminaryCheckService.php(83): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /var/www/html/core/extensions/CheckUser/src/PreliminaryCheckService.php(61): MediaWiki\CheckUser\PreliminaryCheckService->getGlobalUser(User)
#2 /var/www/html/core/extensions/CheckUser/src/PreliminaryCheckService.php(44): MediaWiki\CheckUser\PreliminaryCheckService->getAttachedWikis(User)
#3 /var/www/html/core/extensions/CheckUser/includes/specials/pagers/PreliminaryCheckPager.php(59): MediaWiki\CheckUser\PreliminaryCheckService->getPreliminaryData(array)
#4 /var/www/html/core/includes/pager/IndexPager.php(616): PreliminaryCheckPager->doQuery()
#5 /var/www/html/core/extensions/CheckUser/includes/specials/SpecialInvestigate.php(120): IndexPager->getNumRows()
#6 /var/www/html/core/includes/htmlform/HTMLForm.php(694): SpecialInvestigate->onSubmit(array, OOUIHTMLForm)
#7 /var/www/html/core/includes/htmlform/HTMLForm.php(586): HTMLForm->trySubmit()
#8 /var/www/html/core/includes/htmlform/HTMLForm.php(601): HTMLForm->tryAuthorizedSubmit()
#9 /var/www/html/core/extensions/CheckUser/includes/specials/SpecialInvestigate.php(41): HTMLForm->show()
#10 /var/www/html/core/includes/specialpage/SpecialPage.php(575): SpecialInvestigate->execute(NULL)
#11 /var/www/html/core/includes/specialpage/SpecialPageFactory.php(607): SpecialPage->run(NULL)
#12 /var/www/html/core/includes/MediaWiki.php(298): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#13 /var/www/html/core/includes/MediaWiki.php(967): MediaWiki->performRequest()
#14 /var/www/html/core/includes/MediaWiki.php(530): MediaWiki->main()
#15 /var/www/html/core/index.php(46): MediaWiki->run()
#16 {main}

I don't know if this is something we need to support.

Wed, Nov 27, 5:01 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Patch-For-Review, Anti-Harassment (The Letter Song), CheckUser

Fri, Nov 22

dmaza claimed T238714: CU 2.0: Fetch information to be displayed in Compare tab.
Fri, Nov 22, 4:02 PM · Patch-For-Review, Anti-Harassment (The Letter Song), CheckUser
dmaza moved T238714: CU 2.0: Fetch information to be displayed in Compare tab from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
Fri, Nov 22, 4:01 PM · Patch-For-Review, Anti-Harassment (The Letter Song), CheckUser

Thu, Nov 21

dmaza closed T238787: Show preliminary data for IP and IP Ranges, a subtask of T237039: [Epic] CheckUser 2.0: Preliminary check, as Declined.
Thu, Nov 21, 2:53 AM · Epic, CheckUser, Anti-Harassment
dmaza closed T238787: Show preliminary data for IP and IP Ranges as Declined.
Thu, Nov 21, 2:53 AM · Anti-Harassment, CheckUser

Wed, Nov 20

dmaza moved T238787: Show preliminary data for IP and IP Ranges from Untriaged to Backlog on the Anti-Harassment board.
Wed, Nov 20, 9:23 PM · Anti-Harassment, CheckUser
dmaza moved T237296: CheckUser 2.0: Create service and methods for new CU extension from In Progress to Review on the Anti-Harassment (The Letter Song) board.
Wed, Nov 20, 9:22 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Patch-For-Review, Anti-Harassment (The Letter Song), CheckUser
dmaza added a subtask for T237039: [Epic] CheckUser 2.0: Preliminary check: T238787: Show preliminary data for IP and IP Ranges.
Wed, Nov 20, 8:05 PM · Epic, CheckUser, Anti-Harassment
dmaza added a parent task for T238787: Show preliminary data for IP and IP Ranges: T237039: [Epic] CheckUser 2.0: Preliminary check.
Wed, Nov 20, 8:05 PM · Anti-Harassment, CheckUser
dmaza created T238787: Show preliminary data for IP and IP Ranges.
Wed, Nov 20, 8:05 PM · Anti-Harassment, CheckUser

Nov 14 2019

dmaza added a comment to T237296: CheckUser 2.0: Create service and methods for new CU extension.

@Niharika What is the acceptance criteria for this task? Should ip users also be supported as part of this or is it supporting only registered accounts enough?

Nov 14 2019, 9:53 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Patch-For-Review, Anti-Harassment (The Letter Song), CheckUser
dmaza moved T231577: Deploy Special:Mute features from In Progress to Review on the Anti-Harassment (The Letter Song) board.
Nov 14 2019, 9:51 PM · Anti-Harassment (The Letter Song), Epic
dmaza changed the status of T231577: Deploy Special:Mute features from Open to Stalled.

Waiting on T237532: Preferences are saved as GlobalPreferences when autoglobal is enabled for the field to be fixed

Nov 14 2019, 9:11 PM · Anti-Harassment (The Letter Song), Epic
dmaza updated subscribers of T235047: [Spike: 4 hours] RedirectSpecialPage not setting block cookies after redirect.

@dmaza After the server returns a 301/302 and the page gets redirected... why doesn't the next request (that results in a 200) have the cookies?

Nov 14 2019, 8:58 PM · Core Platform Team Workboards (Clinic Duty Team), Spike, MediaWiki-User-management

Nov 13 2019

dmaza added a comment to T237296: CheckUser 2.0: Create service and methods for new CU extension.

Although (and I tried this with GraphQL extension and it works well), you can construct a FauxRequest and pass it to an API module directly... that would allow you to "call the API" without actually opening up another process in Apache. Though, MediaWiki doesn't support "sub requests" like that very well, so not sure how acceptable it would be. Then again, this is an extension, so do what you want. :)

Nov 13 2019, 4:11 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Patch-For-Review, Anti-Harassment (The Letter Song), CheckUser

Nov 12 2019

dmaza added a comment to T237296: CheckUser 2.0: Create service and methods for new CU extension.

Considering that the use of internal API requests is discouraged I assume that we are mentioning CentralAuth API only if we can't run the db queries and instead we would load whatever we need from the client side using ajax. Am I wrong?

Nov 12 2019, 9:35 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Patch-For-Review, Anti-Harassment (The Letter Song), CheckUser

Nov 8 2019

dmaza added a comment to T236981: CheckUser 2.0: Create a new Special page in CheckUser for the redesigned version.

@Niharika Is CheckUser2 the name we are gonna go with? Can we go for something that can stick even if the current CheckUser cease to exists?
Here are some ideas for the name of the page (I know words like "Investigation" carry some weight but maybe somehing similar to that(?)

  • InspectUser
  • ExamineUser
  • CheckUserInvestigation
Nov 8 2019, 2:22 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Anti-Harassment (The Letter Song), CheckUser
dmaza claimed T237296: CheckUser 2.0: Create service and methods for new CU extension.
Nov 8 2019, 2:08 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Patch-For-Review, Anti-Harassment (The Letter Song), CheckUser
dmaza moved T237296: CheckUser 2.0: Create service and methods for new CU extension from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
Nov 8 2019, 2:08 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Patch-For-Review, Anti-Harassment (The Letter Song), CheckUser
dmaza added a comment to T235047: [Spike: 4 hours] RedirectSpecialPage not setting block cookies after redirect.

Writing down what I found

Nov 8 2019, 4:07 AM · Core Platform Team Workboards (Clinic Duty Team), Spike, MediaWiki-User-management

Nov 6 2019

dmaza claimed T235047: [Spike: 4 hours] RedirectSpecialPage not setting block cookies after redirect.
Nov 6 2019, 1:44 PM · Core Platform Team Workboards (Clinic Duty Team), Spike, MediaWiki-User-management
dmaza moved T235047: [Spike: 4 hours] RedirectSpecialPage not setting block cookies after redirect from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
Nov 6 2019, 1:44 PM · Core Platform Team Workboards (Clinic Duty Team), Spike, MediaWiki-User-management
dmaza created T237532: Preferences are saved as GlobalPreferences when autoglobal is enabled for the field.
Nov 6 2019, 1:36 PM · Anti-Harassment, Community-Tech, MediaWiki-extensions-GlobalPreferences

Nov 1 2019

dmaza moved T231577: Deploy Special:Mute features from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
Nov 1 2019, 1:36 PM · Anti-Harassment (The Letter Song), Epic
dmaza moved T227892: [BUG] InvalidArgumentException "Blocker must be a local user or a name that cannot be a local user" from Ready to QA/Testing on the Anti-Harassment (The Letter Song) board.
Nov 1 2019, 12:18 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Anti-Harassment (The Letter Song), MediaWiki-User-management

Oct 28 2019

dmaza updated subscribers of T199174: Special:BlockList gives faulty results after an admin changes another admin's block.

Isn't just $currentBlock->setBlocker( $performer ); missing in SpecialBlock.php?

Oct 28 2019, 1:42 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), MediaWiki-User-management

Sep 26 2019

MusikAnimal awarded T232510: Add namespace filter to the interaction-timeline API a Love token.
Sep 26 2019, 5:15 AM · Anti-Harassment (The Letter Song), InteractionTimeline

Sep 23 2019

dmaza added a comment to T233441: Cookie blocks apply regardless of ipblock-exempt right.

@dmaza - do you have any thoughts on changing the config back to false in core?

Sep 23 2019, 8:19 PM · MediaWiki-User-management

Sep 17 2019

dmaza added a comment to T233119: Intended use of MinimumPasswordLengthToLogin not so clear.

Looking into this

Sep 17 2019, 5:23 PM · Core Platform Team Workboards (Clinic Duty Team), MW-1.31-release-notes, MW-1.32-notes, MW-1.33-notes, Documentation, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Trust-and-Safety, MediaWiki-Authentication-and-authorization, Anti-Harassment, MediaWiki-User-login-and-signup

Sep 16 2019

dmaza moved T231577: Deploy Special:Mute features from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
Sep 16 2019, 6:33 PM · Anti-Harassment (The Letter Song), Epic
dmaza claimed T231577: Deploy Special:Mute features.
Sep 16 2019, 6:25 PM · Anti-Harassment (The Letter Song), Epic
dmaza closed T185785: Display an error message when users do not have JavaScript enabled as Resolved.
Sep 16 2019, 5:56 PM · Anti-Harassment (The Letter Song), InteractionTimeline
dmaza moved T232510: Add namespace filter to the interaction-timeline API from In Progress to Review on the Anti-Harassment (The Letter Song) board.
Sep 16 2019, 2:59 PM · Anti-Harassment (The Letter Song), InteractionTimeline

Sep 13 2019

dmaza added a comment to T232510: Add namespace filter to the interaction-timeline API.

Pull Request here: https://github.com/wikimedia/InteractionTimeline/pull/117

Sep 13 2019, 3:36 AM · Anti-Harassment (The Letter Song), InteractionTimeline

Sep 12 2019

dmaza created T232753: Flow throws an exception for a particular User.
Sep 12 2019, 3:13 PM · Growth-Team, StructuredDiscussions, Wikimedia-production-error

Sep 11 2019

dmaza moved T232510: Add namespace filter to the interaction-timeline API from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
Sep 11 2019, 4:31 AM · Anti-Harassment (The Letter Song), InteractionTimeline

Sep 10 2019

dmaza claimed T232510: Add namespace filter to the interaction-timeline API.
Sep 10 2019, 5:47 PM · Anti-Harassment (The Letter Song), InteractionTimeline
dmaza created T232510: Add namespace filter to the interaction-timeline API.
Sep 10 2019, 5:47 PM · Anti-Harassment (The Letter Song), InteractionTimeline
dmaza updated subscribers of T190973: Timeline: Namespace filter.

@Niharika @dbarratt should we split this up into an server/client task? I'm happy to take on the server side of things

Sep 10 2019, 4:48 PM · InteractionTimeline

Sep 5 2019

dmaza added a comment to T191922: Enable $wgCookieSetOnIpBlock by default after the IP cookie block feature is fully tested and released.

@Jdforrester-WMF Since CommonSettings is currently setting these two configs to true there shouldn't be any problems I assume.

Sep 5 2019, 9:50 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), MW-1.34-release, MediaWiki-User-management, MediaWiki-Configuration

Sep 3 2019

dmaza added a comment to T224468: Block list and log incorrectly report "cannot edit own talk page" for some blocks.

I'd advocate for fixing all at once if there's a clean way to do it. @dmaza did you have a way in mind?

I do not.

Sep 3 2019, 7:49 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Anti-Harassment (The Letter Song), MediaWiki-User-management

Aug 27 2019

dmaza updated the task description for T229692: Use GetUserBlockComplete hook instead of GetBlockedStatus in TorBlock extension.
Aug 27 2019, 10:44 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-extensions-TorBlock, MediaWiki-User-management

Aug 26 2019

dmaza added a project to T231109: Remove Core coupling with GlobalBlocking extension: GlobalBlocking.
Aug 26 2019, 6:04 PM · GlobalBlocking, MediaWiki-User-management

Aug 23 2019

dmaza added projects to T231109: Remove Core coupling with GlobalBlocking extension: Core Platform Team, MediaWiki-User-management.
Aug 23 2019, 7:17 PM · GlobalBlocking, MediaWiki-User-management
dmaza created T231109: Remove Core coupling with GlobalBlocking extension.
Aug 23 2019, 6:17 PM · GlobalBlocking, MediaWiki-User-management

Aug 22 2019

dmaza closed T227678: Clear block cookie if the value is invalid as Resolved.
Aug 22 2019, 1:59 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Anti-Harassment (The Letter Song), MediaWiki-User-management

Aug 19 2019

dmaza moved T227005: Don't require that the blocker be a User for a SystemBlock from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
Aug 19 2019, 7:07 PM · Patch-For-Review, Anti-Harassment (The Letter Song), MediaWiki-User-management
dmaza claimed T227005: Don't require that the blocker be a User for a SystemBlock.
Aug 19 2019, 7:06 PM · Patch-For-Review, Anti-Harassment (The Letter Song), MediaWiki-User-management
dmaza moved T227678: Clear block cookie if the value is invalid from In Progress to Review on the Anti-Harassment (The Letter Song) board.
Aug 19 2019, 7:05 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Anti-Harassment (The Letter Song), MediaWiki-User-management
dmaza moved T224958: Instrument Special:Mute from In Progress to Review on the Anti-Harassment (The Letter Song) board.
Aug 19 2019, 7:05 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Analytics, Anti-Harassment (The Letter Song)

Aug 15 2019

dmaza added a comment to T185785: Display an error message when users do not have JavaScript enabled.

I think that's a bit gross. I would honestly rather just leave that English-only than do that.

Do you care to expand on this? I don't think "gross" is a valid argument

Aug 15 2019, 6:46 PM · Anti-Harassment (The Letter Song), InteractionTimeline
dmaza added a comment to T185785: Display an error message when users do not have JavaScript enabled.

would we rather:

  1. Enable server-rendering which will allow us to display the message in the user’s language. This will require splitting the tool into two tools (which is trivial, imho, and can remain in a single repo if we want): https://lists.wikimedia.org/pipermail/cloud/2019-August/000774.html
  2. Leave the app as “static” and display the message in all languages?
Aug 15 2019, 4:27 PM · Anti-Harassment (The Letter Song), InteractionTimeline

Aug 13 2019

dmaza moved T227678: Clear block cookie if the value is invalid from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
Aug 13 2019, 8:13 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Anti-Harassment (The Letter Song), MediaWiki-User-management
dmaza claimed T227678: Clear block cookie if the value is invalid.
Aug 13 2019, 8:12 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Anti-Harassment (The Letter Song), MediaWiki-User-management
dmaza added a comment to T224958: Instrument Special:Mute.

@Milimetric @nettrom_WMF correct me if I'm wrong but other than annotating that the schema is active[1] there isn't anything else I need to do to start logging events other than deploying the code[2] that would make use of it, right?

Aug 13 2019, 7:18 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Analytics, Anti-Harassment (The Letter Song)

Aug 5 2019

dmaza added a comment to T224958: Instrument Special:Mute.

Here is the schema for our data capture. Feel free to make changes and I'll fix up the patches
https://meta.wikimedia.org/wiki/Schema:SpecialMuteSubmit

Aug 5 2019, 8:04 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Analytics, Anti-Harassment (The Letter Song)
dmaza added a comment to T224468: Block list and log incorrectly report "cannot edit own talk page" for some blocks.

@dom_walden can you confirm that the issue is fixed tho? (Block list and log incorrectly report "cannot edit own talk page" for some blocks) I'll take a look at how the form displays the errors anyway

Aug 5 2019, 7:32 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Anti-Harassment (The Letter Song), MediaWiki-User-management
dmaza moved T224468: Block list and log incorrectly report "cannot edit own talk page" for some blocks from QA/Testing to In Progress on the Anti-Harassment (The Letter Song) board.
Aug 5 2019, 7:30 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Anti-Harassment (The Letter Song), MediaWiki-User-management
dmaza added a comment to T224468: Block list and log incorrectly report "cannot edit own talk page" for some blocks.

@dmaza Would it be better if the error message appeared underneath the "Editing their own talk page" checkbox?
This would make it immediately obvious what it refers to and would make it consistent with the location of other error messages (see below).

Makes sense, I'll fix it

Aug 5 2019, 7:30 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Anti-Harassment (The Letter Song), MediaWiki-User-management

Jul 30 2019

dmaza removed a watcher for LibUp: dmaza.
Jul 30 2019, 6:23 PM
dmaza moved T224468: Block list and log incorrectly report "cannot edit own talk page" for some blocks from In Progress to Review on the Anti-Harassment (The Letter Song) board.
Jul 30 2019, 2:41 AM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Anti-Harassment (The Letter Song), MediaWiki-User-management
dmaza claimed T224958: Instrument Special:Mute.
Jul 30 2019, 2:40 AM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Analytics, Anti-Harassment (The Letter Song)
dmaza moved T224958: Instrument Special:Mute from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
Jul 30 2019, 2:40 AM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Analytics, Anti-Harassment (The Letter Song)
dmaza added a comment to T224468: Block list and log incorrectly report "cannot edit own talk page" for some blocks.

Works for me.

Great

Jul 30 2019, 2:33 AM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Anti-Harassment (The Letter Song), MediaWiki-User-management
dmaza added a comment to T224468: Block list and log incorrectly report "cannot edit own talk page" for some blocks.

I'm saying you can show the error message, but the field may be disabled, so they may not be able to correct the error.

Jul 30 2019, 2:27 AM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Anti-Harassment (The Letter Song), MediaWiki-User-management

Jul 24 2019

dmaza added a comment to T218270: Mute: Add links to the Tools menu on user pages to mute/unmute user.

Sure, lets have another task and we can investigate there

Jul 24 2019, 7:44 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), MediaWiki-Email, Notifications, Growth-Team
dmaza renamed T228899: ApiGlobalBlock.php: Trying to get property 'gb_expiry' of non-object from Block.php: Trying to get property 'gb_expiry' of non-object to ApiGlobalBlock.php: Trying to get property 'gb_expiry' of non-object.
Jul 24 2019, 4:47 PM · Anti-Harassment, GlobalBlocking, Wikimedia-production-error
dmaza added a comment to T218270: Mute: Add links to the Tools menu on user pages to mute/unmute user.

Assuming $wgEnableSpecialMute = true. Neither $wgEnableUserEmailBlacklist nor $wgEchoPerUserBlacklist has to be true, which means you can see this link even if there is nothing you can do with it. I don't know why you would configure your wiki like this, though.

@dmaza I don't think we should show the link if the page is going to throw an error anyways. It's effectively an access denied (and perhaps we could use that mechanism?).

It shows an error message saying "Mute features are unavailable. This might be because: you haven't confirmed your email address or the wiki administrator has disabled email features and/or email blacklist for this wiki. "
We could check for $wgEnableUserEmailBlacklist but we can't check for $wgEchoPerUserBlacklist. I don't think there is anything we can do really other than what's already in place.

Jul 24 2019, 3:23 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), MediaWiki-Email, Notifications, Growth-Team

Jul 23 2019

dmaza closed T218270: Mute: Add links to the Tools menu on user pages to mute/unmute user, a subtask of T164542: Epic: ⚡️ General user mute/block feature, as Resolved.
Jul 23 2019, 7:49 PM · MediaWiki-extension-requests, Anti-Harassment
dmaza closed T218270: Mute: Add links to the Tools menu on user pages to mute/unmute user, a subtask of T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser, as Resolved.
Jul 23 2019, 7:49 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Email
dmaza closed T218270: Mute: Add links to the Tools menu on user pages to mute/unmute user as Resolved.
Jul 23 2019, 7:48 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), MediaWiki-Email, Notifications, Growth-Team

Jul 16 2019

dmaza added a comment to T224468: Block list and log incorrectly report "cannot edit own talk page" for some blocks.

If a user tries to save ipb_allow_usertalk in a way that does not conform with those rules, an error message should be shown and the block should not be saved.

Or maybe just do the thing that is expected, rather than throwing an error (because if the form field is in a disabled state, you wont be able to resolve the error).
In other words, DWIM.

Jul 16 2019, 2:26 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Anti-Harassment (The Letter Song), MediaWiki-User-management

Jul 11 2019

dmaza added a comment to T220163: Allow user to mute notifications from Special:Mute page.

@dmaza @dbarratt I agree it seems repetitive. We can make the user's name bold in the sentence above to make it a bit more prominent but let's go with ...from this user for now.

Jul 11 2019, 10:59 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song)
dmaza moved T220163: Allow user to mute notifications from Special:Mute page from Review to In Progress on the Anti-Harassment (The Letter Song) board.
Jul 11 2019, 7:37 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song)
dmaza moved T224468: Block list and log incorrectly report "cannot edit own talk page" for some blocks from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
Jul 11 2019, 5:17 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Anti-Harassment (The Letter Song), MediaWiki-User-management
dmaza claimed T224468: Block list and log incorrectly report "cannot edit own talk page" for some blocks.
Jul 11 2019, 5:17 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Anti-Harassment (The Letter Song), MediaWiki-User-management
dmaza updated the task description for T224468: Block list and log incorrectly report "cannot edit own talk page" for some blocks.
Jul 11 2019, 5:17 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Anti-Harassment (The Letter Song), MediaWiki-User-management
dmaza added a comment to T220163: Allow user to mute notifications from Special:Mute page.

Instead of saying "Mute emails from this user" and "Mute emails from this user" would it be better to say: "Mute emails from user ABC" and "Mute notifications from user ABC"?
I was just wondering because when I first come to the page, my brain skips the first line entirely and I read the options, which use this and then I have to figure out what this is.

Jul 11 2019, 3:24 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song)
dmaza moved T218270: Mute: Add links to the Tools menu on user pages to mute/unmute user from In Progress to Review on the Anti-Harassment (The Letter Song) board.
Jul 11 2019, 4:28 AM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), MediaWiki-Email, Notifications, Growth-Team
dmaza updated the task description for T218270: Mute: Add links to the Tools menu on user pages to mute/unmute user.
Jul 11 2019, 4:18 AM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), MediaWiki-Email, Notifications, Growth-Team

Jul 10 2019

dmaza added a comment to T227199: 'Editing their own talk page' option has no effect when editing not selected.

If the issue is that after unchecking "Editing", "Editing their own [...]" remains checked (although disabled), that will/should be fixed on T221117: Special:Block checkboxes should remember checked state. I personally don't see a problem other than what's described on T221117

Jul 10 2019, 2:47 PM · User-RhinosF1, Anti-Harassment, MediaWiki-User-management
dmaza added a comment to T227199: 'Editing their own talk page' option has no effect when editing not selected.

I'm a bit confused as to what is the issue here

Expected Result:
Either:
Grey 'Editing their own talk page' when editing blocks are disabled

Isn't this what's happening right now?

Jul 10 2019, 1:11 PM · User-RhinosF1, Anti-Harassment, MediaWiki-User-management

Jul 8 2019

dmaza moved T218270: Mute: Add links to the Tools menu on user pages to mute/unmute user from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
Jul 8 2019, 7:49 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), MediaWiki-Email, Notifications, Growth-Team
dmaza claimed T218270: Mute: Add links to the Tools menu on user pages to mute/unmute user.
Jul 8 2019, 7:49 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), MediaWiki-Email, Notifications, Growth-Team