Fri, May 17
You could also create a new topic on https://www.mediawiki.org/wiki/Manual_talk:Coding_conventions/PHP. It might add more visibility.
Fri, May 3
I think that supporting the definition to be either a callable or a string would be ideal (so a combination of your suggestions). It will make it backward compatible and we can start migrating into DI in incremental changes. SpecialPageFactory::getPage() already supports a string or a callable so a "quick" change would be to make $coreList non-static and adjust the SpecialPageFactory accordingly.
I'm not sure about Api Modules 'cause I haven't seen how that works
Thu, May 2
i did say feature flag originally ;)
You did, sorry I missed it :)
Copying over the "in-patch" comment for better discussion
Mon, Apr 29
Wed, Apr 24
Apr 19 2019
It might also be a good idea to provide more info about mute (https://www.mediawiki.org/wiki/Help:Notifications#mute) and/or more information on how they can see their current email/mute list on Special:Preferences
Apr 17 2019
Apr 16 2019
I'm going with No matching blocks found for the requested IP address or username
Apr 15 2019
Apr 9 2019
What is the plan here exactly? Is there any deprecation process that we have to go through?
Do we want to rename the BlockRestriction class to something else?
@daniel are there any name conventions to follow for this "servicification" we are doing? Or any other conventions for that matter?
"Store, Service, Manager", are we using those names interchangeably?
Apr 5 2019
Apr 4 2019
Apr 3 2019
Also, please consider splitting BlockManager and BlockStore. BlockStore would have all the things that touch the database, while BlockManager builds on top of BlockStore and does all the things related to cookies and sessions and such.
Apr 2 2019
I feel like that's still a bug. We shouldn't allow for non-existing namespaces to be saved. At the very least we shouldn't display an empty namespace in the BlockList.
Apr 1 2019
Mar 29 2019
Mar 28 2019
Right so basically a partially blocked user with the undelete right should be to restore any page. They'll just be unable to do any other actions on it once it is restored (if the id happens to be the same after restoration)
Mar 27 2019
Mar 25 2019
Mar 22 2019
@dom_walden good catch. This patch fixes the advertise bug as well. There is a separate issue and that is that the user doesn't get any feedback when they are blocked and try to advertise but that's unrelated to PB.
Mar 21 2019
@dmaza Did the team ever discuss this? It makes sense to me to update these pages too. I can go ahead and add them to the ticket description if there are no concerns.
Mar 20 2019
Mar 19 2019
@Niharika the patch will not remove the data but I'm not sure for how long we keep those metrics around. I can't find anything on wikitech about it.