Page MenuHomePhabricator

dmaza (Dayllan Maza)
Software Engineer

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jul 10 2017, 7:20 PM (88 w, 5 d)
Availability
Available
IRC Nick
DMaza
LDAP User
Dmaza
MediaWiki User
DMaza (WMF) [ Global Accounts ]

Recent Activity

Fri, Mar 22

dmaza added a comment to T218949: When flagged revisions are in effect, users cannot review revisions if partially blocked.

@dom_walden good catch. This patch fixes the advertise bug as well. There is a separate issue and that is that the user doesn't get any feedback when they are blocked and try to advertise but that's unrelated to PB.

Fri, Mar 22, 3:52 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Anti-Harassment (Vav — ו), MediaWiki-User-management
dmaza added a comment to T218949: When flagged revisions are in effect, users cannot review revisions if partially blocked.

Note: if you want I can make a short video.

Fri, Mar 22, 2:32 AM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Anti-Harassment (Vav — ו), MediaWiki-User-management

Thu, Mar 21

dmaza added a comment to T204904: Create/update technical documentation for Partial Blocks.

@dmaza Did the team ever discuss this? It makes sense to me to update these pages too. I can go ahead and add them to the ticket description if there are no concerns.

Thu, Mar 21, 4:03 PM · Anti-Harassment (Vav — ו), MediaWiki-User-management, Documentation
dmaza updated the task description for T204904: Create/update technical documentation for Partial Blocks.
Thu, Mar 21, 4:01 PM · Anti-Harassment (Vav — ו), MediaWiki-User-management, Documentation

Wed, Mar 20

dmaza moved T216831: Disabling JavaScript on Special:Block allows you to block user from "Special" namespace (namespace=-1) from Ready to In Progress on the Anti-Harassment (Vav — ו) board.
Wed, Mar 20, 5:09 PM · Anti-Harassment (Vav — ו), MediaWiki-User-management
dmaza claimed T216831: Disabling JavaScript on Special:Block allows you to block user from "Special" namespace (namespace=-1).
Wed, Mar 20, 5:08 PM · Anti-Harassment (Vav — ו), MediaWiki-User-management
dmaza moved T216831: Disabling JavaScript on Special:Block allows you to block user from "Special" namespace (namespace=-1) from Cards ready for development to Vav — ו on the Anti-Harassment board.
Wed, Mar 20, 5:08 PM · Anti-Harassment (Vav — ו), MediaWiki-User-management

Tue, Mar 19

dmaza moved T218596: Remove stats for measuring when blocks are tracked with a Cookie from Review to Done on the Anti-Harassment (Vav — ו) board.
Tue, Mar 19, 10:02 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Anti-Harassment (Vav — ו), Patch-For-Review
dmaza updated subscribers of T218596: Remove stats for measuring when blocks are tracked with a Cookie.

That would make sense. IMO I don't think this data is worth keeping. Pinging @Tchanders @dbarratt @aezell for their thoughts.

Tue, Mar 19, 10:02 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Anti-Harassment (Vav — ו), Patch-For-Review
dmaza added a comment to T218596: Remove stats for measuring when blocks are tracked with a Cookie.

@Niharika the patch will not remove the data but I'm not sure for how long we keep those metrics around. I can't find anything on wikitech.

Tue, Mar 19, 5:57 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Anti-Harassment (Vav — ו), Patch-For-Review
dmaza updated the task description for T218596: Remove stats for measuring when blocks are tracked with a Cookie.
Tue, Mar 19, 3:21 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Anti-Harassment (Vav — ו), Patch-For-Review
dmaza updated the task description for T218596: Remove stats for measuring when blocks are tracked with a Cookie.
Tue, Mar 19, 3:21 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Anti-Harassment (Vav — ו), Patch-For-Review
dmaza claimed T218596: Remove stats for measuring when blocks are tracked with a Cookie.
Tue, Mar 19, 3:19 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Anti-Harassment (Vav — ו), Patch-For-Review
dmaza moved T218596: Remove stats for measuring when blocks are tracked with a Cookie from Ready to Review on the Anti-Harassment (Vav — ו) board.
Tue, Mar 19, 3:18 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Anti-Harassment (Vav — ו), Patch-For-Review
dmaza edited projects for T218596: Remove stats for measuring when blocks are tracked with a Cookie, added: Anti-Harassment (Vav — ו); removed Anti-Harassment.
Tue, Mar 19, 3:18 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Anti-Harassment (Vav — ו), Patch-For-Review
dmaza updated the task description for T218596: Remove stats for measuring when blocks are tracked with a Cookie.
Tue, Mar 19, 3:11 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Anti-Harassment (Vav — ו), Patch-For-Review

Mon, Mar 18

dmaza added a project to T218596: Remove stats for measuring when blocks are tracked with a Cookie: Anti-Harassment.
Mon, Mar 18, 4:17 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Anti-Harassment (Vav — ו), Patch-For-Review
dmaza created T218596: Remove stats for measuring when blocks are tracked with a Cookie.
Mon, Mar 18, 4:17 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Anti-Harassment (Vav — ו), Patch-For-Review
dmaza moved T211622: Change password length requirement and ensure enforcement for non-privileged users (from 1 to 8) from In Progress to Review on the Anti-Harassment (Vav — ו) board.
Mon, Mar 18, 3:59 PM · Anti-Harassment (Vav — ו), Patch-For-Review, MediaWiki-User-login-and-signup

Fri, Mar 15

dmaza added a comment to T211621: The 'your password is weak' message should display on log in for privileged accounts only.

I notice that users in the "staff" group will have

['MinimumPasswordLengthToLogin'] = [
  'value' => 10,
  'suggestChangeOnLogin' => true,
];

and I believe this will force them to change their passwords.

Fri, Mar 15, 5:55 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Anti-Harassment (Vav — ו), Patch-For-Review, MediaWiki-User-login-and-signup

Wed, Mar 13

dmaza moved T211622: Change password length requirement and ensure enforcement for non-privileged users (from 1 to 8) from Ready to In Progress on the Anti-Harassment (Vav — ו) board.
Wed, Mar 13, 7:11 PM · Anti-Harassment (Vav — ו), Patch-For-Review, MediaWiki-User-login-and-signup

Tue, Mar 12

dmaza claimed T211622: Change password length requirement and ensure enforcement for non-privileged users (from 1 to 8).
Tue, Mar 12, 7:18 PM · Anti-Harassment (Vav — ו), Patch-For-Review, MediaWiki-User-login-and-signup
dmaza moved T216845: Account creation checkbox inappropriately checked at Special:Block/<Username> from In progress to Review on the Anti-Harassment (He — ה) board.
Tue, Mar 12, 7:08 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Anti-Harassment (Vav — ו), MediaWiki-User-management

Fri, Mar 8

dmaza moved T216845: Account creation checkbox inappropriately checked at Special:Block/<Username> from Ready to In progress on the Anti-Harassment (He — ה) board.
Fri, Mar 8, 2:13 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Anti-Harassment (Vav — ו), MediaWiki-User-management
dmaza claimed T216845: Account creation checkbox inappropriately checked at Special:Block/<Username>.
Fri, Mar 8, 2:13 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Anti-Harassment (Vav — ו), MediaWiki-User-management
dmaza moved T216845: Account creation checkbox inappropriately checked at Special:Block/<Username> from Cards ready for development to He — ה on the Anti-Harassment board.
Fri, Mar 8, 2:13 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Anti-Harassment (Vav — ו), MediaWiki-User-management

Feb 21 2019

dmaza moved T208510: "Prevent account creation" should be unchecked when the block is configured to be Partial. from Review to QA/Testing on the Anti-Harassment (Dalet — ד) board.
Feb 21 2019, 9:20 PM · Anti-Harassment (Vav — ו), MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, MediaWiki-User-management

Feb 14 2019

dmaza created T216196: Changes on {f15ecc6} might cause a fatal exception when trying to update the password through `Special:ChangeCredentials`.
Feb 14 2019, 10:32 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), MediaWiki-Authentication-and-authorization, MediaWiki-User-management

Feb 12 2019

dmaza added a comment to T211621: The 'your password is weak' message should display on log in for privileged accounts only.

That means if there is a failed skipLogin check and a failed normal check, both error messages will show, even though the skipLogin one would not show on its own

This is why I said that the same approach as forceChange can't be used. It was my understanding that the warning shouldn't be shown when other policies fail. If this is an accepted behavior then I agree with you that it should work just fine like you described in your last comment.

Feb 12 2019, 7:40 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Anti-Harassment (Vav — ו), Patch-For-Review, MediaWiki-User-login-and-signup
dmaza added a comment to T211621: The 'your password is weak' message should display on log in for privileged accounts only.

Probably should be handled the same way as rMWf15ecc60cd94: Add force option to password policy: add some password policy option like skipLogin, handle merging of different policy options / statuses in UserPasswordPolicy and put the result in a status flag, handle the flag in AbstractPasswordPrimaryAuthenticationProvider::setPasswordResetFlag.

Feb 12 2019, 4:20 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Anti-Harassment (Vav — ו), Patch-For-Review, MediaWiki-User-login-and-signup

Feb 6 2019

dmaza closed T210002: Oversighters should only be able to suppress a username for sitewide blocks (not partial blocks) via "Hide username from edits and lists" checkbox as Resolved.
Feb 6 2019, 3:04 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Anti-Harassment (Gimel — ג), Patch-For-Review, MediaWiki-User-management
dmaza moved T210002: Oversighters should only be able to suppress a username for sitewide blocks (not partial blocks) via "Hide username from edits and lists" checkbox from Review to Done on the Anti-Harassment (Gimel — ג) board.
Feb 6 2019, 3:04 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Anti-Harassment (Gimel — ג), Patch-For-Review, MediaWiki-User-management
dmaza moved T211621: The 'your password is weak' message should display on log in for privileged accounts only from Ready to In progress on the Anti-Harassment (Gimel — ג) board.
Feb 6 2019, 3:03 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Anti-Harassment (Vav — ו), Patch-For-Review, MediaWiki-User-login-and-signup

Feb 4 2019

dmaza added a comment to T215205: `ipb_sitewide` is not being updated for Autoblocks when the parent block changes restriction type (partial/sitewide).

Working on it right now. Will push fix in the next few mins

Feb 4 2019, 9:39 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Anti-Harassment (Bet — ב), Patch-For-Review, MediaWiki-User-management
dmaza created T215205: `ipb_sitewide` is not being updated for Autoblocks when the parent block changes restriction type (partial/sitewide).
Feb 4 2019, 9:31 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Anti-Harassment (Bet — ב), Patch-For-Review, MediaWiki-User-management

Feb 1 2019

dmaza closed T204985: Update block logs with namespace block details as Resolved.
Feb 1 2019, 7:24 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Anti-Harassment (Bet — ב), Patch-For-Review, MediaWiki-User-management
dmaza closed T204985: Update block logs with namespace block details, a subtask of T179110: 👩‍👧 Implement namespace blocking support, as Resolved.
Feb 1 2019, 7:24 PM · Anti-Harassment (Bet — ב), MediaWiki-User-management
dmaza moved T204985: Update block logs with namespace block details from Review to Done on the Anti-Harassment (Bet — ב) board.
Feb 1 2019, 7:23 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Anti-Harassment (Bet — ב), Patch-For-Review, MediaWiki-User-management

Jan 25 2019

dmaza moved T204985: Update block logs with namespace block details from In progress to Review on the Anti-Harassment (Bet — ב) board.
Jan 25 2019, 5:30 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Anti-Harassment (Bet — ב), Patch-For-Review, MediaWiki-User-management

Jan 21 2019

dmaza added a comment to T214215: MinimumPasswordLengthToLogin error message is unhelpful.

We shouldn't be enforcing anything just yet as https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/479570/ isn't publicised/deployed yet

Also it's going to force password change, not reset. (Same as the current nag screen except there won't be a Skip button.)

Yeah the message could be improved (although gerrit 479570 as written now will remove this check entirely). Also it does not prevent non-fatal errors from being displayed, which results in the weird duplication (since MinimalPasswordLength also runs and has the same message). Not sure if that's worth the effort though.

Jan 21 2019, 3:02 PM · Patch-For-Review, MediaWiki-Authentication-and-authorization
dmaza added a comment to T214215: MinimumPasswordLengthToLogin error message is unhelpful.

I'm guessing this was your account in the "staff" global group?

If so, this is invalid and can be made public

Jan 21 2019, 2:24 PM · Patch-For-Review, MediaWiki-Authentication-and-authorization

Jan 18 2019

dmaza updated the task description for T214215: MinimumPasswordLengthToLogin error message is unhelpful.
Jan 18 2019, 11:36 PM · Patch-For-Review, MediaWiki-Authentication-and-authorization
dmaza created T214215: MinimumPasswordLengthToLogin error message is unhelpful.
Jan 18 2019, 11:28 PM · Patch-For-Review, MediaWiki-Authentication-and-authorization

Jan 16 2019

dmaza closed T213952: Special:BlockList displays "editing" as part of block params for non-editing blocks as Resolved.
Jan 16 2019, 7:08 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Anti-Harassment (Alef — א), Patch-For-Review
dmaza moved T213952: Special:BlockList displays "editing" as part of block params for non-editing blocks from Review to Done on the Anti-Harassment (Alef — א) board.
Jan 16 2019, 7:08 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Anti-Harassment (Alef — א), Patch-For-Review
dmaza claimed T213952: Special:BlockList displays "editing" as part of block params for non-editing blocks.
Jan 16 2019, 6:26 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Anti-Harassment (Alef — א), Patch-For-Review
dmaza created T213952: Special:BlockList displays "editing" as part of block params for non-editing blocks.
Jan 16 2019, 6:15 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Anti-Harassment (Alef — א), Patch-For-Review

Jan 15 2019

dmaza created T213837: Creating a Partial Block with page restrictions through the API allows for non-existing Titles resulting in ipblocks_restrictions.ir_value = 0.
Jan 15 2019, 4:20 PM · MediaWiki-User-management

Dec 21 2018

dmaza moved T208523: Blocks log entries display as malformed on Special:CheckUser from In progress to Review on the Anti-Harassment (AHT Sprint 35) board.
Dec 21 2018, 9:00 PM · MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), Anti-Harassment (Alef — א), Patch-For-Review, CheckUser, MediaWiki-User-management
dmaza renamed T208523: Blocks log entries display as malformed on Special:CheckUser from Partial blocks log entries display as malformed on Special:CheckUser to Blocks log entries display as malformed on Special:CheckUser.
Dec 21 2018, 8:59 PM · MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), Anti-Harassment (Alef — א), Patch-For-Review, CheckUser, MediaWiki-User-management

Dec 20 2018

dmaza renamed T212391: Special:Block options should be enable/disable, and not hide/show from Special:Block prevent account creation should be disabled if the target is a username to Special:Block option "Automatically block the last IP..." should be disabled and not hidden when applies.
Dec 20 2018, 4:46 AM · MediaWiki-User-management, Anti-Harassment
dmaza added a comment to T212391: Special:Block options should be enable/disable, and not hide/show.

@JJMC89 Unless I'm missing something, you can't create an account if you are already signed in.

Yes, you can. (I do it all the time.)

Dec 20 2018, 4:45 AM · MediaWiki-User-management, Anti-Harassment
dmaza added a comment to T212391: Special:Block options should be enable/disable, and not hide/show.

@JJMC89 Unless I'm missing something, you can't create an account if you are already signed in.

Dec 20 2018, 4:30 AM · MediaWiki-User-management, Anti-Harassment
dmaza created T212392: Edit block and save without making changes should not display "XYZUser" is already blocked.".
Dec 20 2018, 4:01 AM · MediaWiki-User-management
dmaza created T212391: Special:Block options should be enable/disable, and not hide/show.
Dec 20 2018, 3:53 AM · MediaWiki-User-management, Anti-Harassment

Dec 17 2018

dmaza added a comment to T191922: Enable $wgCookieSetOnIpBlock by default after the IP cookie block feature is fully tested and released.

Let's do it.

Uh, right. Who is doing it?

Dec 17 2018, 5:53 PM · MW-1.33-release, MediaWiki-User-management, MediaWiki-Configuration

Dec 14 2018

dmaza moved T208523: Blocks log entries display as malformed on Special:CheckUser from Ready to In progress on the Anti-Harassment (AHT Sprint 35) board.
Dec 14 2018, 3:22 AM · MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), Anti-Harassment (Alef — א), Patch-For-Review, CheckUser, MediaWiki-User-management
dmaza claimed T208523: Blocks log entries display as malformed on Special:CheckUser.
Dec 14 2018, 3:22 AM · MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), Anti-Harassment (Alef — א), Patch-For-Review, CheckUser, MediaWiki-User-management

Dec 13 2018

dmaza closed T211234: Set wgEnableBlockNoticeStats to true on 19 more wikis as Resolved.
Dec 13 2018, 8:17 PM · Wikimedia-Site-requests, Anti-Harassment (AHT Sprint 35)
dmaza closed T211234: Set wgEnableBlockNoticeStats to true on 19 more wikis, a subtask of T189724: 👩‍👧 Track how often blocked users attempt to edit, as Resolved.
Dec 13 2018, 8:17 PM · Anti-Harassment (AHT Sprint 35), Analytics
dmaza moved T211234: Set wgEnableBlockNoticeStats to true on 19 more wikis from Review to Done on the Anti-Harassment (AHT Sprint 35) board.
Dec 13 2018, 8:16 PM · Wikimedia-Site-requests, Anti-Harassment (AHT Sprint 35)
dbarratt awarded T211276: mAllowUsertalk property on User.php is not being used and should be removed a Like token.
Dec 13 2018, 6:32 PM · MediaWiki-User-management
dmaza moved T204988: Add tests for NamespaceRestriction enforcement from Ready to Review on the Anti-Harassment (AHT Sprint 35) board.
Dec 13 2018, 4:46 AM · Anti-Harassment (Bet — ב), Patch-For-Review, MediaWiki-User-management
dmaza moved T211234: Set wgEnableBlockNoticeStats to true on 19 more wikis from In progress to Review on the Anti-Harassment (AHT Sprint 35) board.
Dec 13 2018, 12:38 AM · Wikimedia-Site-requests, Anti-Harassment (AHT Sprint 35)
dmaza moved T211234: Set wgEnableBlockNoticeStats to true on 19 more wikis from Ready to In progress on the Anti-Harassment (AHT Sprint 35) board.
Dec 13 2018, 12:18 AM · Wikimedia-Site-requests, Anti-Harassment (AHT Sprint 35)
dmaza claimed T211234: Set wgEnableBlockNoticeStats to true on 19 more wikis.
Dec 13 2018, 12:18 AM · Wikimedia-Site-requests, Anti-Harassment (AHT Sprint 35)

Dec 11 2018

dmaza moved T208271: Clean up Expiry field on Special:Block on Mobile from Review to Done on the Anti-Harassment (AHT Sprint 35) board.
Dec 11 2018, 8:53 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Anti-Harassment (AHT Sprint 35), Patch-For-Review, MediaWiki-User-management
dmaza changed the status of T210444: SWAT deploy PartialBlocks on Italian Wikipedia — Jan 16, 2019 from Open to Stalled.
Dec 11 2018, 8:52 PM · Wikimedia-Site-requests, Anti-Harassment (Alef — א), Patch-For-Review
dmaza closed T210475: User should not be allowed to edit user talk page if checkbox is enabled (partial blocks) as Resolved.
Dec 11 2018, 8:52 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Anti-Harassment (AHT Sprint 35), Patch-For-Review
dmaza moved T210475: User should not be allowed to edit user talk page if checkbox is enabled (partial blocks) from Review to Done on the Anti-Harassment (AHT Sprint 35) board.
Dec 11 2018, 8:51 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Anti-Harassment (AHT Sprint 35), Patch-For-Review
dmaza moved T208246: Change password length requirement and ensure enforcement for privileged users (from 8 to 10) from In progress to Review on the Anti-Harassment (AHT Sprint 35) board.
Dec 11 2018, 8:51 PM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Anti-Harassment (AHT Sprint 35), MediaWiki-User-login-and-signup

Dec 10 2018

dmaza edited P7902 pw stack trace.
Dec 10 2018, 6:31 PM
dmaza created P7902 pw stack trace.
Dec 10 2018, 6:29 PM

Dec 6 2018

dmaza claimed T208246: Change password length requirement and ensure enforcement for privileged users (from 8 to 10).
Dec 6 2018, 5:54 PM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Anti-Harassment (AHT Sprint 35), MediaWiki-User-login-and-signup
dmaza moved T208246: Change password length requirement and ensure enforcement for privileged users (from 8 to 10) from Ready to In progress on the Anti-Harassment (AHT Sprint 35) board.
Dec 6 2018, 5:53 PM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Anti-Harassment (AHT Sprint 35), MediaWiki-User-login-and-signup
dmaza moved T210475: User should not be allowed to edit user talk page if checkbox is enabled (partial blocks) from In progress to Review on the Anti-Harassment (AHT Sprint 35) board.
Dec 6 2018, 5:53 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Anti-Harassment (AHT Sprint 35), Patch-For-Review
dmaza added a comment to T211276: mAllowUsertalk property on User.php is not being used and should be removed.

FYI: The value is passed to the UserIsBlockedFrom hook, where MediaWiki-extensions-LiquidThreads tries to make use of it.

Right. And UserIsBlockedFrom signature will need to change for this. LiquidThreads can be fix accordingly.

Dec 6 2018, 5:43 PM · MediaWiki-User-management
dmaza created T211276: mAllowUsertalk property on User.php is not being used and should be removed.
Dec 6 2018, 6:17 AM · MediaWiki-User-management
dmaza moved T210080: Display pending element while the TitlesMultiselectWidget loads from Review to Done on the Anti-Harassment (AHT Sprint 35) board.
Dec 6 2018, 12:33 AM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Anti-Harassment (AHT Sprint 35), Patch-For-Review

Dec 5 2018

dmaza updated the task description for T209097: FormSpecialPage::checkExecutePermissions should only block a FormSpecialPage if the user is sitewide blocked.
Dec 5 2018, 11:26 PM · Anti-Harassment (Vav — ו), MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Patch-For-Review, MediaWiki-User-management
dmaza moved T203171: Do not display "this user is blocked" messages on user & user_talk pages for partial blocks from In progress to Review on the Anti-Harassment (AHT Sprint 34) board.
Dec 5 2018, 8:02 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Anti-Harassment (AHT Sprint 35), Patch-For-Review, MediaWiki-User-management
dmaza moved T210444: SWAT deploy PartialBlocks on Italian Wikipedia — Jan 16, 2019 from Done to Review on the Anti-Harassment (AHT Sprint 34) board.
Dec 5 2018, 8:01 PM · Wikimedia-Site-requests, Anti-Harassment (Alef — א), Patch-For-Review
dmaza moved T210444: SWAT deploy PartialBlocks on Italian Wikipedia — Jan 16, 2019 from Review to Done on the Anti-Harassment (AHT Sprint 34) board.
Dec 5 2018, 8:01 PM · Wikimedia-Site-requests, Anti-Harassment (Alef — א), Patch-For-Review
dmaza closed T201717: Tracking blocks: Log hard edits that fail via API or page rejection as Resolved.
Dec 5 2018, 8:01 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Anti-Harassment (AHT Sprint 34), Patch-For-Review
dmaza closed T201717: Tracking blocks: Log hard edits that fail via API or page rejection, a subtask of T189724: 👩‍👧 Track how often blocked users attempt to edit, as Resolved.
Dec 5 2018, 8:00 PM · Anti-Harassment (AHT Sprint 35), Analytics
dmaza added a comment to T210475: User should not be allowed to edit user talk page if checkbox is enabled (partial blocks).

If there is a partial block for an ip range, the same rules will apply. It will all work the same as what's described in the acceptance criteria (Unless I'm missing something) . The Target of the block makes no difference for this. The moving parts are the block type (sitewide|partial), the "Prevent ..." checkbox, and the restrictions (for now only pages).

Dec 5 2018, 6:11 AM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Anti-Harassment (AHT Sprint 35), Patch-For-Review
dmaza updated the task description for T203171: Do not display "this user is blocked" messages on user & user_talk pages for partial blocks.
Dec 5 2018, 5:48 AM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Anti-Harassment (AHT Sprint 35), Patch-For-Review, MediaWiki-User-management

Dec 4 2018

dmaza created T211073: Change "Prevent this user from editing his own talk page while blocked" behavior when namespace blocking is implemented.
Dec 4 2018, 12:55 AM · Anti-Harassment

Dec 3 2018

dmaza added a comment to T210953: Wikidata is editable for blocked users.

Is it safe to assume that we only need to check on those 4 extensions ( CirrusSearch, WikibaseQualityConstraints, Wikibase, EducationProgram ) ?
I still think that @Addshore's patch should be merged regardless.

Dec 3 2018, 3:44 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Anti-Harassment (AHT Sprint 34), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, Wikidata, Security
dmaza added a comment to T210953: Wikidata is editable for blocked users.

@Addshore @Legoktm are we ready to move forward with the patch on wikibase? What do we need to get https://gerrit.wikimedia.org/r/c/mediawiki/core/+/471993 (or a version of it) back on wmf.6?

Dec 3 2018, 2:29 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Anti-Harassment (AHT Sprint 34), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, Wikidata, Security

Dec 1 2018

dmaza claimed T210475: User should not be allowed to edit user talk page if checkbox is enabled (partial blocks).
Dec 1 2018, 12:17 AM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Anti-Harassment (AHT Sprint 35), Patch-For-Review
dmaza moved T210475: User should not be allowed to edit user talk page if checkbox is enabled (partial blocks) from Done to In progress on the Anti-Harassment (AHT Sprint 34) board.
Dec 1 2018, 12:17 AM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Anti-Harassment (AHT Sprint 35), Patch-For-Review
dmaza added a comment to T210475: User should not be allowed to edit user talk page if checkbox is enabled (partial blocks).
  • The "Prevent [...] own talk page" checkbox should only be active if the block is configured to sitewide OR if the admin has configured ?the Partial Block to include the User_talk: namespace
  • The Page and Namespace inputs should not change (i.e. allow for the block target's talk page and/or the entire User_talk: namespace)
Dec 1 2018, 12:16 AM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Anti-Harassment (AHT Sprint 35), Patch-For-Review

Nov 30 2018

dmaza updated subscribers of T210475: User should not be allowed to edit user talk page if checkbox is enabled (partial blocks).

You removed this TODO, but didn't really address the question. If a namespace block covers NS_USER_TALK, IMO that probably should not override $block->prevents( 'editownusertalk' ) === false.

This patch does exactly the opposite: if a block covers anything *except* the user's talk page, you're making $block->prevents( 'editownusertalk' ) === true also prevent talk page access. Which to me also seems like the wrong thing to do.


Perhaps I should explain my reasoning a bit more.

A sitewide block blocks the user from everything. The checkbox labeled "Prevent this user from editing their own talk page while blocked" really serves to exempt the user's talk page from that when the checkbox is unchecked, to allow the user an avenue of appeal.

For partial blocks from the whole user talk namespace, I'd expect it to work the same way: To allow appeal the user can still edit their own talk page unless the blocking admin specifically took that away by checking the box. But you've implemented the opposite here.

If the partial block doesn't cover the user talk namespace (e.g. a block from a single article), IMO it doesn't make sense to even have the "Prevent this user from editing their own talk page while blocked" checkbox shown. Even if it is shown, I can't think of any situation where I as a blocking admin would want to check the box for such a block and have it take effect.

If we had category blocks, again I'd expect the user to be able to edit their own talk page for appeals even if their talk page happens to have a blocked category on it.

The only case I can think of where I as a blocking admin actually *would* want the block to ignore "Prevent this user from editing their own talk page while blocked" being unchecked is if it's a specific-page block for the user's talk page. Because in that case it's clear I really am trying to stop the user from editing their talk page.

OTOH, I can't think of any case where I'd use a partial block for removing a user's own talk page access, since if they're misbehaving enough to lose access to their own talk page there's probably no reason not to block them sitewide. So maybe the thing to do would be to hide "Prevent this user from editing their own talk page while blocked" checkbox entirely (forcing it to false) when creating a partial block?

Does that make sense to you?

Nov 30 2018, 5:40 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Anti-Harassment (AHT Sprint 35), Patch-For-Review
dmaza moved T210444: SWAT deploy PartialBlocks on Italian Wikipedia — Jan 16, 2019 from In progress to Review on the Anti-Harassment (AHT Sprint 34) board.
Nov 30 2018, 4:13 PM · Wikimedia-Site-requests, Anti-Harassment (Alef — א), Patch-For-Review
dmaza claimed T210444: SWAT deploy PartialBlocks on Italian Wikipedia — Jan 16, 2019.
Nov 30 2018, 4:07 PM · Wikimedia-Site-requests, Anti-Harassment (Alef — א), Patch-For-Review
dmaza moved T210444: SWAT deploy PartialBlocks on Italian Wikipedia — Jan 16, 2019 from Ready to In progress on the Anti-Harassment (AHT Sprint 34) board.
Nov 30 2018, 4:07 PM · Wikimedia-Site-requests, Anti-Harassment (Alef — א), Patch-For-Review
dmaza moved T210452: Enable block notice stats on itwiki from In progress to Review on the Anti-Harassment (AHT Sprint 34) board.
Nov 30 2018, 4:07 PM · Patch-For-Review, Anti-Harassment (AHT Sprint 34)
dmaza moved T210452: Enable block notice stats on itwiki from Ready to In progress on the Anti-Harassment (AHT Sprint 34) board.
Nov 30 2018, 3:37 PM · Patch-For-Review, Anti-Harassment (AHT Sprint 34)
dmaza claimed T210452: Enable block notice stats on itwiki.
Nov 30 2018, 3:37 PM · Patch-For-Review, Anti-Harassment (AHT Sprint 34)