Page MenuHomePhabricator

dmaza (Dayllan Maza)
Software Engineer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jul 10 2017, 7:20 PM (157 w, 2 d)
Availability
Available
IRC Nick
DMaza
LDAP User
Dmaza
MediaWiki User
DMaza (WMF) [ Global Accounts ]

Recent Activity

Tue, Jul 14

dmaza added a comment to T248514: Watchlist Expiry: Add watchlist expiry support to Edit API [medium].

Yup. I did forget to reference this task in the patch. I've got another patchset coming shortly and will fix that.

Tue, Jul 14, 2:44 AM · Community-Tech (Kanban-2020-21-Q1), MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), archived--TCB-Team, MediaWiki-API, Expiring-Watchlist-Items

Mon, Jul 13

dmaza added a comment to T248514: Watchlist Expiry: Add watchlist expiry support to Edit API [medium].

@MusikAnimal isn't this included as part of the work on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/602486 ?

Mon, Jul 13, 9:40 PM · Community-Tech (Kanban-2020-21-Q1), MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), archived--TCB-Team, MediaWiki-API, Expiring-Watchlist-Items
dmaza added a comment to T252812: Investigate watchlist sizes (limiting or handling large ones properly).

@Marostegui Thank you so much for your reply. I'll try to answer your questions below

Mon, Jul 13, 7:37 PM · Core Platform Team Workboards (Clinic Duty Team), Community-Tech (Kanban-2020-21-Q1), Expiring-Watchlist-Items

Wed, Jul 8

dmaza created T257506: Watchlist Expiry: Enable feature on testwiki [small].
Wed, Jul 8, 7:08 PM · Community-Tech (Kanban-2020-21-Q1), Expiring-Watchlist-Items
dmaza created T257396: Sort out state of Watchlist Expiry for 1.35.0.
Wed, Jul 8, 3:29 AM · Community-Tech, Expiring-Watchlist-Items, MW-1.35-release

Tue, Jul 7

dmaza placed T251690: Watchlist Expiry: Add star icon UI to mobile [medium] up for grabs.
Tue, Jul 7, 10:00 PM · Community-Tech (Kanban-2020-21-Q1), archived--TCB-Team, Expiring-Watchlist-Items
dmaza moved T251690: Watchlist Expiry: Add star icon UI to mobile [medium] from In Development to Ready on the Community-Tech (Kanban-2019-20-Q4) board.
Tue, Jul 7, 10:00 PM · Community-Tech (Kanban-2020-21-Q1), archived--TCB-Team, Expiring-Watchlist-Items

Mon, Jul 6

dmaza moved T251690: Watchlist Expiry: Add star icon UI to mobile [medium] from Ready to In Development on the Community-Tech (Kanban-2019-20-Q4) board.
Mon, Jul 6, 7:52 PM · Community-Tech (Kanban-2020-21-Q1), archived--TCB-Team, Expiring-Watchlist-Items
dmaza claimed T251690: Watchlist Expiry: Add star icon UI to mobile [medium].
Mon, Jul 6, 7:52 PM · Community-Tech (Kanban-2020-21-Q1), archived--TCB-Team, Expiring-Watchlist-Items

Tue, Jun 30

dmaza added a member for Community-Tech: dmaza.
Tue, Jun 30, 11:03 PM
dmaza added a watcher for Community-Tech: dmaza.
Tue, Jun 30, 10:58 PM
dmaza removed a watcher for Anti-Harassment: dmaza.
Tue, Jun 30, 10:26 PM

Wed, Jun 24

dmaza moved T255644: CU 2.0: Implement a GuidedTour for Special:Investigate onboarding from In Progress to Ready on the Anti-Harassment (The Letter Song) board.
Wed, Jun 24, 8:54 PM · Patch-For-Review, Design, Anti-Harassment (The Letter Song), CheckUser
dmaza placed T255644: CU 2.0: Implement a GuidedTour for Special:Investigate onboarding up for grabs.
Wed, Jun 24, 8:54 PM · Patch-For-Review, Design, Anti-Harassment (The Letter Song), CheckUser

Tue, Jun 23

dmaza moved T255644: CU 2.0: Implement a GuidedTour for Special:Investigate onboarding from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
Tue, Jun 23, 12:22 PM · Patch-For-Review, Design, Anti-Harassment (The Letter Song), CheckUser
dmaza claimed T255644: CU 2.0: Implement a GuidedTour for Special:Investigate onboarding.
Tue, Jun 23, 12:21 PM · Patch-For-Review, Design, Anti-Harassment (The Letter Song), CheckUser

Jun 15 2020

dmaza added a comment to T253823: Special:Investigate: Update tab's label text.

Oh, another thing I noticed: while on one of the tabs, if I change the interface language (e.g. via uselang URL param or Special:Preferences) and refresh I am taken to a blank page (no data, just the 3 tabs). This appears to be because the URL is still in whatever my language was before I changed it, but now it expects it to be in the language I just changed to.

I don't know if this will be a problem in reality. Do CheckUser need to change their interface languages mid-investigation for any reason?

Jun 15 2020, 5:21 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), Anti-Harassment (The Letter Song), CheckUser
dmaza added a comment to T253823: Special:Investigate: Update tab's label text.

Or we could just do [0|1|2] for the tabs like Gmail does for the different accounts. It is very unlikely that someone will "type" the URL to the subpage 'cause the token is needed.

Jun 15 2020, 3:07 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), Anti-Harassment (The Letter Song), CheckUser

Jun 12 2020

dmaza moved T254314: Investigate GuidedTour usage for Special:Investigate [4Hours] from In Progress to Done: Q4 (2019-20) on the Anti-Harassment (The Letter Song) board.
Jun 12 2020, 7:37 PM · Anti-Harassment (The Letter Song), CheckUser

Jun 11 2020

dmaza moved T252636: Call CompareService::getTotalEditsFromIp for each IP instead of each row from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
Jun 11 2020, 4:07 AM · MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), Anti-Harassment (The Letter Song), CheckUser
dmaza claimed T252636: Call CompareService::getTotalEditsFromIp for each IP instead of each row.
Jun 11 2020, 4:07 AM · MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), Anti-Harassment (The Letter Song), CheckUser
dmaza moved T252636: Call CompareService::getTotalEditsFromIp for each IP instead of each row from Cards ready for development to The Letter Song on the Anti-Harassment board.
Jun 11 2020, 4:07 AM · MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), Anti-Harassment (The Letter Song), CheckUser

Jun 10 2020

dmaza added a comment to T254314: Investigate GuidedTour usage for Special:Investigate [4Hours].

Short answer is Yes, this is what GuidedTour is for.

Jun 10 2020, 9:09 PM · Anti-Harassment (The Letter Song), CheckUser

Jun 9 2020

dbarratt awarded T254898: Organize CheckUser src files into subdirectories a Love token.
Jun 9 2020, 3:35 PM · Technical-Debt, Anti-Harassment, CheckUser
dmaza created T254898: Organize CheckUser src files into subdirectories.
Jun 9 2020, 3:25 PM · Technical-Debt, Anti-Harassment, CheckUser

Jun 8 2020

dmaza moved T46657: Change of IP block settings produces duplicate block from Review to Done: Q4 (2019-20) on the Anti-Harassment (The Letter Song) board.
Jun 8 2020, 6:06 PM · Anti-Harassment (The Letter Song), MediaWiki-Blocks
dmaza added a comment to T249239: CU 2.0: Add option to add IP ranges to search.

Some changes coming up on this task. We've changed the interface quite a bit here, and I am not sure if a nested menu would make things too complicated.

Add dropdown for
Include /16 range and Include /24 range for IPv4 IPs
Include /32 range and Include /64 range for IPv6 IPs

Based on the usability tests we now want a more fine-grained control here. @Niharika, what is the range we want to provide here? 1 to 24 for IPv4, and 1 to 64 for IPv6?

Jun 8 2020, 4:06 PM · Design, CheckUser, Anti-Harassment
dmaza moved T254314: Investigate GuidedTour usage for Special:Investigate [4Hours] from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
Jun 8 2020, 3:47 AM · Anti-Harassment (The Letter Song), CheckUser
dmaza claimed T254314: Investigate GuidedTour usage for Special:Investigate [4Hours].
Jun 8 2020, 3:47 AM · Anti-Harassment (The Letter Song), CheckUser
dmaza changed the status of T251188: ipb_address_unique has an extra column in production but not in the code from Stalled to Open.

Updating status to Open now that https://gerrit.wikimedia.org/r/594292 is merged

Jun 8 2020, 3:28 AM · MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), Anti-Harassment (The Letter Song), Blocked-on-schema-change, DBA
dmaza moved T237300: CU 2.0: Sorting in the Compare tab from In Progress to QA/Testing on the Anti-Harassment (The Letter Song) board.
Jun 8 2020, 3:22 AM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), Anti-Harassment (The Letter Song), CheckUser
dmaza reassigned T237300: CU 2.0: Sorting in the Compare tab from dmaza to Tchanders.
Jun 8 2020, 3:22 AM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), Anti-Harassment (The Letter Song), CheckUser

Jun 4 2020

dmaza moved T237300: CU 2.0: Sorting in the Compare tab from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
Jun 4 2020, 3:39 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), Anti-Harassment (The Letter Song), CheckUser
dmaza claimed T237300: CU 2.0: Sorting in the Compare tab.
Jun 4 2020, 3:39 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), Anti-Harassment (The Letter Song), CheckUser
dmaza moved T237300: CU 2.0: Sorting in the Compare tab from Cards ready for development to The Letter Song on the Anti-Harassment board.
Jun 4 2020, 3:38 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), Anti-Harassment (The Letter Song), CheckUser
dmaza added a comment to T254424: Special:Investigate: Add a way to unpin a highlight when the highlighted rows aren't on the page.

Technically we could allow for a “re-pin” if no highlights are present in the current page although it might confuse the user thinking that it does not persist across pages.

Jun 4 2020, 1:51 PM · Design, CheckUser, Anti-Harassment
dmaza moved T252983: Special:Investigate - Compare - Switch order of Pin and Ellipsis icon on table cell [4Hours] from In Progress to Review on the Anti-Harassment (The Letter Song) board.
Jun 4 2020, 3:19 AM · MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), Anti-Harassment (The Letter Song), CheckUser

Jun 3 2020

dmaza moved T254312: Default to Compare tab instead of Preliminary check from In Progress to Review on the Anti-Harassment (The Letter Song) board.
Jun 3 2020, 8:56 PM · MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), Anti-Harassment (The Letter Song), CheckUser
dmaza moved T252983: Special:Investigate - Compare - Switch order of Pin and Ellipsis icon on table cell [4Hours] from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
Jun 3 2020, 8:56 PM · MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), Anti-Harassment (The Letter Song), CheckUser
dmaza moved T254312: Default to Compare tab instead of Preliminary check from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
Jun 3 2020, 8:46 PM · MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), Anti-Harassment (The Letter Song), CheckUser

May 19 2020

dmaza claimed T251361: CU 2.0: Implement an option to allow users to copy the wikitext of the results table to their clipboard .
May 19 2020, 3:40 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Patch-For-Review, Anti-Harassment (The Letter Song), CheckUser
dmaza moved T251361: CU 2.0: Implement an option to allow users to copy the wikitext of the results table to their clipboard from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
May 19 2020, 3:40 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Patch-For-Review, Anti-Harassment (The Letter Song), CheckUser

May 18 2020

dmaza moved T251361: CU 2.0: Implement an option to allow users to copy the wikitext of the results table to their clipboard from In Progress to Ready on the Anti-Harassment (The Letter Song) board.
May 18 2020, 3:08 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Patch-For-Review, Anti-Harassment (The Letter Song), CheckUser
dmaza placed T251361: CU 2.0: Implement an option to allow users to copy the wikitext of the results table to their clipboard up for grabs.
May 18 2020, 3:05 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Patch-For-Review, Anti-Harassment (The Letter Song), CheckUser

May 14 2020

dmaza added a comment to T252033: Have user links follow the same behavior as in SpecialCheckUser.

@Prtksxna


The 2 and 3rd entries on may 13th is a user creation from an IP (unauthenticatd) and from a logged in user.

May 14 2020, 3:52 PM · Anti-Harassment (The Letter Song), CheckUser
dmaza added a comment to T252033: Have user links follow the same behavior as in SpecialCheckUser.

This behaviour makes sense too. Are you aware of any precedent to not show the contribs link at all when there are no contributions?

I'm not aware of anywhere that does this. The links are handled by Linker::userToolLinks, which we're calling with $redContribsWhenNoEdits = true.

If we did want to remove the contribs link, we should be able to do so using css, using the classes mw-usertoollinks-contribs and new. I'm not sure whether we should do that if it's not done anywhere else... Absence of a link might be interpreted as a bug by users who are used to seeing a red link?

May 14 2020, 3:48 PM · Anti-Harassment (The Letter Song), CheckUser
dmaza claimed T251361: CU 2.0: Implement an option to allow users to copy the wikitext of the results table to their clipboard .
May 14 2020, 3:41 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Patch-For-Review, Anti-Harassment (The Letter Song), CheckUser
dmaza moved T251361: CU 2.0: Implement an option to allow users to copy the wikitext of the results table to their clipboard from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
May 14 2020, 3:41 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Patch-For-Review, Anti-Harassment (The Letter Song), CheckUser

May 13 2020

dmaza added a comment to T252033: Have user links follow the same behavior as in SpecialCheckUser.

@Tchanders I'm a bit confused. Are you saying that the implementation before the patch on this task works better? if that's the case I do not disagree. This patch only exists to match current functionality of Special:CheckUser

May 13 2020, 3:06 PM · Anti-Harassment (The Letter Song), CheckUser

May 7 2020

dmaza moved T247641: CU 2.0: Add variant display to the Timeline result list from In Progress to Review on the Anti-Harassment (The Letter Song) board.
May 7 2020, 8:48 PM · Patch-For-Review, Anti-Harassment (The Letter Song), CheckUser
dmaza claimed T252033: Have user links follow the same behavior as in SpecialCheckUser.
May 7 2020, 8:48 PM · Anti-Harassment (The Letter Song), CheckUser
dmaza moved T252033: Have user links follow the same behavior as in SpecialCheckUser from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
May 7 2020, 8:47 PM · Anti-Harassment (The Letter Song), CheckUser

May 6 2020

dmaza created T252033: Have user links follow the same behavior as in SpecialCheckUser.
May 6 2020, 3:52 PM · Anti-Harassment (The Letter Song), CheckUser
dmaza created T252031: Make TimelineRowFormatter::getLinks do the same checks as it is currently done in SpecialCheckUser.
May 6 2020, 3:47 PM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Patch-For-Review, Anti-Harassment (The Letter Song), CheckUser
dmaza created T252030: Display comments after checking that the user has the right permissions if the revision was suppressed.
May 6 2020, 3:42 PM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Anti-Harassment (The Letter Song), CheckUser

May 4 2020

dmaza added a comment to T251188: ipb_address_unique has an extra column in production but not in the code.

Extra info: Seems to have been added back in 2009 git show 4124558d7b4 maintenance/tables.sql.

May 4 2020, 3:39 PM · MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), Anti-Harassment (The Letter Song), Blocked-on-schema-change, DBA
dmaza updated subscribers of T251188: ipb_address_unique has an extra column in production but not in the code.

Disregard my last comment. I was still organizing my thoughts and pressed submit by mistake.

May 4 2020, 3:17 PM · MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), Anti-Harassment (The Letter Song), Blocked-on-schema-change, DBA
dmaza added a comment to T251188: ipb_address_unique has an extra column in production but not in the code.
May 4 2020, 3:06 PM · MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), Anti-Harassment (The Letter Song), Blocked-on-schema-change, DBA

Apr 29 2020

dmaza added a comment to T250446: CheckUser internal API error.

Adding in Anti-Harassment folks to see if this is at all related to recent refactoring work on CheckUser.

Apr 29 2020, 8:56 PM · MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), Anti-Harassment (The Letter Song), Regression, Wikimedia-production-error, CheckUser
dmaza created T251465: Investigate how to handle SpecialCheckUserGetLinksFromRow on SpecialInvestigate.
Apr 29 2020, 8:40 PM · MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), Anti-Harassment (The Letter Song), CheckUser
dmaza created T251459: Add filters specific to the timeline tab.
Apr 29 2020, 8:17 PM · Anti-Harassment, CheckUser

Apr 27 2020

dmaza added a comment to T250427: Create #MediaWiki-Blocks component.

@DannyS712 @Aklapper, thank you for this!

Apr 27 2020, 2:13 PM · Anti-Harassment, User-DannyS712, Project-Admins

Apr 15 2020

dmaza claimed T247641: CU 2.0: Add variant display to the Timeline result list .
Apr 15 2020, 4:56 PM · Patch-For-Review, Anti-Harassment (The Letter Song), CheckUser
dmaza moved T247641: CU 2.0: Add variant display to the Timeline result list from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
Apr 15 2020, 4:54 PM · Patch-For-Review, Anti-Harassment (The Letter Song), CheckUser

Apr 6 2020

dmaza added a comment to T249059: Requesting access to analytics-privatedata-users for tchanders, dmaza, dbarratt, wikigit.

The test host would be the closest (same data and same HW specs as we have in production), however it will have just a one time snapshot, meaning that the data won't get updated, so you'd be testing always with the same data.

Apr 6 2020, 3:43 PM · Anti-Harassment, Operations, SRE-Access-Requests
dmaza added a comment to T249059: Requesting access to analytics-privatedata-users for tchanders, dmaza, dbarratt, wikigit.

What we can also do is use the "test" hosts (https://wikitech.wikimedia.org/wiki/MariaDB#Testing_servers) and load one big wiki, maybe enwiki and give some access there for some users so they can test queries against enwiki?
Would that work for query testing?

Apr 6 2020, 2:58 PM · Anti-Harassment, Operations, SRE-Access-Requests

Mar 31 2020

dmaza moved T248996: Decouple tokenized request data from InvestigatePager from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
Mar 31 2020, 3:12 PM · MW-1.35-notes (1.35.0-wmf.28; 2020-04-14), Anti-Harassment (The Letter Song), CheckUser
dmaza moved T248996: Decouple tokenized request data from InvestigatePager from Untriaged to The Letter Song on the Anti-Harassment board.
Mar 31 2020, 3:12 PM · MW-1.35-notes (1.35.0-wmf.28; 2020-04-14), Anti-Harassment (The Letter Song), CheckUser
dmaza added a project to T248996: Decouple tokenized request data from InvestigatePager: Anti-Harassment.
Mar 31 2020, 3:11 PM · MW-1.35-notes (1.35.0-wmf.28; 2020-04-14), Anti-Harassment (The Letter Song), CheckUser
dmaza created T248996: Decouple tokenized request data from InvestigatePager.
Mar 31 2020, 3:09 PM · MW-1.35-notes (1.35.0-wmf.28; 2020-04-14), Anti-Harassment (The Letter Song), CheckUser

Mar 26 2020

dmaza claimed T247640: CU 2.0: Add the timeline tab with a list of generic structured results [medium].
Mar 26 2020, 4:51 AM · MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), Anti-Harassment (The Letter Song), CheckUser
dmaza added a comment to T247639: CU 2.0: Create queries required for the Timeline tab [medium].

So to summarize what has been discussed. This task is only to generate the query that will be consumed by the pager. It does not involved any data massaging or any extra handled on the pager. That work will be done as part of T247640: CU 2.0: Add the timeline tab with a list of generic structured results [medium]
With that said, is it fair to say that the last 3 bullet points on the Acceptance Criteria can be removed since they'll be handled in T247640?

Mar 26 2020, 4:51 AM · MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), Anti-Harassment (The Letter Song), CheckUser

Mar 24 2020

dmaza added a comment to T247639: CU 2.0: Create queries required for the Timeline tab [medium].

Is this what we want here? No pagination and a sensible limit?

When we discussed T247640 in estimation we planned to make a pager, though it looks like this hasn't been documented in the task yet.

Mar 24 2020, 3:13 PM · MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), Anti-Harassment (The Letter Song), CheckUser

Mar 20 2020

dmaza added a comment to T247639: CU 2.0: Create queries required for the Timeline tab [medium].

Looking at the current "edits" option on CheckUser, there is no pagination and a limit of 5000 rows.

Mar 20 2020, 9:20 PM · MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), Anti-Harassment (The Letter Song), CheckUser
dmaza placed T184635: There is no way to associate blocks to the User data-model up for grabs.
Mar 20 2020, 3:50 PM · Addwiki

Mar 19 2020

dmaza claimed T247639: CU 2.0: Create queries required for the Timeline tab [medium].
Mar 19 2020, 2:12 PM · MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), Anti-Harassment (The Letter Song), CheckUser
dmaza moved T247639: CU 2.0: Create queries required for the Timeline tab [medium] from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
Mar 19 2020, 2:12 PM · MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), Anti-Harassment (The Letter Song), CheckUser

Mar 17 2020

dmaza moved T246496: CU 2.0: Add form sub-title to indicate who all are under investigation from In Progress to Review on the Anti-Harassment (The Letter Song) board.
Mar 17 2020, 6:50 PM · Anti-Harassment (The Letter Song), CheckUser
dmaza moved T247516: CU 2.0: Logging for Special:Investigate - Page links from In Progress to Review on the Anti-Harassment (The Letter Song) board.
Mar 17 2020, 6:49 PM · Patch-For-Review, Anti-Harassment (The Letter Song), CheckUser

Mar 16 2020

dmaza moved T246496: CU 2.0: Add form sub-title to indicate who all are under investigation from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
Mar 16 2020, 7:46 PM · Anti-Harassment (The Letter Song), CheckUser
dmaza claimed T246496: CU 2.0: Add form sub-title to indicate who all are under investigation.
Mar 16 2020, 7:46 PM · Anti-Harassment (The Letter Song), CheckUser

Mar 12 2020

dmaza moved T247024: CU 2.0: Logging for Special:Investigate - Displaying the data from Review to QA/Testing on the Anti-Harassment (The Letter Song) board.
Mar 12 2020, 6:08 PM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), Anti-Harassment (The Letter Song), CheckUser
dmaza moved T247516: CU 2.0: Logging for Special:Investigate - Page links from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
Mar 12 2020, 6:07 PM · Patch-For-Review, Anti-Harassment (The Letter Song), CheckUser
dmaza claimed T247516: CU 2.0: Logging for Special:Investigate - Page links.
Mar 12 2020, 6:07 PM · Patch-For-Review, Anti-Harassment (The Letter Song), CheckUser

Mar 6 2020

dmaza added a comment to T245662: CU 2.0: Logging for Special:Investigate - Adding the data.

@Niharika can we have a separate ticket for displaying the "Logs" button at the top right? Or maybe group it with the ticket for "new investigation"? I can't find that task if one already exists.

Mar 6 2020, 11:11 PM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), Patch-For-Review, Anti-Harassment (The Letter Song), CheckUser
dmaza moved T247024: CU 2.0: Logging for Special:Investigate - Displaying the data from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
Mar 6 2020, 5:04 AM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), Anti-Harassment (The Letter Song), CheckUser
dmaza claimed T247024: CU 2.0: Logging for Special:Investigate - Displaying the data.
Mar 6 2020, 5:04 AM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), Anti-Harassment (The Letter Song), CheckUser
dmaza claimed T246799: Make common abstract class for PreliminaryCheckPager and ComparePager.
Mar 6 2020, 4:19 AM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), Anti-Harassment (The Letter Song), CheckUser
dmaza moved T246799: Make common abstract class for PreliminaryCheckPager and ComparePager from In Progress to Review on the Anti-Harassment (The Letter Song) board.
Mar 6 2020, 4:19 AM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), Anti-Harassment (The Letter Song), CheckUser

Mar 5 2020

dmaza moved T246799: Make common abstract class for PreliminaryCheckPager and ComparePager from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
Mar 5 2020, 9:52 PM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), Anti-Harassment (The Letter Song), CheckUser

Mar 4 2020

dmaza moved T245181: Improve test coverage for Special:Investigate from In Progress to Review on the Anti-Harassment (The Letter Song) board.
Mar 4 2020, 9:42 PM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), Anti-Harassment (The Letter Song), CheckUser
dmaza added a comment to T246376: Mute: Don't allow muting yourself.

One thing to keep in mind is that there is nothing preventing yourself from adding your own username to the email or echo blacklists via Special:Preferences. That was one of the reasons why we didn't enforce this rule IIRC. I do not disagree with hiding the link when it applies tho.

Mar 4 2020, 6:42 PM · Patch-For-Review, MediaWiki-User-preferences, Anti-Harassment
dmaza added a comment to T244817: CU 2.0: Add button to add all other IPs being used by a user to an investigation.

Clicking the "Show all N IPs" button adds another IP target for each relevant IP, in addition to the currently-entered targets.

Mar 4 2020, 4:54 PM · MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), Anti-Harassment (The Letter Song), CheckUser
dmaza updated subscribers of T244817: CU 2.0: Add button to add all other IPs being used by a user to an investigation.

There is also the issue of adding the new target to the investigation. Considering that server requests are logged, we might have to either pre-generate a token with the new target (possibly expensive) or potentially do it via a POST request. The latter seems more reasonable and @dbarratt mentioned it is what he'll be doing with the filters.

Mar 4 2020, 4:48 PM · MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), Anti-Harassment (The Letter Song), CheckUser

Feb 26 2020

dmaza added a comment to T246053: Give access to Anti Harassment Tools team to production deployment.

Thanks @Dzahn . Here is mine

ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIMzAnzpZdT/jiyru+B+bUxA/r04r6kPBEl/aBQmuBlmU dmaza@wikimedia.org
Feb 26 2020, 9:17 PM · SRE-Access-Requests, Operations

Feb 25 2020

dmaza added a comment to T245181: Improve test coverage for Special:Investigate.

Couple questions:

  • Define: full coverage
  • How useful is it really to test a special page? What exactly is it expected to be covered here?
  • Same as above for pagers. Specially when most of the methods are calling a method in the service.
Feb 25 2020, 9:37 PM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), Anti-Harassment (The Letter Song), CheckUser
dmaza claimed T245181: Improve test coverage for Special:Investigate.
Feb 25 2020, 4:38 PM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), Anti-Harassment (The Letter Song), CheckUser
dmaza moved T245181: Improve test coverage for Special:Investigate from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
Feb 25 2020, 4:37 PM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), Anti-Harassment (The Letter Song), CheckUser
dmaza added a comment to T237299: CU 2.0: Sticky highlighting in Preliminary check and Compare tabs.

Why can't we do it using local storage?

This is a good question. It did cross my mind, but there are a few issues:

  • since local storage is shared across tabs, the highlighting would be the same across all open investigations (we could perhaps make a unique ID for each investigation, but we're wandering into the territory of making maintenance more difficult)
  • we'd need to be careful not to pollute the store (e.g. making sure we delete everything if the user closed the tab without removing the highlight)
  • window.sessionStorage would be an alternative, but this wouldn't be able to be deliberately persisted across tabs (e.g. if there were multiple pages open from the same investigation)
Feb 25 2020, 3:45 PM · MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), Anti-Harassment (The Letter Song), CheckUser

Feb 24 2020

dmaza added a comment to T237299: CU 2.0: Sticky highlighting in Preliminary check and Compare tabs.

@Tchanders To confirm - sticky highlights persist across paginated tabs right?

@Niharika Not in the current patch. We could do this by adding some extra information to be passed via the token: i.e. the data that should be highlighted when the next page loads.

Why can't we do it using local storage? It would mean that you will have to add the pin button to the first match in the new page so to allow the user to "unpin" but other than that I don't see a problem. Am I missing something?

Feb 24 2020, 10:32 PM · MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), Anti-Harassment (The Letter Song), CheckUser