Page MenuHomePhabricator

dmaza (Dayllan Maza)
Software Engineer

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jul 10 2017, 7:20 PM (114 w, 5 d)
Availability
Available
IRC Nick
DMaza
LDAP User
Dmaza
MediaWiki User
DMaza (WMF) [ Global Accounts ]

Recent Activity

Tue, Sep 17

dmaza added a comment to T233119: Intended use of MinimumPasswordLengthToLogin not so clear.

Looking into this

Tue, Sep 17, 5:23 PM · Core Platform Team Workboards (Clinic Duty Team), MW-1.31-release-notes, MW-1.32-notes, MW-1.33-notes, Documentation, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Trust-and-Safety, MediaWiki-Authentication-and-authorization, Anti-Harassment, MediaWiki-User-login-and-signup

Mon, Sep 16

dmaza moved T231577: Deploy Special:Mute features from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
Mon, Sep 16, 6:33 PM · Anti-Harassment (The Letter Song), Epic
dmaza claimed T231577: Deploy Special:Mute features.
Mon, Sep 16, 6:25 PM · Anti-Harassment (The Letter Song), Epic
dmaza closed T185785: Display an error message when users do not have JavaScript enabled as Resolved.
Mon, Sep 16, 5:56 PM · Anti-Harassment (The Letter Song), InteractionTimeline
dmaza moved T232510: Add namespace filter to the interaction-timeline API from In Progress to Review on the Anti-Harassment (The Letter Song) board.
Mon, Sep 16, 2:59 PM · Anti-Harassment (The Letter Song), InteractionTimeline

Fri, Sep 13

dmaza added a comment to T232510: Add namespace filter to the interaction-timeline API.

Pull Request here: https://github.com/wikimedia/InteractionTimeline/pull/117

Fri, Sep 13, 3:36 AM · Anti-Harassment (The Letter Song), InteractionTimeline

Thu, Sep 12

dmaza created T232753: Flow throws an exception for a particular User.
Thu, Sep 12, 3:13 PM · Growth-Team, StructuredDiscussions, Wikimedia-production-error

Wed, Sep 11

dmaza moved T232510: Add namespace filter to the interaction-timeline API from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
Wed, Sep 11, 4:31 AM · Anti-Harassment (The Letter Song), InteractionTimeline

Tue, Sep 10

dmaza claimed T232510: Add namespace filter to the interaction-timeline API.
Tue, Sep 10, 5:47 PM · Anti-Harassment (The Letter Song), InteractionTimeline
dmaza created T232510: Add namespace filter to the interaction-timeline API.
Tue, Sep 10, 5:47 PM · Anti-Harassment (The Letter Song), InteractionTimeline
dmaza updated subscribers of T190973: Timeline: Namespace filter.

@Niharika @dbarratt should we split this up into an server/client task? I'm happy to take on the server side of things

Tue, Sep 10, 4:48 PM · Anti-Harassment (The Letter Song), InteractionTimeline

Thu, Sep 5

dmaza added a comment to T191922: Enable $wgCookieSetOnIpBlock by default after the IP cookie block feature is fully tested and released.

@Jdforrester-WMF Since CommonSettings is currently setting these two configs to true there shouldn't be any problems I assume.

Thu, Sep 5, 9:50 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), MW-1.34-release, MediaWiki-User-management, MediaWiki-Configuration

Tue, Sep 3

dmaza added a comment to T224468: Block list and log incorrectly report "cannot edit own talk page" for some blocks.

I'd advocate for fixing all at once if there's a clean way to do it. @dmaza did you have a way in mind?

I do not.

Tue, Sep 3, 7:49 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Anti-Harassment (The Letter Song), MediaWiki-User-management

Tue, Aug 27

dmaza updated the task description for T229692: Use GetUserBlockComplete hook instead of GetBlockedStatus in TorBlock extension.
Tue, Aug 27, 10:44 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-extensions-TorBlock, MediaWiki-User-management

Mon, Aug 26

dmaza added a project to T231109: Remove Core coupling with GlobalBlocking extension: GlobalBlocking.
Mon, Aug 26, 6:04 PM · GlobalBlocking, MediaWiki-User-management

Fri, Aug 23

dmaza added projects to T231109: Remove Core coupling with GlobalBlocking extension: Core Platform Team, MediaWiki-User-management.
Fri, Aug 23, 7:17 PM · GlobalBlocking, MediaWiki-User-management
dmaza created T231109: Remove Core coupling with GlobalBlocking extension.
Fri, Aug 23, 6:17 PM · GlobalBlocking, MediaWiki-User-management

Aug 22 2019

dmaza closed T227678: Clear block cookie if the value is invalid as Resolved.
Aug 22 2019, 1:59 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Anti-Harassment (The Letter Song), MediaWiki-User-management

Aug 19 2019

dmaza moved T227005: Don't require that the blocker be a User for a SystemBlock from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
Aug 19 2019, 7:07 PM · Patch-For-Review, Anti-Harassment (The Letter Song), MediaWiki-User-management
dmaza claimed T227005: Don't require that the blocker be a User for a SystemBlock.
Aug 19 2019, 7:06 PM · Patch-For-Review, Anti-Harassment (The Letter Song), MediaWiki-User-management
dmaza moved T227678: Clear block cookie if the value is invalid from In Progress to Review on the Anti-Harassment (The Letter Song) board.
Aug 19 2019, 7:05 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Anti-Harassment (The Letter Song), MediaWiki-User-management
dmaza moved T224958: Instrument Special:Mute from In Progress to Review on the Anti-Harassment (The Letter Song) board.
Aug 19 2019, 7:05 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Analytics, Anti-Harassment (The Letter Song)

Aug 15 2019

dmaza added a comment to T185785: Display an error message when users do not have JavaScript enabled.

I think that's a bit gross. I would honestly rather just leave that English-only than do that.

Do you care to expand on this? I don't think "gross" is a valid argument

Aug 15 2019, 6:46 PM · Anti-Harassment (The Letter Song), InteractionTimeline
dmaza added a comment to T185785: Display an error message when users do not have JavaScript enabled.

would we rather:

  1. Enable server-rendering which will allow us to display the message in the user’s language. This will require splitting the tool into two tools (which is trivial, imho, and can remain in a single repo if we want): https://lists.wikimedia.org/pipermail/cloud/2019-August/000774.html
  2. Leave the app as “static” and display the message in all languages?
Aug 15 2019, 4:27 PM · Anti-Harassment (The Letter Song), InteractionTimeline

Aug 13 2019

dmaza moved T227678: Clear block cookie if the value is invalid from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
Aug 13 2019, 8:13 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Anti-Harassment (The Letter Song), MediaWiki-User-management
dmaza claimed T227678: Clear block cookie if the value is invalid.
Aug 13 2019, 8:12 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Anti-Harassment (The Letter Song), MediaWiki-User-management
dmaza added a comment to T224958: Instrument Special:Mute.

@Milimetric @nettrom_WMF correct me if I'm wrong but other than annotating that the schema is active[1] there isn't anything else I need to do to start logging events other than deploying the code[2] that would make use of it, right?

Aug 13 2019, 7:18 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Analytics, Anti-Harassment (The Letter Song)

Aug 5 2019

dmaza added a comment to T224958: Instrument Special:Mute.

Here is the schema for our data capture. Feel free to make changes and I'll fix up the patches
https://meta.wikimedia.org/wiki/Schema:SpecialMuteSubmit

Aug 5 2019, 8:04 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Analytics, Anti-Harassment (The Letter Song)
dmaza added a comment to T224468: Block list and log incorrectly report "cannot edit own talk page" for some blocks.

@dom_walden can you confirm that the issue is fixed tho? (Block list and log incorrectly report "cannot edit own talk page" for some blocks) I'll take a look at how the form displays the errors anyway

Aug 5 2019, 7:32 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Anti-Harassment (The Letter Song), MediaWiki-User-management
dmaza moved T224468: Block list and log incorrectly report "cannot edit own talk page" for some blocks from QA/Testing to In Progress on the Anti-Harassment (The Letter Song) board.
Aug 5 2019, 7:30 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Anti-Harassment (The Letter Song), MediaWiki-User-management
dmaza added a comment to T224468: Block list and log incorrectly report "cannot edit own talk page" for some blocks.

@dmaza Would it be better if the error message appeared underneath the "Editing their own talk page" checkbox?
This would make it immediately obvious what it refers to and would make it consistent with the location of other error messages (see below).

Makes sense, I'll fix it

Aug 5 2019, 7:30 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Anti-Harassment (The Letter Song), MediaWiki-User-management

Jul 30 2019

dmaza removed a watcher for LibUp: dmaza.
Jul 30 2019, 6:23 PM
dmaza moved T224468: Block list and log incorrectly report "cannot edit own talk page" for some blocks from In Progress to Review on the Anti-Harassment (The Letter Song) board.
Jul 30 2019, 2:41 AM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Anti-Harassment (The Letter Song), MediaWiki-User-management
dmaza claimed T224958: Instrument Special:Mute.
Jul 30 2019, 2:40 AM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Analytics, Anti-Harassment (The Letter Song)
dmaza moved T224958: Instrument Special:Mute from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
Jul 30 2019, 2:40 AM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Analytics, Anti-Harassment (The Letter Song)
dmaza added a comment to T224468: Block list and log incorrectly report "cannot edit own talk page" for some blocks.

Works for me.

Great

Jul 30 2019, 2:33 AM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Anti-Harassment (The Letter Song), MediaWiki-User-management
dmaza added a comment to T224468: Block list and log incorrectly report "cannot edit own talk page" for some blocks.

I'm saying you can show the error message, but the field may be disabled, so they may not be able to correct the error.

Jul 30 2019, 2:27 AM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Anti-Harassment (The Letter Song), MediaWiki-User-management

Jul 24 2019

dmaza added a comment to T218270: Mute: Add links to the Tools menu on user pages to mute/unmute user.

Sure, lets have another task and we can investigate there

Jul 24 2019, 7:44 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), MediaWiki-Email, Notifications, Growth-Team
dmaza renamed T228899: ApiGlobalBlock.php: Trying to get property 'gb_expiry' of non-object from Block.php: Trying to get property 'gb_expiry' of non-object to ApiGlobalBlock.php: Trying to get property 'gb_expiry' of non-object.
Jul 24 2019, 4:47 PM · Anti-Harassment, GlobalBlocking, Wikimedia-production-error
dmaza added a comment to T218270: Mute: Add links to the Tools menu on user pages to mute/unmute user.

Assuming $wgEnableSpecialMute = true. Neither $wgEnableUserEmailBlacklist nor $wgEchoPerUserBlacklist has to be true, which means you can see this link even if there is nothing you can do with it. I don't know why you would configure your wiki like this, though.

@dmaza I don't think we should show the link if the page is going to throw an error anyways. It's effectively an access denied (and perhaps we could use that mechanism?).

It shows an error message saying "Mute features are unavailable. This might be because: you haven't confirmed your email address or the wiki administrator has disabled email features and/or email blacklist for this wiki. "
We could check for $wgEnableUserEmailBlacklist but we can't check for $wgEchoPerUserBlacklist. I don't think there is anything we can do really other than what's already in place.

Jul 24 2019, 3:23 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), MediaWiki-Email, Notifications, Growth-Team

Jul 23 2019

dmaza closed T218270: Mute: Add links to the Tools menu on user pages to mute/unmute user, a subtask of T164542: Epic: ⚡️ General user mute/block feature, as Resolved.
Jul 23 2019, 7:49 PM · MediaWiki-extension-requests, Anti-Harassment
dmaza closed T218270: Mute: Add links to the Tools menu on user pages to mute/unmute user, a subtask of T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser, as Resolved.
Jul 23 2019, 7:49 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Email
dmaza closed T218270: Mute: Add links to the Tools menu on user pages to mute/unmute user as Resolved.
Jul 23 2019, 7:48 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), MediaWiki-Email, Notifications, Growth-Team

Jul 16 2019

dmaza added a comment to T224468: Block list and log incorrectly report "cannot edit own talk page" for some blocks.

If a user tries to save ipb_allow_usertalk in a way that does not conform with those rules, an error message should be shown and the block should not be saved.

Or maybe just do the thing that is expected, rather than throwing an error (because if the form field is in a disabled state, you wont be able to resolve the error).
In other words, DWIM.

Jul 16 2019, 2:26 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Anti-Harassment (The Letter Song), MediaWiki-User-management

Jul 11 2019

dmaza added a comment to T220163: Allow user to mute notifications from Special:Mute page.

@dmaza @dbarratt I agree it seems repetitive. We can make the user's name bold in the sentence above to make it a bit more prominent but let's go with ...from this user for now.

Jul 11 2019, 10:59 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song)
dmaza moved T220163: Allow user to mute notifications from Special:Mute page from Review to In Progress on the Anti-Harassment (The Letter Song) board.
Jul 11 2019, 7:37 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song)
dmaza moved T224468: Block list and log incorrectly report "cannot edit own talk page" for some blocks from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
Jul 11 2019, 5:17 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Anti-Harassment (The Letter Song), MediaWiki-User-management
dmaza claimed T224468: Block list and log incorrectly report "cannot edit own talk page" for some blocks.
Jul 11 2019, 5:17 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Anti-Harassment (The Letter Song), MediaWiki-User-management
dmaza updated the task description for T224468: Block list and log incorrectly report "cannot edit own talk page" for some blocks.
Jul 11 2019, 5:17 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Anti-Harassment (The Letter Song), MediaWiki-User-management
dmaza added a comment to T220163: Allow user to mute notifications from Special:Mute page.

Instead of saying "Mute emails from this user" and "Mute emails from this user" would it be better to say: "Mute emails from user ABC" and "Mute notifications from user ABC"?
I was just wondering because when I first come to the page, my brain skips the first line entirely and I read the options, which use this and then I have to figure out what this is.

Jul 11 2019, 3:24 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song)
dmaza moved T218270: Mute: Add links to the Tools menu on user pages to mute/unmute user from In Progress to Review on the Anti-Harassment (The Letter Song) board.
Jul 11 2019, 4:28 AM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), MediaWiki-Email, Notifications, Growth-Team
dmaza updated the task description for T218270: Mute: Add links to the Tools menu on user pages to mute/unmute user.
Jul 11 2019, 4:18 AM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), MediaWiki-Email, Notifications, Growth-Team

Jul 10 2019

dmaza added a comment to T227199: 'Editing their own talk page' option has no effect when editing not selected.

If the issue is that after unchecking "Editing", "Editing their own [...]" remains checked (although disabled), that will/should be fixed on T221117: Special:Block checkboxes should remember checked state. I personally don't see a problem other than what's described on T221117

Jul 10 2019, 2:47 PM · User-RhinosF1, Anti-Harassment, MediaWiki-User-management
dmaza added a comment to T227199: 'Editing their own talk page' option has no effect when editing not selected.

I'm a bit confused as to what is the issue here

Expected Result:
Either:
Grey 'Editing their own talk page' when editing blocks are disabled

Isn't this what's happening right now?

Jul 10 2019, 1:11 PM · User-RhinosF1, Anti-Harassment, MediaWiki-User-management

Jul 8 2019

dmaza moved T218270: Mute: Add links to the Tools menu on user pages to mute/unmute user from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
Jul 8 2019, 7:49 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), MediaWiki-Email, Notifications, Growth-Team
dmaza claimed T218270: Mute: Add links to the Tools menu on user pages to mute/unmute user.
Jul 8 2019, 7:49 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), MediaWiki-Email, Notifications, Growth-Team
dmaza moved T220163: Allow user to mute notifications from Special:Mute page from In Progress to Review on the Anti-Harassment (The Letter Song) board.
Jul 8 2019, 7:12 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song)
dmaza added a comment to T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.

@dmaza I prefer the non-prefixed version as I think User: is unnecessary context.

Jul 8 2019, 3:06 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Email
dmaza added a comment to T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.

@Niharika Just to confirm. Should the form header include User: as part of the text or just the username?
E.g
"Please select your mute preferences for ‪User:Vandal‬."
vs
"Please select your mute preferences for Vandal‬."

Jul 8 2019, 1:35 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Email

Jul 4 2019

dmaza added a comment to T226853: Hash all pageTokens or temporary identifiers from the EL Sanitization white-list for AHT.

@Niharika : Does AHT have any EventLogging schemas that are whitelisted?

I'm not sure. @dbarratt, @dmaza - do you know?

Jul 4 2019, 3:09 AM · Anti-Harassment, Product-Analytics, Analytics

Jul 2 2019

dmaza added a comment to T220163: Allow user to mute notifications from Special:Mute page.

@Niharika this task introduces a few changes that conflict with the error messages we added on T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser

Jul 2 2019, 8:05 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song)

Jun 27 2019

dmaza added a comment to T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.

@dmaza The email footer I see now (in my MUA at least) is: To manage email preferences for Steve please visit <http://192.168.122.72/T218265/index.php/Special:Mute/Steve>.

Jun 27 2019, 1:27 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Email

Jun 26 2019

dmaza added a comment to T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.

@Niharika emails from Special:EmailUser are in plain/text. Currently the default email footer looks as follow if I use the plain msg:

This email was sent by Admin to Vandal by the "Email this user" function at devwiki. If you reply to this email, your email will be sent directly to the original sender, revealing your email address to them.
[http://dev.wiki.local.wmftest.net:8080/wiki/Special:Mute/Admin Manage email preferences for ‪Admin‬.]
Jun 26 2019, 1:00 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Email

Jun 21 2019

dmaza claimed T220163: Allow user to mute notifications from Special:Mute page.
Jun 21 2019, 12:32 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song)
dmaza moved T220163: Allow user to mute notifications from Special:Mute page from Ready to In Progress on the Anti-Harassment (The Letter Song) board.
Jun 21 2019, 12:32 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song)

Jun 20 2019

dmaza moved T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser from In Progress to Review on the Anti-Harassment (Lāmed - ל) board.
Jun 20 2019, 4:27 AM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Email

Jun 5 2019

dmaza added a comment to T206163: Restrictions of overlapping blocks should be merged on enforcement.

+1 for CompositeBlock. IMO the name fits/describes how the object behaves (https://en.wikipedia.org/wiki/Composite_pattern)

Jun 5 2019, 9:47 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), Patch-For-Review, MediaWiki-User-management
dmaza moved T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser from Ready to In Progress on the Anti-Harassment (Lāmed - ל) board.
Jun 5 2019, 6:14 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Email

Jun 3 2019

dmaza added a comment to T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.

@dmaza I updated the task description. The things in bold are new. Did I manage to answer everything?
Sorry that the scope on this ticket keeps changing. :(

Jun 3 2019, 4:47 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Email
dmaza updated the task description for T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.
Jun 3 2019, 4:41 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Email
dmaza closed T221371: 'Thanks' are completely blocked when a user is partially blocked as Resolved.
Jun 3 2019, 4:32 PM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Anti-Harassment (Kaf - כ), Growth-Team, Thanks
dmaza closed T224613: Update Interaction Timeline to use the new actor table as Resolved.
Jun 3 2019, 4:32 PM · InteractionTimeline, Anti-Harassment (Kaf - כ)

May 31 2019

dmaza added a comment to T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.

@dbarratt @Niharika @aezell Can any of you update the task description and summarize how this should look/behave/text in the page and so on? I'm not 100% sure what's the consensus here.

May 31 2019, 5:28 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Email
dmaza added a comment to T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.

No. My point is that we need to make them checkboxes now, and avoid using verbs when arriving at this page.

This is what I was doing initially and we talked and agreed on not using a checkbox because there is only one option and it was bad UX (merging the lists or no)

May 31 2019, 12:53 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Email
dmaza added a comment to T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.

@dmaza I agree with David that "mute" by itself is ambiguous here. We should indicate that they are attempting to mute emails. So, for the first case, it should be like: "You have requested to mute emails from User:Vandal" and similarly for others.

Sure

May 31 2019, 4:57 AM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Email

May 30 2019

dmaza added a comment to T224613: Update Interaction Timeline to use the new actor table.

https://github.com/wikimedia/InteractionTimeline/pull/100

May 30 2019, 9:49 PM · InteractionTimeline, Anti-Harassment (Kaf - כ)
dmaza moved T224613: Update Interaction Timeline to use the new actor table from In Progress to Review on the Anti-Harassment (Kaf - כ) board.
May 30 2019, 9:48 PM · InteractionTimeline, Anti-Harassment (Kaf - כ)
dmaza claimed T224613: Update Interaction Timeline to use the new actor table.
May 30 2019, 12:35 PM · InteractionTimeline, Anti-Harassment (Kaf - כ)
dmaza moved T224613: Update Interaction Timeline to use the new actor table from Ready to In Progress on the Anti-Harassment (Kaf - כ) board.
May 30 2019, 12:35 PM · InteractionTimeline, Anti-Harassment (Kaf - כ)

May 28 2019

dmaza added a comment to T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.

Her are all the screens for this feature (so far)

May 28 2019, 9:01 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Email

May 24 2019

dmaza added a comment to T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.

@Niharika After discussing with @dbarratt we agreed that for this task it is not necessary to have a checkbox since the only available option will be to mute or unmute emails (for now). We propose to have a message indicating what action would happen depending if the user is already muted or not.

May 24 2019, 10:24 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Email
dmaza added a comment to T224245: Create a way to save preference options wherever they are set by GlobalPreferences without disruption.

@dbarratt I meant to check on GlobalPreferences not on core. Same thing @Mooeypoo is suggesting but checking against what we already have on the db instead of a config

May 24 2019, 5:18 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Community-Tech (Kanban (Q1 2019-20)), Patch-For-Review, Anti-Harassment, MediaWiki-extensions-GlobalPreferences
dmaza added a comment to T224245: Create a way to save preference options wherever they are set by GlobalPreferences without disruption.

I think I already asked this but it escapes me if I did. Why was it that we can't check if a given option is already a global preference or a local exception?
In other words, when saving "whatever-option" on onUserSaveOptions we could determine if it is a global preference and/or if it has a local override and make the changes wherever they need to be done.
Considering that the choice to make something a global or a local exception is made by the user I would say that it will be expected that any changes to those options will be stored based on the user's choice.

May 24 2019, 5:03 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Community-Tech (Kanban (Q1 2019-20)), Patch-For-Review, Anti-Harassment, MediaWiki-extensions-GlobalPreferences

May 17 2019

dmaza added a comment to T223646: Create a policy on importing global classes.

You could also create a new topic on https://www.mediawiki.org/wiki/Manual_talk:Coding_conventions/PHP. It might add more visibility.

May 17 2019, 7:07 PM · MediaWiki-Codesniffer, Code-Health

May 3 2019

dmaza added a comment to T222388: Create a mechanism for SpecialPages and API modules to have dependencies injected into them.

I think that supporting the definition to be either a callable or a string would be ideal (so a combination of your suggestions). It will make it backward compatible and we can start migrating into DI in incremental changes. SpecialPageFactory::getPage() already supports a string or a callable so a "quick" change would be to make $coreList non-static and adjust the SpecialPageFactory accordingly.
I'm not sure about Api Modules 'cause I haven't seen how that works

May 3 2019, 8:15 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-ServiceContainer, MediaWiki-API, MediaWiki-Special-pages, TechCom, Technical-Debt

May 2 2019

dmaza added a comment to T222281: Add a way to disable a users session and log them out when blocking.

i did say feature flag originally ;)

You did, sorry I missed it :)

May 2 2019, 8:40 PM · MediaWiki-User-management
dmaza added a project to T222281: Add a way to disable a users session and log them out when blocking: Anti-Harassment.
May 2 2019, 2:05 AM · MediaWiki-User-management
dmaza added a comment to T222281: Add a way to disable a users session and log them out when blocking.

Copying over the "in-patch" comment for better discussion

May 2 2019, 2:04 AM · MediaWiki-User-management

Apr 29 2019

dmaza claimed T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.
Apr 29 2019, 2:58 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Email
dmaza moved T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser from Ready to In Progress on the Anti-Harassment (Teth - ט) board.
Apr 29 2019, 2:58 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Email
dmaza closed T219684: BlockRestriction should be a service instead of a singleton as Resolved.
Apr 29 2019, 2:57 PM · MW-1.33-notes, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Anti-Harassment (Teth - ט), Patch-For-Review, MediaWiki-User-management, Technical-Debt
dmaza closed T219684: BlockRestriction should be a service instead of a singleton, a subtask of T221383: SpecialBlock should not be aware of the container, as Resolved.
Apr 29 2019, 2:57 PM · Technical-Debt, MediaWiki-User-management
dmaza closed T219684: BlockRestriction should be a service instead of a singleton, a subtask of T221680: BlockListPager should not be aware of the container, as Resolved.
Apr 29 2019, 2:57 PM · Technical-Debt, MediaWiki-User-management
dmaza closed T219684: BlockRestriction should be a service instead of a singleton, a subtask of T221722: ApiQueryBlocks should not be aware of the container, as Resolved.
Apr 29 2019, 2:57 PM · Technical-Debt, MediaWiki-User-management, MediaWiki-API
dmaza moved T219684: BlockRestriction should be a service instead of a singleton from Review to Done on the Anti-Harassment (Teth - ט) board.
Apr 29 2019, 2:56 PM · MW-1.33-notes, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Anti-Harassment (Teth - ט), Patch-For-Review, MediaWiki-User-management, Technical-Debt

Apr 24 2019

dmaza closed T214214: Disable block notice tracking as Resolved.
Apr 24 2019, 8:09 PM · MW-1.33-notes, Anti-Harassment (Teth - ט), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30)
dmaza moved T214214: Disable block notice tracking from In Progress to Done on the Anti-Harassment (Teth - ט) board.
Apr 24 2019, 8:08 PM · MW-1.33-notes, Anti-Harassment (Teth - ט), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30)
dmaza moved T214214: Disable block notice tracking from In Progress to Done on the Anti-Harassment (Heth - ח) board.
Apr 24 2019, 6:20 PM · MW-1.33-notes, Anti-Harassment (Teth - ט), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30)

Apr 19 2019

dmaza added a comment to T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.

It might also be a good idea to provide more info about mute (https://www.mediawiki.org/wiki/Help:Notifications#mute) and/or more information on how they can see their current email/mute list on Special:Preferences

Apr 19 2019, 8:56 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Email

Apr 17 2019

dmaza moved T193768: Remove debug logic when a Cookie is set for IP Blocks from In Progress to Done on the Anti-Harassment (Heth - ח) board.
Apr 17 2019, 2:34 PM · Patch-For-Review, Anti-Harassment (Heth - ח), Technical-Debt, MediaWiki-User-management