1.35.0-wmf.20 deployment blockers
Closed, ResolvedPublicRelease
Actions

Assigned To

Authored By

	• mmodell
	Sep 25 2019, 10:14 PM

Details

Backup Train Conductor: jeena
Release Version: 1.35.0-wmf.20
Release Date: Feb 17 2020, 12:00 AM

2020 week 08 1.35-wmf.20 Changes wmf/1.35.0-wmf.20

This MediaWiki Train Deployment is scheduled for the week of Monday, February 17th:

Monday February 17th	Tuesday, February 18th	Wednesday, February 19th	Thursday, February 20th	Friday
Backports only.	Branch `wmf.20` and deploy to Group 0 Wikis.	Deploy `wmf.20` to Group 1 Wikis.	Deploy `wmf.20` to all Wikis.	No deployments on fridays

See https://wikitech.wikimedia.org/wiki/Deployments for full schedule.

How this works

Any serious bugs affecting wmf.20 should be added as subtasks beneath this one.
- Use this form to create one.
Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
If you have a risky change in this week's train add a comment to this task using the Risky patch template
For more info about deployment blockers, see Holding the train.

Other Deployments

Previous: 1.35.0-wmf.19

Next: 1.35.0-wmf.21

	Subject	Repo	Branch	Lines +/-
	Group0 to 1.35.0-wmf.20	operations/mediawiki-config	master	+130 -130

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved	Release	Jdforrester-WMF	T233868 1.35.0-wmf.20 deployment blockers
Resolved	PRODUCTION ERROR	Tarrow	T245062 Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`"
Resolved		aaron	T245570 Duplicate entry 'ext.uls.pt-vector\|en' for key 'PRIMARY'

Event Timeline

• mmodell created this task.Sep 25 2019, 10:14 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 25 2019, 10:14 PM

thcipriani assigned this task to Jdforrester-WMF.Jan 16 2020, 10:10 PM

thcipriani triaged this task as Medium priority.

thcipriani updated Other Assignee, added: jeena.

thcipriani added a project: Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)).

thcipriani moved this task from INBOX to Deployment on the Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)) board.

• dduvall added a subtask: T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`".Feb 13 2020, 8:25 PM

Jdforrester-WMF closed subtask T245062: Double ?uselang= passed to a file results in "Cache key contains characters that are not allowed: `P180_1101514477_fr?uselang=fr_label`" as Resolved.Feb 14 2020, 7:29 PM

Mentioned in SAL (#wikimedia-operations) [2020-02-18T18:01:43Z] <James_F> 1.35.0-wmf.20 was branched at c664b4f1b933d110bd69f074c399695bd6b17d13 for T233868

Mentioned in SAL (#wikimedia-operations) [2020-02-18T18:25:09Z] <James_F> Running scap prep for 1.35.0-wmf.20 ref. T233868

Mentioned in SAL (#wikimedia-operations) [2020-02-18T18:51:36Z] <jforrester@deploy1001> Started scap: testwiki to 1.35.0-wmf.20 and re-build l10n cache T233868

Mentioned in SAL (#wikimedia-operations) [2020-02-18T19:52:37Z] <jforrester@deploy1001> Finished scap: testwiki to 1.35.0-wmf.20 and re-build l10n cache T233868 (duration: 61m 01s)

Change 572956 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[operations/mediawiki-config@master] Group0 to 1.35.0-wmf.20

https://gerrit.wikimedia.org/r/572956

gerritbot added a project: Patch-For-Review.Feb 18 2020, 7:55 PM

Change 572956 merged by jenkins-bot:
[operations/mediawiki-config@master] Group0 to 1.35.0-wmf.20

https://gerrit.wikimedia.org/r/572956

Mentioned in SAL (#wikimedia-operations) [2020-02-18T20:03:19Z] <jforrester@deploy1001> rebuilt and synchronized wikiversions files: group0 to 1.35.0-wmf.20 T233868

Krinkle added a subtask: T245570: Duplicate entry 'ext.uls.pt-vector|en' for key 'PRIMARY'.Feb 18 2020, 11:04 PM

zeljkofilipin mentioned this in T233867: 1.35.0-wmf.19 deployment blockers.Feb 19 2020, 2:32 PM

zeljkofilipin mentioned this in T245553: gallery slideshow stopped working.

Jdforrester-WMF closed subtask T245570: Duplicate entry 'ext.uls.pt-vector|en' for key 'PRIMARY' as Resolved.Feb 19 2020, 7:13 PM

Mentioned in SAL (#wikimedia-operations) [2020-02-20T20:07:23Z] <James_F> Train 1.35.0-wmf.20 provisionally looks OK on all wikis. Closing T233868.

Jdforrester-WMF closed this task as Resolved.Feb 20 2020, 8:07 PM

After the deployment we observed some Kafka consumer lag for the udp-logging_info topic:

https://grafana.wikimedia.org/d/000000484/kafka-consumer-lag?from=now-24h&to=now&orgId=1&v&var-datasource=eqiad%20prometheus%2Fops&var-cluster=logging-eqiad&var-topic=All&var-consumer_group=All

It recovered and then started alarming again. From what I can see there are a lot of messages like:

Use of ResourceLoaderSkinModule::getAvailableLogos with $wgLogoHD set instead of $wgLogos was deprecated in MediaWiki 1.35. [Called from ResourceLoaderSkinModule::getAvailableLogos in \/srv\/mediawiki\/php-1.35.0-wmf.20\/includes\/resourceloader\/ResourceLoaderSkinModule.php at line 339]

Edit: https://phabricator.wikimedia.org/T245778

1.35.0-wmf.20 deployment blockersClosed, ResolvedPublicReleaseActions