Page MenuHomePhabricator
Create Task
Maniphest T245778

Spike in "Use of ResourceLoaderSkinModule::getAvailableLogos with $wgLogoHD set instead of $wgLogos was deprecated in MediaWiki 1.35."
Closed, ResolvedPublic
Actions

Description

Mediawiki appears to have started emitting a significant amount of deprecation messages to logstash, for example:

https://logstash.wikimedia.org/goto/7618b08032132948faa201d3fbe5de33 - "Use of ResourceLoaderSkinModule::getAvailableLogos with $wgLogoHD set instead of $wgLogos was deprecated in MediaWiki 1.35."

Along with this kafka-logging has begun alerting on consumer lag, indicating that logstash is unable to keep up with the volume of log messages.

Can these deprecated messages be quickly disabled?

Details

SubjectRepoBranchLines +/-
ResourceLoaderSkinModule: Don't hard-deprecate wgLogoHD just nowmediawiki/coremaster+1 -1
ResourceLoaderSkinModule: Don't hard-deprecate wgLogoHD just nowmediawiki/corewmf/1.35.0-wmf.20+1 -1
Customize query in gerrit

Related Objects

Event Timeline

herron created this task.Feb 20 2020, 8:51 PM
Restricted Application added subscribers: Liuxinyu970226, Aklapper. · View Herald TranscriptFeb 20 2020, 8:51 PM
herron added a comment.Feb 20 2020, 8:52 PM

Similar to recent issue T245725

elukey triaged this task as High priority.Feb 21 2020, 8:04 AM
elukey mentioned this in T233868: 1.35.0-wmf.20 deployment blockers.
elukey added a subscriber: Jdforrester-WMF.
fgiunchedi mentioned this in T245725: ArticleEditUpdates deprecation log from FlaggedRevsHooks::onArticleEditUpdates spamming logs.Feb 21 2020, 8:37 AM
• jcrespo added a project: Wikimedia-production-error.Feb 21 2020, 1:10 PM
• jcrespo subscribed.

adding wikimedia production error because at the 3x the rate increase compared to normal levels of logging will soon start to affect monitoring of latest mediawiki errors. Probably not UBN, but starting to get worrying.

Screenshot_20200221_140852.png (952×2 px, 163 KB)

Screenshot_20200221_140913.png (745×1 px, 85 KB)

Reedy subscribed.Feb 21 2020, 1:17 PM

Same as T245182: Use of $wgLogoHD was deprecated in Rename configuration variable to $wgLogos

gerritbot added a comment.Feb 21 2020, 1:18 PM

Change 573993 had a related patch set uploaded (by Reedy; owner: Jforrester):
[mediawiki/core@wmf/1.35.0-wmf.20] ResourceLoaderSkinModule: Don't hard-deprecate wgLogoHD just now

https://gerrit.wikimedia.org/r/573993

gerritbot added a project: Patch-For-Review.Feb 21 2020, 1:18 PM

Change 573994 had a related patch set uploaded (by Reedy; owner: Jforrester):
[mediawiki/core@master] ResourceLoaderSkinModule: Don't hard-deprecate wgLogoHD just now

https://gerrit.wikimedia.org/r/573994

Reedy mentioned this in T232140: Separate out logo handling into square image logos and long text/wordmark banner logos.Feb 21 2020, 1:20 PM
gerritbot added a comment.Feb 21 2020, 1:36 PM

Change 573993 merged by Reedy:
[mediawiki/core@wmf/1.35.0-wmf.20] ResourceLoaderSkinModule: Don't hard-deprecate wgLogoHD just now

https://gerrit.wikimedia.org/r/573993

Stashbot added a comment.Feb 21 2020, 1:38 PM

Mentioned in SAL (#wikimedia-operations) [2020-02-21T13:38:15Z] <reedy@deploy1001> Synchronized php-1.35.0-wmf.20/includes/resourceloader/ResourceLoaderSkinModule.php: T245778 T245182 T232140 (duration: 01m 00s)

Stashbot mentioned this in T245182: Use of $wgLogoHD was deprecated in Rename configuration variable to $wgLogos.Feb 21 2020, 1:38 PM
gerritbot added a comment.Feb 21 2020, 1:43 PM

Change 573994 merged by jenkins-bot:
[mediawiki/core@master] ResourceLoaderSkinModule: Don't hard-deprecate wgLogoHD just now

https://gerrit.wikimedia.org/r/573994

Reedy closed this task as Resolved.Feb 21 2020, 1:44 PM
Reedy claimed this task.

Screenshot 2020-02-21 at 14.42.51.png (510×1 px, 69 KB)

Errors have gone completely. Shouldn't regress again as I've merged it into master too

Maintenance_bot removed a project: Patch-For-Review.Feb 21 2020, 2:10 PM
fgiunchedi subscribed.Feb 21 2020, 2:10 PM

Thanks @Reedy and @jcrespo ! Not that the issue is less urgent but for the record: this issue is/was affecting only the elk7 consumers (not yet in production, but in shadow mode) cluster=misc exported_cluster=logging-eqiad group=logstash7-eqiad instance=kafkamon1001:9501 job=burrow partition={0,1,2,3,4,5} site=eqiad topic=udp_localhost-info

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits