Page MenuHomePhabricator

Special:ListUsers should not fetch user groups itself
Open, LowPublicFeature

Description

Author: Bryan.TongMinh

Description:
User groups for Special:ListUsers should be fetched using User::getEffectiveGroups rather than performing the query itself, in order to give hooks that change groups the ability to do so.


Version: 1.14.x
Severity: enhancement

Details

Reference
bz15807

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 10:20 PM
bzimport set Reference to bz15807.
bzimport added a subscriber: Unknown Object (MLST).

From User::getEffectiveGroups:

  • Get the list of implicit group memberships this user has.
  • This includes all explicit groups, plus 'user' if logged in,
  • '*' for all accounts and autopromoted groups

This is wrong as the list would depends on the group membership(s) of the requesting user.

Maybe User::getAllGroups needs a hook call instead.

Aklapper changed the subtype of this task from "Task" to "Feature Request".Feb 4 2022, 11:01 AM
Aklapper removed a subscriber: wikibugs-l-list.