Page MenuHomePhabricator

mediawiki-twocolconflict grafana dashboard reports 0 conflicts resolved with TwoColCoflict since 5th October 2017
Closed, ResolvedPublic

Description

See https://grafana.wikimedia.org/dashboard/db/mediawiki-twocolconflict.
Noticed by @Lea_WMDE, and I agree this doesn't look right.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@Addshore Could you please check whether the problem is found on the level of the generating script? If it is not, please let me know and I will to Grafana to fix this dashboard.

This comment was removed by Addshore.
This comment was removed by Addshore.

The check @ https://github.com/wikimedia/mediawiki-extensions-TwoColConflict/blob/wmf/1.31.0-wmf.6/includes/TwoColConflictHooks.php#L53 is broken

if ( !$editPage->getContext()->getRequest()->getBool( 'mw-twocolconflict-submit' ) )

Actual post data looks something like tihs:

data = {array} [24]
 wpUnicodeCheck = "ℳ𝒲♥𝓊𝓃𝒾𝒸ℴ𝒹ℯ"
 wpAntispam = ""
 wpSection = ""
 wpStarttime = "20171103132114"
 wpEdittime = "20171103125125"
 editRevId = "6"
 wpScrolltop = "0"
 wpAutoSummary = "d41d8cd98f00b204e9800998ecf8427e"
 oldid = "0"
 parentRevId = "5"
 format = "text/x-wiki"
 model = "wikitext"
 mw-twocolconflict-title = "Main Page"
 mw-twocolconflict-same = "hide"
 mw-twocolconflict-your-text = ";lkkfs;lkfa;lkfsa;lkfalkf;lkfa;l"
 mw-twocolconflict-current-text = "lkjfkslaf;asf"
 wpTextbox1 = "RWSOLVED"
 wpSummary = ""
 wpSave = "Save changes"
 wpEditToken = "+\"
 mode = "conflict"
 wpUltimateParam = "1"
 title = "Main_Page"
 action = "submit"

This code has been removed in https://gerrit.wikimedia.org/r/#/c/379725/11/includes/TwoColConflictHooks.php which is merged and will be deployed next week.

Next weeks deployment should fix the issue with the dashboard.