Minerva should not alter or hide edit icons when not operating on mobile-formatted content
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Oct 31 2017, 1:28 AM

Description

The Minerva skin runs in 2 modes:

Desktop
Mobile

When visiting https://www.mediawiki.org/wiki/Reading/Web?useskin=minerva&useformat=desktop none of the section edit icons show despite being in the HTML.

I would like to reveal these by limiting the css that hides them to content that has been mobile-formatted.

Details

Subject	Repo	Branch	Lines +/-
Do not break edit links on non-mobile formatted pages	mediawiki/skins/MinervaNeue	master	+23 -10
Reveal edit icon and style top level headings on desktop Minerva	mediawiki/skins/MinervaNeue	master	+10 -1
Add mobile-formatted class to MobileFormatted content	mediawiki/extensions/MobileFrontend	master	+1 -0

Customize query in gerrit

Related Objects

Mentioned In: T166005: Editing/section collapsing edge cases

Event Timeline

Jdlrobson created this task.Oct 31 2017, 1:28 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 31 2017, 1:28 AM

Change 387503 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Add mobile-formatted class to MobileFormatted content

https://gerrit.wikimedia.org/r/387503

gerritbot added a project: Patch-For-Review.Oct 31 2017, 1:29 AM

Change 387504 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Do not break edit links on non-mobile formatted pages

https://gerrit.wikimedia.org/r/387504

Change 387841 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Reveal edit icon and style top level headings on desktop Minerva

https://gerrit.wikimedia.org/r/387841

Change 387503 abandoned by Jdlrobson:
Add mobile-formatted class to MobileFormatted content

https://gerrit.wikimedia.org/r/387503

Jdlrobson moved this task from Inbox to Doing on the User-Jdlrobson board.Nov 1 2017, 6:29 PM

Jdlrobson moved this task from Doing to Done on the User-Jdlrobson board.Nov 1 2017, 7:36 PM

Change 387841 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Reveal edit icon and style top level headings on desktop Minerva

https://gerrit.wikimedia.org/r/387841

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)).Nov 1 2017, 8:00 PM

Jdlrobson removed a project: Patch-For-Review.Nov 6 2017, 9:04 PM

Jdlrobson updated the task description. (Show Details)Nov 9 2017, 11:26 PM

Jdlrobson mentioned this in T166005: Editing/section collapsing edge cases.

Now fixed in production

Change 387504 abandoned by Jdlrobson:
Do not break edit links on non-mobile formatted pages

Reason:
Fixed in https://gerrit.wikimedia.org/r/387841