Page MenuHomePhabricator
Create Task
Maniphest T180144

Upgrade WebdriverIO to 4.12.0
Closed, ResolvedPublic
Actions

Description

While working on T161697 I have noticed that we did not upgrade WebdriverIO in a long time. We are currently using version 4.6.2. Our tests work fine up until version 4.7.1. Since version 4.8.0 our tests break because wdio tries to open http://127.0.0.1:8080/index.php... instead of http://127.0.0.1:8080/w/index.php... (please notice missing /w).

/w is configured in [[ https://phabricator.wikimedia.org/source/mediawiki/browse/master/tests/selenium/wdio.conf.js;858067fec39ffb88371fc936a40e4f88e0606ec4$123 | wdio.conf.js ]]

Commits v4.7.1...v4.8.0

Maybe this has caused the problem: make url act like url.resolve - closes #1946

Details

SubjectRepoBranchLines +/-
Selenium: Upgrade WebdriverIO to 4.12.0mediawiki/coremaster+4 -4
WIP Upgrade WebdriverIO to 4.9mediawiki/coremaster+2 -11
Customize query in gerrit

Related Objects
Search...

Event Timeline

zeljkofilipin created this task.Nov 9 2017, 4:12 PM
Restricted Application added a project: Release-Engineering-Team (Kanban). · View Herald TranscriptNov 9 2017, 4:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
zeljkofilipin moved this task from Backlog 🪒 to Deep work 🌊 on the User-zeljkofilipin board.Nov 9 2017, 4:12 PM
zeljkofilipin moved this task from Backlog to In-progress on the Release-Engineering-Team (Kanban) board.
zeljkofilipin added a comment.Nov 9 2017, 4:14 PM

An easy workaround is to change in [[ https://phabricator.wikimedia.org/source/mediawiki/browse/master/tests/selenium/pageobjects/page.js | page.js ]]

browser.url( '/index.php?title=' + path );

to

browser.url( 'w/index.php?title=' + path );
zeljkofilipin triaged this task as Low priority.Nov 9 2017, 4:17 PM
zeljkofilipin moved this task from Deep work 🌊 to Q4 👔 on the User-zeljkofilipin board.Nov 9 2017, 4:22 PM
zeljkofilipin removed zeljkofilipin as the assignee of this task.Nov 14 2017, 12:15 PM
zeljkofilipin moved this task from In-progress to Backlog on the Release-Engineering-Team (Kanban) board.
zeljkofilipin mentioned this in T139740: Port Selenium tests from Ruby to Node.js.Nov 14 2017, 12:37 PM
zeljkofilipin claimed this task.Nov 29 2017, 12:05 PM
zeljkofilipin moved this task from Q4 👔 to Deep work 🌊 on the User-zeljkofilipin board.Nov 29 2017, 6:37 PM
zeljkofilipin moved this task from Backlog to In-progress on the Release-Engineering-Team (Kanban) board.Nov 29 2017, 6:44 PM
zeljkofilipin added a comment.EditedNov 30 2017, 3:56 PM
git clone https://github.com/webdriverio/webdriverio.git
cd webdriverio
git bisect start
git bisect bad 63908ce0
git bisect good a611b804
git bisect run bash -c 'npm run build && ./bin/wdio ~/Documents/gerrit/mediawiki/vagrant/mediawiki/tests/selenium/wdio.conf.js --spec ~/Documents/gerrit/mediawiki/vagrant/mediawiki/tests/selenium/specs/page.js --mochaOpts.grep creatable'
zeljkofilipin added a comment.Nov 30 2017, 4:38 PM
877e276fe4b5f03600a1d1d2fbeb3563398753c2 is the first bad commit
commit 877e276fe4b5f03600a1d1d2fbeb3563398753c2
Author: christian-bromann <mail@christian-bromann.com>
Date:   Sun Apr 30 14:50:52 2017 +0200

    make url act like url.resolve - closes #1946

:040000 040000 422c9f97dfed82fa28a9e44f81ac0d938003a0db 71dd744fb8f7426726233107a0e02e63d0519bbe M	lib
:040000 040000 bdd238e0c14b6c465f2811ea82010ef07076768f 59476f80ecba8cafae294bd7441b13a54f615683 M	test
bisect run success
gerritbot subscribed.Dec 5 2017, 10:32 AM

Change 395490 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[mediawiki/core@master] WIP Upgrade WebdriverIO to 4.9

https://gerrit.wikimedia.org/r/395490

gerritbot added a project: Patch-For-Review.Dec 5 2017, 10:32 AM
zeljkofilipin added a parent task: T182421: Q3 Selenium framework improvements.Dec 8 2017, 2:08 PM
zeljkofilipin removed zeljkofilipin as the assignee of this task.Dec 8 2017, 2:12 PM
zeljkofilipin moved this task from In-progress to Backlog on the Release-Engineering-Team (Kanban) board.
zeljkofilipin moved this task from Deep work 🌊 to Q4 👔 on the User-zeljkofilipin board.
zeljkofilipin moved this task from Q4 👔 to Backlog 🪒 on the User-zeljkofilipin board.Jan 11 2018, 4:00 PM
zeljkofilipin moved this task from Backlog 🪒 to Q4 👔 on the User-zeljkofilipin board.Feb 20 2018, 3:54 PM
zeljkofilipin raised the priority of this task from Low to High.Feb 28 2018, 4:53 PM
zeljkofilipin mentioned this in T182421: Q3 Selenium framework improvements.Mar 2 2018, 3:33 PM
zeljkofilipin renamed this task from Upgrade WebdriverIO to 4.9 to Upgrade WebdriverIO to 4.12.0.Mar 13 2018, 1:07 PM
zeljkofilipin claimed this task.
zeljkofilipin moved this task from Q4 👔 to Deep work 🌊 on the User-zeljkofilipin board.
zeljkofilipin moved this task from Backlog to In-progress on the Release-Engineering-Team (Kanban) board.
gerritbot added a comment.Mar 13 2018, 1:30 PM

Change 395490 abandoned by Zfilipin:
WIP Upgrade WebdriverIO to 4.9

https://gerrit.wikimedia.org/r/395490

gerritbot added a comment.Mar 13 2018, 1:30 PM

Change 419179 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[mediawiki/core@master] WIP Upgrade WebdriverIO to 4.12.0

https://gerrit.wikimedia.org/r/419179

zeljkofilipin moved this task from Deep work 🌊 to Waiting 🏹 on the User-zeljkofilipin board.Mar 13 2018, 4:42 PM
gerritbot added a comment.Mar 21 2018, 2:37 PM

Change 419179 merged by jenkins-bot:
[mediawiki/core@master] Selenium: Upgrade WebdriverIO to 4.12.0

https://gerrit.wikimedia.org/r/419179

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)).Mar 21 2018, 3:00 PM
zeljkofilipin moved this task from Waiting 🏹 to Deep work 🌊 on the User-zeljkofilipin board.Mar 21 2018, 3:29 PM
zeljkofilipin closed this task as Resolved.Mar 21 2018, 3:32 PM
zeljkofilipin mentioned this in T191982: Blog posts about new Selenium framework features.Apr 11 2018, 2:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL