Page MenuHomePhabricator
Create Task
Maniphest T182421

Q3 Selenium framework improvements
Closed, ResolvedPublic
Actions

Description

There are many things to improve in our current framework that are not critical for resolving T139740: Port Selenium tests from Ruby to Node.js. Sub-tasks are what we hope to do in Q3.

Some needed improvements are listed in User:Jdlrobson/Experiences porting Ruby browser tests to NodeJs. Please see talk page for discussion.

The important tasks that have to be resolved in this quarter to consider this a success:

Details

SubjectRepoBranchLines +/-
Use wd/hub not /wd/hub in selenium.shmediawiki/coremaster+1 -1
ESLint parserOptions is redundant when env is set to es6mediawiki/extensions/ORESmaster+0 -3
ESLint parserOptions is redundant when env is set to es6mediawiki/extensions/AdvancedSearchmaster+1 -4
Page title is not used in Selenium testsmediawiki/coremaster+0 -3
When running Selenium tests, use `wd/hub`mediawiki/coremaster+1 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
zeljkofilipin added a subtask: T182412: Investigate if WebdriverIO `sync: false` would be useful to us and document how to use it.Dec 8 2017, 2:16 PM
zeljkofilipin added a subtask: T181284: Replace nodemw with mwbot.Dec 8 2017, 2:20 PM
zeljkofilipin added a subtask: T167507: WebdriverIO should run Chrome headlessly.
zeljkofilipin updated the task description. (Show Details)Dec 8 2017, 3:09 PM
zeljkofilipin added a subtask: T182691: Selenium tests should be easier to run.Dec 12 2017, 3:07 PM
zeljkofilipin added a subtask: T182692: Document differences between Ruby and Node.js Selenium frameworks.Dec 12 2017, 3:29 PM
zeljkofilipin renamed this task from Selenium framework improvements to Q3 Selenium framework improvements.Dec 15 2017, 1:24 PM
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin mentioned this in T182986: Selenium framework improvements.Dec 15 2017, 1:26 PM
zeljkofilipin changed the status of subtask T161697: Run Selenium tests using Firefox from Open to Stalled.Dec 15 2017, 1:29 PM
zeljkofilipin removed a subtask: T161697: Run Selenium tests using Firefox.
zeljkofilipin removed a subtask: T167507: WebdriverIO should run Chrome headlessly.Dec 15 2017, 1:32 PM
zeljkofilipin removed a subtask: T164721: Run Selenium tests in CI per-patch for extensions.Dec 15 2017, 1:38 PM
zeljkofilipin added a subtask: T180482: Create mediawiki-core-qunit-selenium-composer-jessie.
zeljkofilipin added a subtask: T175179: Create selenium-CirrusSearch-jessie daily Jenkins job.
zeljkofilipin added a subtask: T180125: Refactor mediawiki-core-qunit-selenium-jessie Jenkins job so qunit/karma and webdriverio are invoked via npm script.Dec 15 2017, 1:40 PM
zeljkofilipin added a subtask: T179188: Video recording for Selenium tests in Node.js.
zeljkofilipin added a subtask: T164721: Run Selenium tests in CI per-patch for extensions.Dec 15 2017, 1:48 PM
zeljkofilipin removed a subtask: T175179: Create selenium-CirrusSearch-jessie daily Jenkins job.
zeljkofilipin removed a subtask: T180125: Refactor mediawiki-core-qunit-selenium-jessie Jenkins job so qunit/karma and webdriverio are invoked via npm script.
zeljkofilipin removed a subtask: T180482: Create mediawiki-core-qunit-selenium-composer-jessie.
zeljkofilipin removed zeljkofilipin as the assignee of this task.Dec 15 2017, 2:43 PM
zeljkofilipin raised the priority of this task from Medium to High.
zeljkofilipin moved this task from In-progress to Backlog on the Release-Engineering-Team (Kanban) board.
zeljkofilipin moved this task from Deep work 🌊 to Q4 👔 on the User-zeljkofilipin board.
zeljkofilipin added a subtask: T183160: Sample code in Node.js for repositories that still have Selenium+Ruby tests.Dec 18 2017, 5:36 PM
zeljkofilipin added a subtask: T183162: Patches in Gerrit deleting Selenium+Ruby tests for repositories that still have them.Dec 18 2017, 5:39 PM
zeljkofilipin claimed this task.Jan 11 2018, 4:09 PM
zeljkofilipin moved this task from Backlog to In-progress on the Release-Engineering-Team (Kanban) board.
zeljkofilipin moved this task from Q4 👔 to Deep work 🌊 on the User-zeljkofilipin board.
gerritbot subscribed.Jan 16 2018, 5:40 PM

Change 404507 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[mediawiki/core@master] When running Selenium tests, use wd/hub

https://gerrit.wikimedia.org/r/404507

gerritbot added a project: Patch-For-Review.Jan 16 2018, 5:40 PM
gerritbot added a comment.Jan 16 2018, 6:05 PM

Change 404507 merged by WMDE-Fisch:
[mediawiki/core@master] When running Selenium tests, use wd/hub

https://gerrit.wikimedia.org/r/404507

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)).Jan 16 2018, 7:00 PM
gerritbot added a comment.Jan 17 2018, 12:16 PM

Change 404657 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[mediawiki/core@master] Page title is not used in Selenium tests

https://gerrit.wikimedia.org/r/404657

zeljkofilipin added a subtask: T185094: Update page object pattern in Selenium tests.Jan 17 2018, 12:21 PM
gerritbot added a comment.Jan 17 2018, 1:08 PM

Change 404657 merged by jenkins-bot:
[mediawiki/core@master] Page title is not used in Selenium tests

https://gerrit.wikimedia.org/r/404657

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)); removed MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)).Jan 17 2018, 2:00 PM
zeljkofilipin added a subtask: T185315: selenium-EXTENSION-jessie Jenkins job should have e-mail notification.Jan 19 2018, 1:54 PM
zeljkofilipin added a subtask: T185011: Create selenium-daily-beta-MediaWiki daily Jenkins job.Feb 20 2018, 3:56 PM
zeljkofilipin added a subtask: T185928: New usermessage browser test is blocking merges in Minerva skin and Echo extension.Feb 21 2018, 10:11 AM
zeljkofilipin removed a subtask: T185928: New usermessage browser test is blocking merges in Minerva skin and Echo extension.
zeljkofilipin added a subtask: T187859: Move one Selenium tests from mediawiki/core to mediawiki/skins/Vector.
zeljkofilipin added a subtask: T187862: Update README file for Selenium tests.Feb 21 2018, 10:20 AM
gerritbot added a comment.Feb 21 2018, 11:32 AM

Change 413139 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[mediawiki/extensions/AdvancedSearch@master] ESLint parserOptions is redundant when env is set to es6

https://gerrit.wikimedia.org/r/413139

zeljkofilipin mentioned this in rEASRc43019be8711: ESLint parserOptions is redundant when env is set to es6.Feb 21 2018, 11:34 AM
gerritbot added a comment.Feb 21 2018, 11:44 AM

Change 413144 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[mediawiki/extensions/ORES@master] ESLint parserOptions is redundant when env is set to es6

https://gerrit.wikimedia.org/r/413144

gerritbot added a comment.Feb 21 2018, 12:41 PM

Change 413139 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] ESLint parserOptions is redundant when env is set to es6

https://gerrit.wikimedia.org/r/413139

gerritbot added a comment.Feb 21 2018, 12:41 PM

Change 413144 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] ESLint parserOptions is redundant when env is set to es6

https://gerrit.wikimedia.org/r/413144

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)); removed MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Feb 21 2018, 1:00 PM
zeljkofilipin closed subtask T185315: selenium-EXTENSION-jessie Jenkins job should have e-mail notification as Resolved.Feb 27 2018, 11:38 AM
zeljkofilipin closed subtask T187862: Update README file for Selenium tests as Resolved.Feb 28 2018, 10:38 AM
zeljkofilipin added a subtask: T188740: Retrospective for T139740 Port Selenium tests from Ruby to Node.js.Mar 2 2018, 3:29 PM
zeljkofilipin updated the task description. (Show Details)Mar 2 2018, 3:33 PM
zeljkofilipin added a subtask: T188742: Run tests daily targeting beta cluster for all repositories with Selenium tests.Mar 2 2018, 3:40 PM
zeljkofilipin added a subtask: T188744: Find a few people interested in reviewing Selenium patches.Mar 2 2018, 3:52 PM
zeljkofilipin mentioned this in T188744: Find a few people interested in reviewing Selenium patches.Mar 2 2018, 3:57 PM
greg edited projects, added Epic, Release-Engineering-Team; removed Release-Engineering-Team (Kanban).Mar 3 2018, 12:36 AM
greg moved this task from INBOX to Epics (ARCHIVED) on the Release-Engineering-Team board.
zeljkofilipin closed subtask T188744: Find a few people interested in reviewing Selenium patches as Resolved.Mar 12 2018, 2:56 PM
zeljkofilipin closed subtask T180144: Upgrade WebdriverIO to 4.12.0 as Resolved.Mar 21 2018, 3:32 PM
greg updated the task description. (Show Details)Mar 21 2018, 3:58 PM
zeljkofilipin closed subtask T180379: Use createAccount() in Selenium tests as Declined.Mar 21 2018, 4:22 PM
zeljkofilipin closed subtask T181284: Replace nodemw with mwbot as Resolved.Mar 26 2018, 11:58 AM
zeljkofilipin mentioned this in Blog Post: Selenium tests in Node.js project retrospective.Mar 26 2018, 1:50 PM
zeljkofilipin closed subtask T188740: Retrospective for T139740 Port Selenium tests from Ruby to Node.js as Resolved.Mar 26 2018, 2:30 PM
zeljkofilipin reopened subtask T181284: Replace nodemw with mwbot as Open.Mar 26 2018, 2:40 PM
zeljkofilipin removed a subtask: T164721: Run Selenium tests in CI per-patch for extensions.Mar 26 2018, 4:47 PM
zeljkofilipin removed a subtask: T183160: Sample code in Node.js for repositories that still have Selenium+Ruby tests.Mar 26 2018, 4:51 PM
zeljkofilipin removed a subtask: T188742: Run tests daily targeting beta cluster for all repositories with Selenium tests.
zeljkofilipin closed subtask T181284: Replace nodemw with mwbot as Resolved.Mar 27 2018, 4:31 PM
zeljkofilipin added a subtask: T167507: WebdriverIO should run Chrome headlessly.Mar 28 2018, 12:21 PM
zeljkofilipin removed a subtask: T183162: Patches in Gerrit deleting Selenium+Ruby tests for repositories that still have them.Mar 28 2018, 3:46 PM
zeljkofilipin added a parent task: T182986: Selenium framework improvements.Mar 29 2018, 8:40 AM
zeljkofilipin added a project: MediaWiki-Core-Tests.Mar 29 2018, 8:43 AM
zeljkofilipin moved this task from Inbox to Selenium on the MediaWiki-Core-Tests board.
zeljkofilipin removed a subtask: T182691: Selenium tests should be easier to run.Mar 29 2018, 9:11 AM
zeljkofilipin removed a subtask: T185094: Update page object pattern in Selenium tests.
zeljkofilipin changed the status of subtask T187859: Move one Selenium tests from mediawiki/core to mediawiki/skins/Vector from Open to Stalled.
zeljkofilipin removed a subtask: T187859: Move one Selenium tests from mediawiki/core to mediawiki/skins/Vector.
zeljkofilipin removed a subtask: T185011: Create selenium-daily-beta-MediaWiki daily Jenkins job.
zeljkofilipin removed a subtask: T182412: Investigate if WebdriverIO `sync: false` would be useful to us and document how to use it.Mar 31 2018, 2:02 PM
zeljkofilipin removed a subtask: T182692: Document differences between Ruby and Node.js Selenium frameworks.
zeljkofilipin closed subtask T167507: WebdriverIO should run Chrome headlessly as Resolved.Apr 11 2018, 11:24 AM
zeljkofilipin mentioned this in T191982: Blog posts about new Selenium framework features.Apr 11 2018, 2:50 PM
zeljkofilipin removed zeljkofilipin as the assignee of this task.Apr 12 2018, 11:53 AM
zeljkofilipin moved this task from Deep work 🌊 to Waiting 🏹 on the User-zeljkofilipin board.May 18 2018, 1:04 PM
gerritbot added a comment.Jun 7 2018, 4:28 PM

Change 438044 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/core@master] Use wd/hub not /wd/hub in selenium.sh

https://gerrit.wikimedia.org/r/438044

Diffusion mentioned this in rEASR2df3bc8aee71: Final NoteDb migration updates.Jun 8 2018, 9:48 PM
gerritbot added a comment.Jun 13 2018, 12:20 PM

Change 438044 merged by WMDE-Fisch:
[mediawiki/core@master] Use wd/hub not /wd/hub in selenium.sh

https://gerrit.wikimedia.org/r/438044

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)).Jun 13 2018, 1:00 PM
zeljkofilipin closed this task as Resolved.Jun 28 2018, 11:09 AM
zeljkofilipin claimed this task.
zeljkofilipin moved this task from Waiting 🏹 to Deep work 🌊 on the User-zeljkofilipin board.

Resolving this task, since Q3 is long passed. The only remaining task (T179188) will be resolved in Q1.

zeljkofilipin closed subtask T179188: Video recording for Selenium tests in Node.js as Resolved.Oct 17 2018, 10:10 AM
hashar reopened subtask T179188: Video recording for Selenium tests in Node.js as Open.Oct 18 2018, 8:02 AM
zeljkofilipin closed subtask T179188: Video recording for Selenium tests in Node.js as Resolved.Nov 27 2018, 4:17 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL