Page MenuHomePhabricator
Create Task
Maniphest T185011

Create selenium-daily-beta-MediaWiki daily Jenkins job
Closed, ResolvedPublic
Actions

Assigned To
zeljkofilipin
Authored By
zeljkofilipin
Jan 16 2018, 5:20 PM
Tags
Referenced Files
F25648080: Special-Watchlist-should-show-page-with-new-edit.mp4
Sep 4 2018, 10:15 AM
F25648075: Page-should-be-editable.mp4
Sep 4 2018, 10:14 AM
F25648031: Page-should-be-creatable.mp4
Sep 4 2018, 10:10 AM
F25648029: Page-should-be-re-creatable.mp4
Sep 4 2018, 10:10 AM
F25648032: Page-should-be-restorable.mp4
Sep 4 2018, 10:10 AM
F25648030: User-should-be-able-to-create-account.mp4
Sep 4 2018, 10:10 AM
F25648033: Page-should-have-history.mp4
Sep 4 2018, 10:10 AM
F25648028: BlankPage-should-have-its-title.mp4
Sep 4 2018, 10:10 AM
View All 10 Files
Subscribers
Aklapper
daniel
gerritbot
hashar
Krinkle
zeljkofilipin

Description

Running selenium-MediaWiki-jessie daily Jenkins job would help detect and prevent problems like Incident documentation/20180111-LegacyEncoding.

It would require refactoring selenium tests. At the moment, mediawiki/core tests target only mediawiki-vagrant and jenkins where no logging is required to create/update users/pages. Running at beta cluster would require logging in for every action.

Done

💀 415027 (integration/config): WIP Create selenium-core-jessie daily Jenkins job
💀 420040 (integration/config): WIP Create selenium-MediaWiki-jessie daily Jenkins job
💀 420057 (mediawiki/core): Selenium: configuration file for beta cluster
💀 420674 (mediawiki/core): Revert "Selenium: configuration file for beta cluster"
💀 446371 (mediawiki/core) Selenium: add selenium-daily NPM script
🏠 456131 Selenium: selenium-daily NPM script
🏠 457854: Selenium: Daily Jenkins job targeting beta cluster should run only tests that pass
🏠 457881: Create selenium-daily-beta-MediaWiki Jenkins job
🏠 selenium-daily-beta-MediaWiki

Details

SubjectRepoBranchLines +/-
Create selenium-daily-beta-MediaWiki Jenkins jobintegration/configmaster+8 -0
Selenium: Daily Jenkins job targeting beta cluster should run only tests that passmediawiki/coremaster+5 -5
Selenium: add selenium-daily NPM scriptmediawiki/coremaster+1 -0
WIP Create selenium-core-jessie daily Jenkins jobintegration/configmaster+19 -4
Selenium: configuration file for beta clustermediawiki/coremaster+21 -0
WIP Create selenium-MediaWiki-jessie daily Jenkins jobintegration/jenkinsmaster+9 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

zeljkofilipin created this task.Jan 16 2018, 5:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 16 2018, 5:20 PM
greg added a project: Wikimedia-Incident.Jan 17 2018, 4:45 PM
greg moved this task from Active investigation to Follow-up prevention on the Wikimedia-Incident board.
zeljkofilipin added a parent task: T182421: Q3 Selenium framework improvements.Feb 20 2018, 3:56 PM
zeljkofilipin moved this task from Inbox to Selenium on the MediaWiki-Core-Tests board.
greg triaged this task as Medium priority.Feb 21 2018, 4:59 PM
zeljkofilipin raised the priority of this task from Medium to High.Feb 23 2018, 5:32 PM
zeljkofilipin moved this task from Backlog 🪒 to Q4 👔 on the User-zeljkofilipin board.
zeljkofilipin added subscribers: daniel, hashar.Feb 23 2018, 5:43 PM

@daniel says there are at least a couple extensions that would log you in if you are coming from an IP:

https://www.mediawiki.org/wiki/Extension:NetworkAuth
https://www.mediawiki.org/wiki/Extension:IPAuth

Configuration:

$wgIPAuthUsers = array( "127.0.0.1" => "Admin" );

@hashar: is that something we could enable at beta cluster?

Enabling the extension would mean we do not have to refactor core selenium tests, making them more complicated.

zeljkofilipin added a comment.Feb 26 2018, 10:40 AM

I have just talked with @hashar about this. Another option would be to log in using the API and then inject the cookie in the browser.

gerritbot subscribed.Feb 27 2018, 3:55 PM

Change 415027 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[integration/config@master] WIP Create selenium-core-jessie daily Jenkins job

https://gerrit.wikimedia.org/r/415027

gerritbot added a project: Patch-For-Review.Feb 27 2018, 3:55 PM
zeljkofilipin added a comment.Feb 27 2018, 4:04 PM

Created test job, selenium-MediaWiki-jessie.

zeljkofilipin claimed this task.Feb 28 2018, 10:39 AM
zeljkofilipin moved this task from Q4 👔 to Deep work 🌊 on the User-zeljkofilipin board.
zeljkofilipin moved this task from Backlog to In-progress on the Release-Engineering-Team (Kanban) board.
zeljkofilipin added a comment.EditedMar 1 2018, 10:27 AM

Webdriverio has a feature to run selected tests. Unfortunately, it does not work well. 😢

zeljkofilipin renamed this task from Create selenium-core-jessie daily Jenkins job to Create selenium-MediaWiki-jessie daily Jenkins job.Mar 2 2018, 3:41 PM
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin mentioned this in T188742: Run tests daily targeting beta cluster for all repositories with Selenium tests.Mar 2 2018, 3:44 PM
gerritbot added a comment.Mar 16 2018, 2:54 PM

Change 420040 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[integration/jenkins@master] WIP Create selenium-MediaWiki-jessie daily Jenkins job

https://gerrit.wikimedia.org/r/420040

gerritbot added a comment.Mar 16 2018, 3:30 PM

Change 420040 abandoned by Zfilipin:
WIP Create selenium-MediaWiki-jessie daily Jenkins job

https://gerrit.wikimedia.org/r/420040

gerritbot added a comment.Mar 16 2018, 3:55 PM

Change 420057 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[mediawiki/core@master] WIP Create selenium-MediaWiki-jessie daily Jenkins job

https://gerrit.wikimedia.org/r/420057

zeljkofilipin added a comment.Mar 16 2018, 4:33 PM
In T185011#4000693, @zeljkofilipin wrote:

I have just talked with @hashar about this. Another option would be to log in using the API and then inject the cookie in the browser.

browser.setCookie(cookie);

gerritbot added a comment.Mar 16 2018, 6:10 PM

Change 420057 merged by jenkins-bot:
[mediawiki/core@master] Selenium: configuration file for beta cluster

https://gerrit.wikimedia.org/r/420057

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)).Mar 16 2018, 7:01 PM
Krinkle subscribed.EditedMar 16 2018, 9:19 PM
In T185011#4057264, @gerritbot wrote:

Change 420057 merged by jenkins-bot:
[mediawiki/core@master] Selenium: configuration file for beta cluster

https://gerrit.wikimedia.org/r/420057

@zeljkofilipin Files like that generally should not be in MediaWiki core. Could you explain how this file will be used? It seems like the four configuration values are taken directly from environment variables, which should be the default already. We drive the QUnit tests that way as well. The only variance between local, master and beta testing is env variables. The Jenkins job glues it together.

greg lowered the priority of this task from High to Medium.Mar 19 2018, 10:39 PM
zeljkofilipin removed zeljkofilipin as the assignee of this task.Mar 20 2018, 11:09 AM
zeljkofilipin moved this task from Deep work 🌊 to Q4 👔 on the User-zeljkofilipin board.
zeljkofilipin moved this task from In-progress to Backlog on the Release-Engineering-Team (Kanban) board.
zeljkofilipin added a comment.Mar 20 2018, 11:12 AM
In T185011#4057686, @Krinkle wrote:

@zeljkofilipin Files like that generally should not be in MediaWiki core.

I'll revert it.

zeljkofilipin edited parent tasks, added: T190994: Q4 Selenium framework improvements; removed: T182421: Q3 Selenium framework improvements.Mar 29 2018, 9:12 AM
zeljkofilipin moved this task from Q4 👔 to Backlog 🪒 on the User-zeljkofilipin board.May 9 2018, 3:33 PM
zeljkofilipin edited parent tasks, added: T198389: Q1 Selenium framework improvements; removed: T190994: Q4 Selenium framework improvements.Jun 28 2018, 4:38 PM
zeljkofilipin mentioned this in T198389: Q1 Selenium framework improvements.
gerritbot added a comment.Jul 17 2018, 4:36 PM

Change 415027 abandoned by Zfilipin:
WIP Create selenium-core-jessie daily Jenkins job

Reason:
will be implemented in T188742

https://gerrit.wikimedia.org/r/415027

zeljkofilipin claimed this task.Jul 17 2018, 4:38 PM
zeljkofilipin moved this task from Backlog 🪒 to Deep work 🌊 on the User-zeljkofilipin board.
zeljkofilipin moved this task from Backlog to In-progress on the Release-Engineering-Team (Kanban) board.
zeljkofilipin added a parent task: T188742: Run tests daily targeting beta cluster for all repositories with Selenium tests.
zeljkofilipin updated the task description. (Show Details)Jul 17 2018, 4:43 PM
gerritbot added a comment.Jul 17 2018, 5:01 PM

Change 446371 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[mediawiki/core@master] Selenium: add selenium-daily NPM script

https://gerrit.wikimedia.org/r/446371

zeljkofilipin updated the task description. (Show Details)Jul 17 2018, 5:02 PM
zeljkofilipin updated the task description. (Show Details)Jul 17 2018, 5:26 PM
zeljkofilipin updated the task description. (Show Details)Jul 17 2018, 5:30 PM
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin removed zeljkofilipin as the assignee of this task.Jul 31 2018, 2:54 PM
zeljkofilipin moved this task from Deep work 🌊 to Q4 👔 on the User-zeljkofilipin board.
zeljkofilipin moved this task from In-progress to Backlog on the Release-Engineering-Team (Kanban) board.
gerritbot added a comment.Aug 7 2018, 4:18 PM

Change 446371 abandoned by Zfilipin:
Selenium: add selenium-daily NPM script

Reason:
not needed

https://gerrit.wikimedia.org/r/446371

zeljkofilipin claimed this task.Aug 7 2018, 4:24 PM
zeljkofilipin moved this task from Q4 👔 to Deep work 🌊 on the User-zeljkofilipin board.
zeljkofilipin moved this task from Backlog to In-progress on the Release-Engineering-Team (Kanban) board.
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin updated the task description. (Show Details)Aug 7 2018, 4:26 PM
hashar added a comment.Aug 22 2018, 11:15 AM

I would require that job to NOT use Nodepool but be run via a Docker container. I am not sure how to achieve that yet though.

zeljkofilipin renamed this task from Create selenium-MediaWiki-jessie daily Jenkins job to Create MediaWiki-npm-browser-run-selenium-test-node-6-docker daily Jenkins job.Aug 22 2018, 11:32 AM
zeljkofilipin added a comment.Aug 22 2018, 11:34 AM

@hashar sorry, I have forgot to rename the task. I've done it now. I have created the job using Docker containers, MediaWiki-npm-browser-run-selenium-test-node-6-docker. It's failing because tests should be refactored, but otherwise runs just fine.

hashar added a comment.Aug 22 2018, 11:44 AM

Ahhh great. So maybe we will also be able to migrate the daily tests for extensions so? Namely:

selenium-CirrusSearch-jessie
selenium-Echo-jessie
selenium-Math-jessie
selenium-Popups-jessie
selenium-RelatedArticles-jessie

zeljkofilipin added a comment.Aug 22 2018, 11:46 AM

Already in progress! See T188742: Run tests daily targeting beta cluster for all repositories with Selenium tests.

zeljkofilipin updated the task description. (Show Details)Sep 3 2018, 1:08 PM
zeljkofilipin removed a project: Patch-For-Review.Sep 3 2018, 1:32 PM
zeljkofilipin updated the task description. (Show Details)
gerritbot added a comment.Sep 4 2018, 9:27 AM

Change 457854 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[mediawiki/core@master] Selenium: Daily Jenkins job targeting beta cluster should run only tests that pass

https://gerrit.wikimedia.org/r/457854

gerritbot added a project: Patch-For-Review.Sep 4 2018, 9:27 AM
zeljkofilipin renamed this task from Create MediaWiki-npm-browser-run-selenium-test-node-6-docker daily Jenkins job to Create selenium-daily-beta-MediaWiki daily Jenkins job.Sep 4 2018, 9:29 AM
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin added a comment.EditedSep 4 2018, 10:10 AM

Videos of failed tests:

Page-should-be-creatable.mp4147 KBDownload

Page-should-be-deletable.mp4712 KBDownload

Page-should-be-re-creatable.mp4246 KBDownload

Page-should-be-restorable.mp4360 KBDownload

Special-Watchlist-should-show-page-with-new-edit.mp4542 KBDownload

User-should-be-able-to-create-account.mp4132 KBDownload

gerritbot added a comment.Sep 4 2018, 12:06 PM

Change 457881 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[integration/config@master] Create selenium-daily-beta-MediaWiki Jenkins job

https://gerrit.wikimedia.org/r/457881

zeljkofilipin updated the task description. (Show Details)Sep 4 2018, 12:07 PM
gerritbot added a comment.Sep 5 2018, 4:23 PM

Change 457854 merged by jenkins-bot:
[mediawiki/core@master] Selenium: Daily Jenkins job targeting beta cluster should run only tests that pass

https://gerrit.wikimedia.org/r/457854

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)).Sep 5 2018, 5:00 PM
gerritbot added a comment.Sep 11 2018, 10:07 AM

Change 457881 merged by jenkins-bot:
[integration/config@master] Create selenium-daily-beta-MediaWiki Jenkins job

https://gerrit.wikimedia.org/r/457881

hashar closed this task as Resolved.Sep 11 2018, 2:05 PM

Pass https://integration.wikimedia.org/ci/job/selenium-daily-beta-MediaWiki/

All patches have been merged.

zeljkofilipin updated the task description. (Show Details)Sep 11 2018, 3:52 PM
Krinkle edited projects, added Sustainability (Incident Followup); removed Wikimedia-Incident.Apr 28 2020, 9:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL