Page MenuHomePhabricator
Create Task
Maniphest T164721

Run Selenium tests in CI per-patch for extensions
Closed, ResolvedPublic
Actions

Description

All extensions that have Selenium tests should run tests per-patch. Cucumber tests (T179190) and daily jobs (T188742) are out of scope for this task.

Status

RepositoryCommitStatus
mediawiki/extensions/CentralAuth373522
mediawiki/extensions/CentralNotice380891
mediawiki/extensions/CirrusSearch381785T175179
mediawiki/extensions/Echo368409
mediawiki/extensions/ElectronPdfService371044
mediawiki/extensions/GettingStarted340124
mediawiki/extensions/Math346982
mediawiki/extensions/MobileFrontend392026T180125
mediawiki/extensions/MultimediaViewer389542
mediawiki/extensions/PageTriage391151
mediawiki/extensions/QuickSurveys340127
mediawiki/extensions/RevisionSlider387762
mediawiki/extensions/TwoColConflict390694
mediawiki/extensions/Wikibase391202T180482
mediawiki/extensions/WikibaseLexeme386140T180482
mediawiki/extensions/WikiLove340133
mediawiki/skins/MinervaNeue373902

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a comment.Jul 18 2017, 12:53 PM

Change 364190 abandoned by Zfilipin:
WIP Copy extensions/RelatedArticles/tests/browser/LocalSettings.php to LocalSettings.php

Reason:
just a test

https://gerrit.wikimedia.org/r/364190

zeljkofilipin added a comment.Jul 19 2017, 11:21 AM

This is all is needed:

if [ -f ./src/extensions/RelatedArticles/tests/browser/LocalSettings.php ]; then
   echo '<?php include_once "$IP/extensions/RelatedArticles/tests/browser/LocalSettings.php"; ?>' >> ./src/LocalSettings.php
fi

Works for both mediawiki/core (mediawiki-core-qunit-selenium-337602-jessie/19) and RelatedArticles (mediawiki-core-qunit-selenium-337602-jessie/20).

gerritbot added a comment.Jul 19 2017, 11:39 AM

Change 366236 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[integration/config@master] Use RelatedArticles' LocalSettings.php when running Selenium tests

https://gerrit.wikimedia.org/r/366236

gerritbot added a comment.Jul 19 2017, 12:09 PM

Change 366244 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[mediawiki/extensions/RelatedArticles@master] WIP Use RelatedArticles' LocalSettings.php when running Selenium tests

https://gerrit.wikimedia.org/r/366244

gerritbot added a comment.Jul 19 2017, 12:12 PM

Change 366245 had a related patch set uploaded (by Hashar; owner: Hashar):
[mediawiki/extensions/RelatedArticles@master] On CI register browser tests LocalSettings

https://gerrit.wikimedia.org/r/366245

gerritbot added a comment.Jul 19 2017, 12:15 PM

Change 366244 abandoned by Zfilipin:
WIP Use RelatedArticles' LocalSettings.php when running Selenium tests

Reason:
Better implementation: https://gerrit.wikimedia.org/r/#/c/366245/

https://gerrit.wikimedia.org/r/366244

gerritbot added a comment.Jul 19 2017, 12:29 PM

Change 366245 abandoned by Hashar:
On CI register browser tests LocalSettings

Reason:
Will be done directly in the CI job

https://gerrit.wikimedia.org/r/366245

gerritbot added a comment.Jul 20 2017, 10:18 AM

Change 366531 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[integration/config@master] WIP Run WebdriverIO tests in CI for extensions

https://gerrit.wikimedia.org/r/366531

gerritbot added a comment.Jul 20 2017, 11:21 AM

Change 366236 abandoned by Zfilipin:
Use RelatedArticles' LocalSettings.php when running Selenium tests

Reason:
Will be implemented differently in https://gerrit.wikimedia.org/r/#/c/366531

https://gerrit.wikimedia.org/r/366236

zeljkofilipin added a comment.Jul 20 2017, 3:09 PM

Done:

Pending review:

  • I have created a patch that updates mediawiki-core-qunit-selenium-jessie so it can run RelatedArticles tests, 366531

To do:

ReadMore-is-present-in-Minerva.png (899×1 px, 22 KB)

Jdlrobson added a comment.Jul 20 2017, 4:04 PM

looks like a page is not created properly, ReadMore-is-present-in-Minerva.png

I've explained this before on another bug. You can see from the screenshot that the "Related Articles 1" page has not been created. This should be created by the test run (L40 of https://gerrit.wikimedia.org/r/#/c/347116/32/tests/selenium/support/index.js ) - the fact it isn't suggests there is something wrong with the article creation API.

gerritbot added a comment.Jul 21 2017, 2:00 PM

Change 366531 merged by jenkins-bot:
[integration/config@master] Run WebdriverIO tests in CI for extensions

https://gerrit.wikimedia.org/r/366531

zeljkofilipin closed this task as Resolved.Jul 21 2017, 2:10 PM

Resolved in https://gerrit.wikimedia.org/r/366531

zeljkofilipin closed subtask T164002: Update documentation for mediawiki-core-qunit-selenium-jessie Jenkins job as Resolved.Jul 21 2017, 2:55 PM
Jdlrobson added a comment.Jul 21 2017, 5:21 PM

Good job! :)

zeljkofilipin awarded a token.Jul 22 2017, 11:43 AM
• Phabricator_maintenance edited projects, added RelEng-Archive-FY201718-Q1; removed Release-Engineering-Team (Kanban).Sep 26 2017, 11:46 PM
zeljkofilipin reopened this task as Open.Nov 13 2017, 2:48 PM
zeljkofilipin lowered the priority of this task from High to Medium.
zeljkofilipin removed projects: RelEng-Archive-FY201718-Q1, MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), Patch-For-Review, Browser-Tests-Infrastructure.
Restricted Application added a project: Release-Engineering-Team (Kanban). · View Herald TranscriptNov 13 2017, 2:48 PM
zeljkofilipin removed a parent task: T164024: Rewrite Related pages browser tests in Node.js.Nov 13 2017, 2:49 PM
zeljkofilipin updated the task description. (Show Details)
gerritbot added a comment.Nov 13 2017, 2:53 PM

Change 390447 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[integration/config@master] Run qunit-selenium job for all repositories that have Selenium tests

https://gerrit.wikimedia.org/r/390447

gerritbot added a project: Patch-For-Review.Nov 13 2017, 2:53 PM
zeljkofilipin updated the task description. (Show Details)Nov 13 2017, 2:56 PM
zeljkofilipin added a comment.Nov 13 2017, 3:20 PM

@hashar should mediawiki-core-qunit-selenium-jessie be disabled for Wikibase too, like it is for WikibaseLexeme?

zeljkofilipin added a comment.Nov 13 2017, 3:40 PM

6 (out of 18) repos already have extension-selenium template, so I have added (as @hashar) has suggested mediawiki-core-qunit-selenium-jessie to the template, instead of directly to the repo configuration. I have also added mwext-ruby-jessie to the template since 3 (out of 6) repos had that job too.

The rest of the repos have mediawiki-core-qunit-selenium-jessie in experimental pipeline.

I am not sure what to do with Wikibase and WikibaseLexeme? Create mediawiki-core-qunit-selenium-composer?

gerritbot added a comment.Nov 13 2017, 5:05 PM

Change 390447 merged by jenkins-bot:
[integration/config@master] Run qunit-selenium job for all repositories that have Selenium tests

https://gerrit.wikimedia.org/r/390447

zeljkofilipin updated the task description. (Show Details)Nov 14 2017, 12:44 PM
zeljkofilipin updated the task description. (Show Details)Nov 14 2017, 12:50 PM
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin updated the task description. (Show Details)Nov 14 2017, 1:13 PM
zeljkofilipin updated the task description. (Show Details)Nov 14 2017, 3:46 PM
zeljkofilipin updated the task description. (Show Details)Nov 14 2017, 3:50 PM
zeljkofilipin updated the task description. (Show Details)Nov 14 2017, 3:53 PM
zeljkofilipin added a subtask: T180482: Create mediawiki-core-qunit-selenium-composer-jessie.Nov 14 2017, 3:57 PM
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin updated the task description. (Show Details)Nov 14 2017, 3:59 PM
zeljkofilipin updated the task description. (Show Details)Nov 14 2017, 4:06 PM
zeljkofilipin renamed this task from Run WebdriverIO tests in CI for extensions to Run Selenium tests in CI for extensions.Nov 15 2017, 12:29 PM
zeljkofilipin updated the task description. (Show Details)Nov 15 2017, 12:32 PM
zeljkofilipin added a subtask: T175179: Create selenium-CirrusSearch-jessie daily Jenkins job.Nov 15 2017, 12:34 PM
zeljkofilipin added a subtask: T179190: Run Selenium Cucumber tests in CI.
zeljkofilipin added a subtask: T180125: Refactor mediawiki-core-qunit-selenium-jessie Jenkins job so qunit/karma and webdriverio are invoked via npm script.
zeljkofilipin added a subtask: T179188: Video recording for Selenium tests in Node.js.Nov 15 2017, 12:36 PM
zeljkofilipin removed zeljkofilipin as the assignee of this task.Nov 29 2017, 6:40 PM
zeljkofilipin moved this task from Deep work 🌊 to Q4 👔 on the User-zeljkofilipin board.
zeljkofilipin moved this task from In-progress to Backlog on the Release-Engineering-Team (Kanban) board.Nov 29 2017, 6:49 PM
zeljkofilipin edited parent tasks, added: T182421: Q3 Selenium framework improvements; removed: T139740: Port Selenium tests from Ruby to Node.js.Dec 8 2017, 2:11 PM
zeljkofilipin edited parent tasks, added: T182986: Selenium framework improvements; removed: T182421: Q3 Selenium framework improvements.Dec 15 2017, 1:38 PM
zeljkofilipin removed a subtask: T179188: Video recording for Selenium tests in Node.js.Dec 15 2017, 1:42 PM
zeljkofilipin removed a subtask: T180125: Refactor mediawiki-core-qunit-selenium-jessie Jenkins job so qunit/karma and webdriverio are invoked via npm script.
zeljkofilipin removed a subtask: T175179: Create selenium-CirrusSearch-jessie daily Jenkins job.
zeljkofilipin removed a subtask: T180482: Create mediawiki-core-qunit-selenium-composer-jessie.
zeljkofilipin removed a subtask: T179190: Run Selenium Cucumber tests in CI.Dec 15 2017, 1:45 PM
zeljkofilipin moved this task from Q4 👔 to Backlog 🪒 on the User-zeljkofilipin board.
zeljkofilipin edited parent tasks, added: T182421: Q3 Selenium framework improvements; removed: T182986: Selenium framework improvements.Dec 15 2017, 1:48 PM
zeljkofilipin added a subtask: T175179: Create selenium-CirrusSearch-jessie daily Jenkins job.
zeljkofilipin added a subtask: T180125: Refactor mediawiki-core-qunit-selenium-jessie Jenkins job so qunit/karma and webdriverio are invoked via npm script.
zeljkofilipin added a subtask: T180482: Create mediawiki-core-qunit-selenium-composer-jessie.
zeljkofilipin closed subtask T175179: Create selenium-CirrusSearch-jessie daily Jenkins job as Resolved.Jan 17 2018, 3:40 PM
zeljkofilipin removed a parent task: T182421: Q3 Selenium framework improvements.Mar 26 2018, 4:47 PM
zeljkofilipin added a parent task: T182986: Selenium framework improvements.
zeljkofilipin edited parent tasks, added: T190994: Q4 Selenium framework improvements; removed: T182986: Selenium framework improvements.Mar 29 2018, 9:01 AM
zeljkofilipin added a subtask: T188742: Run tests daily targeting beta cluster for all repositories with Selenium tests.
zeljkofilipin added a subtask: T179190: Run Selenium Cucumber tests in CI.Mar 29 2018, 9:17 AM
zeljkofilipin mentioned this in T190994: Q4 Selenium framework improvements.
zeljkofilipin added a subtask: T195496: mediawiki-core-qunit-selenium-jessie sometimes fails for extensions.May 24 2018, 3:41 PM
hashar closed subtask T195496: mediawiki-core-qunit-selenium-jessie sometimes fails for extensions as Resolved.Jun 14 2018, 8:29 AM
zeljkofilipin claimed this task.Jun 28 2018, 11:24 AM
zeljkofilipin added a project: MediaWiki-Core-Tests.
zeljkofilipin moved this task from Backlog 🪒 to Deep work 🌊 on the User-zeljkofilipin board.
zeljkofilipin moved this task from Backlog to In-progress on the Release-Engineering-Team (Kanban) board.
zeljkofilipin moved this task from Inbox to Selenium on the MediaWiki-Core-Tests board.
zeljkofilipin updated the task description. (Show Details)Jun 28 2018, 1:15 PM
zeljkofilipin rescinded a token.
zeljkofilipin awarded a token.
zeljkofilipin updated the task description. (Show Details)Jun 28 2018, 3:27 PM
zeljkofilipin updated the task description. (Show Details)Jun 28 2018, 3:29 PM
zeljkofilipin removed a subtask: T179190: Run Selenium Cucumber tests in CI.
zeljkofilipin updated the task description. (Show Details)Jun 28 2018, 3:32 PM
zeljkofilipin closed subtask T180482: Create mediawiki-core-qunit-selenium-composer-jessie as Invalid.Jun 28 2018, 3:42 PM
zeljkofilipin removed a subtask: T188742: Run tests daily targeting beta cluster for all repositories with Selenium tests.
zeljkofilipin removed a project: Patch-For-Review.Jun 28 2018, 3:52 PM
zeljkofilipin renamed this task from Run Selenium tests in CI for extensions to Run Selenium tests in CI per-patch for extensions.Jun 28 2018, 5:27 PM
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin updated the task description. (Show Details)Jun 28 2018, 6:11 PM
zeljkofilipin updated the task description. (Show Details)Jun 28 2018, 6:18 PM
zeljkofilipin closed this task as Resolved.Jun 29 2018, 10:53 AM
zeljkofilipin closed subtask T180125: Refactor mediawiki-core-qunit-selenium-jessie Jenkins job so qunit/karma and webdriverio are invoked via npm script as Invalid.
zeljkofilipin added a subtask: T198409: Set up CI for running Node.js+Selenium tests for repositories that have Ruby+Selenium tests.Jun 29 2018, 1:08 PM
zeljkofilipin closed subtask T198409: Set up CI for running Node.js+Selenium tests for repositories that have Ruby+Selenium tests as Invalid.
• Vvjjkkii reopened subtask T195496: mediawiki-core-qunit-selenium-jessie sometimes fails for extensions as Open.Jul 1 2018, 1:08 AM
JJMC89 closed subtask T195496: mediawiki-core-qunit-selenium-jessie sometimes fails for extensions as Resolved.Jul 1 2018, 2:12 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL