Page MenuHomePhabricator

Amazon code should allow specifiying proxy parameters in configuration
Closed, ResolvedPublic4 Story Points

Description

When we create amazon pay SDK objects such as payments and reports clients and IPN handlers, we should be able to apply proxy settings read from configuration.

Event Timeline

Ejegg created this task.Nov 9 2017, 8:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 9 2017, 8:59 PM
Ejegg moved this task from Analysis to Completed in Q2 2017-18 on the Fundraising-Backlog board.

Change 390331 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Get Amazon SDK object from SmashPig config

https://gerrit.wikimedia.org/r/390331

Change 390331 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Get Amazon SDK object from SmashPig config

https://gerrit.wikimedia.org/r/390331

Change 391018 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/SmashPig@master] Pass proxy parameters to Amazon SDK

https://gerrit.wikimedia.org/r/391018

Change 391018 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] Pass proxy parameters to Amazon SDK

https://gerrit.wikimedia.org/r/391018

Change 402365 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/SmashPig@master] YAML null: magic string instead of ~

https://gerrit.wikimedia.org/r/402365

Change 402365 abandoned by Ejegg:
YAML null: magic string instead of ~

https://gerrit.wikimedia.org/r/402365

We need to enable TCP proxy pass-through:

The suggestion from Amazon: https://gist.github.com/islandskater43/0a518043f8f2f530a344866cdd9d17bf

The current attempt on our fork (needs testing): https://github.com/ejegg/login-and-pay-with-amazon-sdk-php/tree/tcpProxy

Change 408278 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Update Amazon SDK fork for TCP proxy

https://gerrit.wikimedia.org/r/408278

Change 408278 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Update Amazon SDK fork for TCP proxy

https://gerrit.wikimedia.org/r/408278

Change 408794 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/SmashPig@master] Update Amazon SDK for selective TCP proxy

https://gerrit.wikimedia.org/r/408794

Change 408794 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] Update Amazon SDK for selective TCP proxy

https://gerrit.wikimedia.org/r/408794

Ejegg closed this task as Resolved.Feb 13 2018, 8:55 PM
Ejegg triaged this task as Normal priority.
Ejegg set the point value for this task to 4.