Page MenuHomePhabricator
Create Task
Maniphest T181335

Redesign onRecentChange_save hook handler for ORES
Closed, ResolvedPublic
Actions

Description

Now there are several models with different needs and usecases in ORES which is making this hook handler to become overtly complex and needs rewrite from scratch.

Details

SubjectRepoBranchLines +/-
Change default config of ores models to use the new systemmediawiki/extensions/ORESmaster+17 -5
Add tests for new system of $wgOresModelsmediawiki/extensions/ORESmaster+106 -2
Rewrite RecentChangeSaveHookHandler, part Imediawiki/extensions/ORESmaster+74 -18
Move Hooks::onRecentChange_save to a dedicated classmediawiki/extensions/ORESmaster+167 -82
Introduce SqlScoreLookup and use it in APImediawiki/extensions/ORESmaster+147 -15
Customize query in gerrit

Related Objects

Event Timeline

Ladsgroup created this task.Nov 25 2017, 1:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 25 2017, 1:53 PM
Ladsgroup claimed this task.Nov 25 2017, 1:53 PM
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptNov 25 2017, 1:53 PM
Halfak edited projects, added Machine-Learning-Team; removed Machine-Learning-Team (Active Tasks).Dec 18 2017, 3:57 PM
Ladsgroup moved this task from Incoming to In progress on the User-Ladsgroup board.Dec 28 2017, 11:02 PM
gerritbot subscribed.Jan 20 2018, 5:36 PM

Change 405535 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/ORES@master] Introduce SqlScoreLookup and use it in API

https://gerrit.wikimedia.org/r/405535

gerritbot added a project: Patch-For-Review.Jan 20 2018, 5:36 PM
Ladsgroup edited projects, added Machine-Learning-Team (Active Tasks); removed Machine-Learning-Team.Jan 20 2018, 5:37 PM
Ladsgroup moved this task from Parked to Review on the Machine-Learning-Team (Active Tasks) board.Jan 20 2018, 5:42 PM
gerritbot added a comment.Jan 23 2018, 5:54 PM

Change 405535 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Introduce SqlScoreLookup and use it in API

https://gerrit.wikimedia.org/r/405535

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Jan 23 2018, 6:00 PM
awight moved this task from Review to Pending deployment on the Machine-Learning-Team (Active Tasks) board.Jan 23 2018, 8:23 PM
Ladsgroup moved this task from Pending deployment to Parked on the Machine-Learning-Team (Active Tasks) board.Jan 23 2018, 8:28 PM
gerritbot added a comment.Feb 7 2018, 6:54 PM

Change 408849 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/ORES@master] Move Hooks::onRecentChange_save to a dedicated class

https://gerrit.wikimedia.org/r/408849

Ladsgroup moved this task from Parked to Review on the Machine-Learning-Team (Active Tasks) board.Feb 7 2018, 6:54 PM
gerritbot added a comment.Feb 7 2018, 8:38 PM

Change 408849 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Move Hooks::onRecentChange_save to a dedicated class

https://gerrit.wikimedia.org/r/408849

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)); removed MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Feb 7 2018, 9:00 PM
Ladsgroup moved this task from Review to Parked on the Machine-Learning-Team (Active Tasks) board.Feb 7 2018, 9:03 PM
gerritbot added a comment.Feb 19 2018, 2:18 PM

Change 412708 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/ORES@master] Rewrite RecentChangeSaveHookHandler, part I

https://gerrit.wikimedia.org/r/412708

Ladsgroup moved this task from Parked to Review on the Machine-Learning-Team (Active Tasks) board.Feb 19 2018, 2:32 PM
gerritbot added a comment.Feb 19 2018, 5:12 PM

Change 412708 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Rewrite RecentChangeSaveHookHandler, part I

https://gerrit.wikimedia.org/r/412708

Ladsgroup moved this task from Review to Parked on the Machine-Learning-Team (Active Tasks) board.Feb 19 2018, 5:17 PM
ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)); removed MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)).Feb 19 2018, 6:00 PM
gerritbot added a comment.Feb 21 2018, 9:42 PM

Change 413259 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/ORES@master] Add tests for new system of $wgOresModels

https://gerrit.wikimedia.org/r/413259

Ladsgroup moved this task from Parked to Review on the Machine-Learning-Team (Active Tasks) board.Feb 21 2018, 9:44 PM
gerritbot added a comment.Feb 26 2018, 1:12 PM

Change 413259 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Add tests for new system of $wgOresModels

https://gerrit.wikimedia.org/r/413259

Ladsgroup moved this task from Review to Parked on the Machine-Learning-Team (Active Tasks) board.Feb 26 2018, 1:13 PM
ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)); removed MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)).Feb 26 2018, 2:00 PM
Ladsgroup moved this task from Parked to Review on the Machine-Learning-Team (Active Tasks) board.Mar 7 2018, 12:03 PM
gerritbot added a comment.Mar 7 2018, 12:03 PM

Change 416928 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/ORES@master] Change default config of ores models to use the new system

https://gerrit.wikimedia.org/r/416928

gerritbot added a comment.Mar 7 2018, 8:10 PM

Change 416928 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Change default config of ores models to use the new system

https://gerrit.wikimedia.org/r/416928

Ladsgroup moved this task from Review to Pending deployment on the Machine-Learning-Team (Active Tasks) board.Mar 12 2018, 9:52 AM
awight subscribed.Apr 9 2018, 6:34 PM

Looks like we can mark this as done, or is this pending a train deployment?

Ladsgroup added a comment.Apr 9 2018, 9:41 PM

This has been deployed long time ago.

awight moved this task from Pending deployment to Completed on the Machine-Learning-Team (Active Tasks) board.Apr 9 2018, 9:49 PM
awight mentioned this in Blog Post: Status Update (May 2, 2018).May 2 2018, 6:43 PM
awight closed this task as Resolved.May 2 2018, 6:46 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits