Page MenuHomePhabricator
Create Task
Maniphest T182111

Cached thresholds should be purged when model version is incremented
Closed, ResolvedPublic
Actions

Description

This should be part of handling a new model version. Old thresholds are meaningless for a new model.

Details

SubjectRepoBranchLines +/-
Clean up ThresholdLookup, make the cache key use model versionmediawiki/extensions/ORESmaster+138 -87
Customize query in gerrit

Related Objects

Event Timeline

awight created this task.Dec 5 2017, 3:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 5 2017, 3:29 PM
Ladsgroup subscribed.Dec 16 2017, 5:47 PM

The proper way to handle it IMO is to include version in the cache key.

Ladsgroup claimed this task.Dec 16 2017, 5:49 PM
Ladsgroup edited projects, added Machine-Learning-Team (Active Tasks); removed Machine-Learning-Team.

I might not pick this up immediately but will do it very soon.

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptDec 16 2017, 5:49 PM
gerritbot subscribed.Dec 26 2017, 12:07 AM

Change 400196 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/ORES@master] Clean up ThresholdLookup, make the cache key use model version

https://gerrit.wikimedia.org/r/400196

gerritbot added a project: Patch-For-Review.Dec 26 2017, 12:07 AM
Ladsgroup moved this task from Parked to Review on the Machine-Learning-Team (Active Tasks) board.Dec 26 2017, 12:08 AM
awight added a comment.Dec 26 2017, 12:09 AM

Yes, that looks great! I'll review once the predecessor patch is stabilized.

gerritbot added a comment.Dec 28 2017, 7:44 PM

Change 400196 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Clean up ThresholdLookup, make the cache key use model version

https://gerrit.wikimedia.org/r/400196

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)).Dec 28 2017, 8:00 PM
Ladsgroup moved this task from Incoming to Done on the User-Ladsgroup board.Dec 28 2017, 10:58 PM
Ladsgroup moved this task from Review to Pending deployment on the Machine-Learning-Team (Active Tasks) board.
Ladsgroup moved this task from Pending deployment to Completed on the Machine-Learning-Team (Active Tasks) board.Jan 24 2018, 11:33 AM
awight mentioned this in Blog Post: Status Update (January 30, 2018).Jan 30 2018, 7:03 PM
Halfak closed this task as Resolved.Jan 30 2018, 8:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits