Language::formatNum() should always return a string
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Samwilson
	Dec 7 2017, 5:55 AM

Description

In some situations, calling Language::formatNum() with an integer gets you an integer in return. It should be a string.

Details

	Subject	Repo	Branch	Lines +/-
	Always return a string from Language::formatNum()	mediawiki/core	master	+28 -1

Customize query in gerrit

Related Objects

Mentioned In: T181669: ErrorException from line 118 in DisplayTitleHooks.php: PHP Warning: get_class() expects parameter 1 to be object, integer given

Event Timeline

Samwilson created this task.Dec 7 2017, 5:55 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 7 2017, 5:55 AM

Change 395878 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/core@master] Always return a string from Language::formatNum()

https://gerrit.wikimedia.org/r/395878

gerritbot added a project: Patch-For-Review.Dec 7 2017, 5:56 AM

Samwilson mentioned this in T181669: ErrorException from line 118 in DisplayTitleHooks.php: PHP Warning: get_class() expects parameter 1 to be object, integer given.Dec 7 2017, 5:58 AM

Samwilson claimed this task.Dec 7 2017, 6:02 AM

Legoktm edited projects, added MediaWiki-Internationalization; removed MediaWiki-General.Dec 7 2017, 6:04 AM

Change 395878 merged by jenkins-bot:
[mediawiki/core@master] Always return a string from Language::formatNum()

https://gerrit.wikimedia.org/r/395878

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)).Dec 7 2017, 7:00 AM

Samwilson closed this task as Resolved.Dec 7 2017, 7:12 AM

Language::formatNum() should always return a stringClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Language::formatNum() should always return a string
Closed, ResolvedPublic
Actions