Page MenuHomePhabricator
Create Task
Maniphest T183054

Wikidata autocomplete search does not truncate trailing spaces
Closed, ResolvedPublic
Actions

Description

Wikidata autocomplete search does not truncate trailing spaces, so that "John Smith " does not find the same things as "John Smith".

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Strip trailing spaces for some search clausesmediawiki/extensions/Wikibasemaster+345 -17
Customize query in gerrit

Related Objects
Search...

Event Timeline

Smalyshev created this task.Dec 16 2017, 9:11 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 16 2017, 9:11 AM
Smalyshev added a parent task: T46529: Wikidata search problems (tracking).Dec 16 2017, 9:12 AM
Lydia_Pintscher moved this task from incoming to monitoring on the Wikidata board.Dec 18 2017, 2:57 PM
Smalyshev moved this task from needs triage to Current work on the Discovery-Search board.Dec 19 2017, 9:17 PM
Smalyshev edited projects, added Discovery-Search (Current work); removed Discovery-Search.
gerritbot subscribed.Dec 19 2017, 9:40 PM

Change 399308 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[mediawiki/extensions/Wikibase@master] Strip trailing spaces for some search clauses

https://gerrit.wikimedia.org/r/399308

gerritbot added a project: Patch-For-Review.Dec 19 2017, 9:40 PM
Smalyshev claimed this task.Dec 19 2017, 10:59 PM
Smalyshev triaged this task as Medium priority.
Smalyshev moved this task from Incoming to Needs review on the Discovery-Search (Current work) board.
gerritbot added a comment.Dec 21 2017, 9:42 AM

Change 399308 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Strip trailing spaces for some search clauses

https://gerrit.wikimedia.org/r/399308

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)).Dec 21 2017, 10:00 AM
Smalyshev moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Jan 4 2018, 9:28 AM
Smalyshev closed this task as Resolved.Jan 5 2018, 10:17 PM

Verified, now "John Smith " matches The Doctor.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits