Page MenuHomePhabricator
Create Task
Maniphest T183083

Phan did not catch missing use statement in Wikibase patch
Closed, DeclinedPublic
Actions

Description

https://gerrit.wikimedia.org/r/#/c/394044/ was missing a use statement, causing a class not found error in a unit test. Why wasn't this caught by phan?

Event Timeline

Legoktm created this task.Dec 17 2017, 8:47 AM
Restricted Application added a project: Wikidata. · View Herald TranscriptDec 17 2017, 8:47 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Addshore added a comment.Dec 18 2017, 1:00 PM

Tests are not tested by phan in the wikibase config

https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/tests/phan/config.php#L79-L91

Legoktm removed a project: Continuous-Integration-Config.Dec 18 2017, 11:43 PM

:( OK this is something that needs to be fixed in Wikibase then.

Addshore added a project: MediaWiki-extensions-WikibaseRepository.Dec 21 2017, 11:12 AM
Legoktm closed this task as Declined.Sep 12 2018, 5:25 AM

I think running phan over tests/ is going to be a disaster due to mocking, TestingAccessWrapper, etc.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits