flake8 errors could be disabled.
The reason is that porting a whole file from compat all lines are tested but normally I fix differences to the core framework only. Using the new styles any code diff tools would show me a lot of changed lines and it is more difficult to verify the important changes. Maybe this is a minor prio request or we shouldn't care about this because most of scripts and modules are ported already.
Can we ignore the jenkins-bot's verification by manually changing the status to +1 or +2 and force the merge, or will it prevent the merge? (I've never tried)
If not, or if that's not a good enough solution, should we:
- Ignore any newly added file
- in the scripts directory
- when the word "compat" is in the commit message
? Is this a good enough heuristic?
@Dalba: I guess we could ignore bot's verification but have to submit the change manually to merge it to the repository but we shouldn't do it except in some unusal cases (maybe the bots don't work properly)
your suggested solution would be enough I think. or look for a pattern "# Automatically ported from compat branch by compat2core.py script"