Page MenuHomePhabricator

diff_checker should ignore new files when porting from compat
Closed, DeclinedPublic

Event Timeline

Xqt created this task.Dec 17 2017, 4:22 PM
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptDec 17 2017, 4:22 PM
Dalba added a comment.Dec 18 2017, 3:01 AM

Why shouldn't we fix them instead? Should we ignore flake8 errors, too?

Xqt added a comment.Dec 18 2017, 4:42 PM

flake8 errors could be disabled.

The reason is that porting a whole file from compat all lines are tested but normally I fix differences to the core framework only. Using the new styles any code diff tools would show me a lot of changed lines and it is more difficult to verify the important changes. Maybe this is a minor prio request or we shouldn't care about this because most of scripts and modules are ported already.

Dalba added a comment.Dec 18 2017, 5:51 PM

Can we ignore the jenkins-bot's verification by manually changing the status to +1 or +2 and force the merge, or will it prevent the merge? (I've never tried)

If not, or if that's not a good enough solution, should we:

  • Ignore any newly added file
  • in the scripts directory
  • when the word "compat" is in the commit message

? Is this a good enough heuristic?

Xqt added a comment.Jan 7 2018, 11:54 AM

@Dalba: I guess we could ignore bot's verification but have to submit the change manually to merge it to the repository but we shouldn't do it except in some unusal cases (maybe the bots don't work properly)

your suggested solution would be enough I think. or look for a pattern "# Automatically ported from compat branch by compat2core.py script"

Xqt triaged this task as Low priority.Jan 7 2018, 11:54 AM
jayvdb added a subscriber: jayvdb.Jan 7 2018, 12:11 PM

Which scripts are left to port from compat? Has anyone asked for them? If not, we're importing more maintenance work without any clear benefit.

Restricted Application added a subscriber: Zoranzoki21. · View Herald TranscriptMar 4 2018, 12:30 PM
Xqt closed this task as Declined.Mar 4 2018, 12:31 PM

According to my comment in T186465.

Dvorapa added a subscriber: Dvorapa.Mar 4 2018, 2:11 PM

offtopic, but I agree with @jayvdb: We should port only those someone requested or [are/want to be used] on some project. I ported ndashredir (and rewritten it a little bit), because I need it for some tasks on Czech Wikipedia. And I would suggest the same to others.