Maniphest T183769

ApiClearHasMsg doesn't have tests
Closed, ResolvedPublic
Actions

Description

In MediaWiki core, the ApiClearHasMsg module doesn't have any tests. It's a fairly simple module that clears the "you have new messages" flag for users. You will need to create a ApiClearHasMsg test case that implements tests for the module.

If you're not already familiar with PHPUnit tests, https://www.mediawiki.org/wiki/Manual:PHP_unit_testing/Writing_unit_tests has links to some good material on the basics of testing. I would also recommend looking at other tests in the tests/phpunit/includes/api directory of MediaWiki core for an example of how we currently test API modules.

I'll mentor this for Google-Code-in-2017

Details

	Subject	Repo	Branch	Lines +/-
	Add test for ApiClearHasMsg	mediawiki/core	master	+24 -0

Customize query in gerrit

Event Timeline

Legoktm created this task.Dec 29 2017, 9:07 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 29 2017, 9:07 AM

Thanks! Published as https://codein.withgoogle.com/tasks/4517424353247232/

Anomie moved this task from Unsorted to Needs Code on the MediaWiki-Action-API board.Dec 30 2017, 5:10 PM

I will add a test for this!

Change 401421 had a related patch set uploaded (by Phantom42; owner: Phantom42):
[mediawiki/core@master] Add tests for ApiClearHasMsg

https://gerrit.wikimedia.org/r/401421

gerritbot added a project: Patch-For-Review.Jan 2 2018, 2:59 AM

Change 401421 merged by jenkins-bot:
[mediawiki/core@master] Add test for ApiClearHasMsg

https://gerrit.wikimedia.org/r/401421

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)).Jan 2 2018, 6:00 AM

Legoktm closed this task as Resolved.Jan 4 2018, 7:05 AM