Page MenuHomePhabricator

service::node references $::restbase::port without including Class['restbase']
Closed, ResolvedPublic

Description

==> default: Warning: Unknown variable: '::restbase::port'. at /vagrant/puppet/modules/service/manifests/node.pp:99:22

One way to fix this would be to include ::restbase in service::node. Another would be to use <%= scope['::restabase::port'] %> in puppet/modules/service/templates/node/config.yaml.erb instead of the scoped variable in the define.

Event Timeline

bd808 created this task.Jan 1 2018, 5:04 AM
bd808 triaged this task as Normal priority.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 1 2018, 5:04 AM

Change 401376 had a related patch set uploaded (by Mobrovac; owner: Mobrovac):
[mediawiki/vagrant@master] service::node: Fix RESTBase port

https://gerrit.wikimedia.org/r/401376

mobrovac claimed this task.Jan 1 2018, 11:54 AM

Change 401400 had a related patch set uploaded (by BryanDavis; owner: Mobrovac):
[mediawiki/vagrant@stretch-migration] service::node: Fix RESTBase port

https://gerrit.wikimedia.org/r/401400

Change 401400 abandoned by BryanDavis:
service::node: Fix RESTBase port

https://gerrit.wikimedia.org/r/401400

Change 401400 restored by BryanDavis:
service::node: Fix RESTBase port

https://gerrit.wikimedia.org/r/401400

Change 401400 had a related patch set uploaded (by BryanDavis; owner: Mobrovac):
[mediawiki/vagrant@stretch-migration] service::node: Fix RESTBase port

https://gerrit.wikimedia.org/r/401400

Change 401400 merged by jenkins-bot:
[mediawiki/vagrant@stretch-migration] service::node: Fix RESTBase port

https://gerrit.wikimedia.org/r/401400

bd808 closed this task as Resolved.Jan 5 2018, 6:28 AM

Change 401376 abandoned by BryanDavis:
service::node: Fix RESTBase port

Reason:
Merged on stretch-migration branch (9960d5017d41ea591ba65c07fb45dc4b18c7983e)

https://gerrit.wikimedia.org/r/401376