Page MenuHomePhabricator

Block elements within inline elements reported as "Multiple unclosed formatting tags"
Closed, ResolvedPublic

Description

It seems block elements within inline elements show up as "Multiple unclosed formatting tags" lint error, which is misleading/confusing since the problem isn't actually an unclosed tag, and the solution doesn't involve adding/fixing the closing tag. See en:Template_talk:Infobox_road#Plainlist_in_length_notes and the following section for details, but basically

<br><small>{{plainlist|
*item 1
*item 2
*item 3
}}</small>

showed up as "Multiple unclosed formatting tags: <small>". The fix was

<div style='font-size:90%;'>{{plainlist|
*item 1
*item 2
*item 3
}}</div>

It would be less confusing if the lint error was something like "Block element nested within inline element: <small>"

Originally reported at en:Wikipedia talk:Linter#Block elements within inline elements.

Event Timeline

Evad37 created this task.Jan 2 2018, 8:54 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 2 2018, 8:54 AM
ssastry added a subscriber: ssastry.Jan 2 2018, 2:46 PM

Thanks. This is a false positive for the multiple-unclosed-formatting-tags category. Will suppress it.

Change 401515 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] T183893: Linter: Suppress multiple-unclosed-formatting-tags false positives

https://gerrit.wikimedia.org/r/401515

The "<br>" is required for this false positive to trigger.

ssastry claimed this task.Jan 2 2018, 3:05 PM

Change 401515 merged by jenkins-bot:
[mediawiki/services/parsoid@master] T183893: Linter: Suppress multiple-unclosed-formatting-tags false positives

https://gerrit.wikimedia.org/r/401515

ssastry closed this task as Resolved.Jan 12 2018, 11:42 PM
ssastry triaged this task as Normal priority.
ssastry edited projects, added Parsoid; removed Patch-For-Review.