⚓ T184142 Refactor Scoring.php

Subject	Repo	Branch	Lines +/-
Move mock ORESService into a new helper class	mediawiki/extensions/ORES	master	+53 -42
Tests for ScoreFetcher	mediawiki/extensions/ORES	master	+109 -4
Turn ORESService to a service and turn originalRequest to attribute	mediawiki/extensions/ORES	master	+79 -57
Rename and cleanup Scoring.php	mediawiki/extensions/ORES	master	+88 -37

Ladsgroup created this task.Jan 4 2018, 1:21 AM

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJan 4 2018, 1:21 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 401824 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/ORES@master] Rename and cleanup Scoring.php

https://gerrit.wikimedia.org/r/401824

gerritbot added a project: Patch-For-Review.Jan 4 2018, 1:21 AM

Change 401824 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Rename and cleanup Scoring.php

https://gerrit.wikimedia.org/r/401824

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)).Jan 4 2018, 2:00 AM

Needs more cleanup and integration tests. I hate originalRequest there, need to get rid of that.

Change 403384 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/ORES@master] Turn ORESService to a service and turn originalRequest to attribute

https://gerrit.wikimedia.org/r/403384

Ladsgroup moved this task from Parked to Review on the Machine-Learning-Team (Active Tasks) board.Jan 10 2018, 4:36 PM

Change 403384 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Turn ORESService to a service and turn originalRequest to attribute

https://gerrit.wikimedia.org/r/403384

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)); removed MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)).Jan 10 2018, 7:00 PM

Ladsgroup moved this task from Review to Pending deployment on the Machine-Learning-Team (Active Tasks) board.Jan 11 2018, 5:39 AM

Ladsgroup moved this task from Incoming to In progress on the User-Ladsgroup board.Jan 12 2018, 12:15 PM

Ladsgroup moved this task from Pending deployment to Review on the Machine-Learning-Team (Active Tasks) board.Jan 15 2018, 1:24 PM

Change 404290 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/ORES@master] Tests for ScoreFetcher

https://gerrit.wikimedia.org/r/404290

This patch is the last bit.

Change 404290 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Tests for ScoreFetcher

https://gerrit.wikimedia.org/r/404290

Change 404473 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/ORES@master] Move mock ORESService into a new helper class

https://gerrit.wikimedia.org/r/404473

Change 404473 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Move mock ORESService into a new helper class

https://gerrit.wikimedia.org/r/404473

Ladsgroup moved this task from Review to Pending deployment on the Machine-Learning-Team (Active Tasks) board.Jan 16 2018, 3:58 PM

Ladsgroup moved this task from In progress to Done on the User-Ladsgroup board.Jan 20 2018, 5:35 PM

Ladsgroup moved this task from Pending deployment to Completed on the Machine-Learning-Team (Active Tasks) board.Jan 24 2018, 11:33 AM

awight mentioned this in Blog Post: Status Update (January 30, 2018).Jan 30 2018, 7:03 PM

Halfak closed this task as Resolved.Jan 30 2018, 8:31 PM