5) role::wikimetrics should compile into a catalogue without dependency cycles
Failure/Error: it { is_expected.to compile }
error during compilation: Evaluation Error: Error while evaluating a Function Call, Failed to parse template wikimetrics/web_config.yaml.erb:
Filepath: /Users/bd808/projects/wmf/vagrant-disposable/puppet/modules/wikimetrics/templates/web_config.yaml.erb
Line: 13
Detail: no implicit conversion of Fixnum into String
at /Users/bd808/projects/wmf/vagrant-disposable/puppet/modules/wikimetrics/manifests/init.pp:238:20 on node wmf-bd808-mbp01.local
# ./puppet/spec/integration/roles_spec.rb:20:in `block (3 levels) in <top (required)>'Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| wikimetrics: remove role | mediawiki/vagrant | stretch-migration | +0 -116 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | bd808 | T181353 [EPIC] Migrate MediaWiki-Vagrant base image to Debian Stretch | |||
| Resolved | bd808 | T184154 role::wikimetrics should compile into a catalogue without dependency cycles |
Event Timeline
Comment Actions
This module has a lot more problems on Stretch:
$ git grep -l upstart manifests/init.pp manifests/queue.pp manifests/scheduler.pp manifests/web/daemon.pp templates/upstart.wikimetrics.conf.erb
The module used in production seems to be completely different now. It is not using a submodule any longer (rOPUPf79b15599407: Remove submodule wikimetrics).
Comment Actions
This must be unused on the current master (jessie) branch as well. Should we just drop the role until someone wants to come back and fix it all up again?
Comment Actions
Change 402606 had a related patch set uploaded (by BryanDavis; owner: Bryan Davis):
[mediawiki/vagrant@stretch-migration] wikimetrics: remove role
Comment Actions
Change 402606 merged by jenkins-bot:
[mediawiki/vagrant@stretch-migration] wikimetrics: remove role
Comment Actions
"Fixed" by dropping the role. It would be awesome to have this come back if and when folks are actually using it for development and testing.