Page MenuHomePhabricator
Create Task
Maniphest T184835

Deprecate OO.ui.now in favour of ES5 Date.now
Closed, ResolvedPublic
Actions

Description

I don't know if OOUI already requires ES5, but if it does, it might be a good time to deprecate OO.ui.now, simplify it to an alias for Date.now and update callers to call Date.now directly.

Event Timeline

Krinkle created this task.Jan 12 2018, 10:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 12 2018, 10:53 PM
Krinkle added a project: Technical-Debt (Deprecation process).Mar 19 2019, 9:06 PM

Screenshot 2019-03-19 at 21.06.21.png (150×932 px, 37 KB)

gerritbot subscribed.Mar 19 2019, 9:07 PM

Change 497615 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[oojs/ui@master] core: Remove unused Date.now fallback

https://gerrit.wikimedia.org/r/497615

gerritbot added a project: Patch-For-Review.Mar 19 2019, 9:07 PM
Krinkle moved this task from Untriaged to 2019 | MW 1.33 / 1.34 on the Technical-Debt (Deprecation process) board.Mar 19 2019, 9:07 PM
gerritbot added a comment.Mar 19 2019, 11:10 PM

Change 497615 merged by jenkins-bot:
[oojs/ui@master] [DEPRECATING CHANGE] core: Remove unused Date.now fallback

https://gerrit.wikimedia.org/r/497615

gerritbot added a comment.Mar 21 2019, 4:15 PM

Change 498143 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.31.1

https://gerrit.wikimedia.org/r/498143

gerritbot added a comment.Mar 22 2019, 7:13 PM

Change 498143 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.31.1

https://gerrit.wikimedia.org/r/498143

Jdforrester-WMF closed this task as Resolved.Mar 22 2019, 7:20 PM
Jdforrester-WMF assigned this task to Krinkle.
Jdforrester-WMF edited projects, added MW-1.33-notes (1.33.0-wmf.23; 2019-03-26); removed Patch-For-Review.
Jdforrester-WMF subscribed.

This patch landed in MediaWiki master in time for 1.33.0-wmf.23, which will go out to Wikimedia production from 2019-03-26.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits