Clean up ScoreLookup implementations
Closed, ResolvedPublic
Actions

Description

Right now, ScoreLookup interface has two implementations: 1- ScoreFetcher which gets scores from the ores service 2- SqlScoreLookup which looks up the scores from the database. The interface is designed with too much of knowledge about the implementation causing inconsistency between these two. ScoreFetcher::getScores needs to be cleaned (specially regarding usecases) and the interface needs to be adjusted.

Details

	Subject	Repo	Branch	Lines +/-
	Make ScoreFetcher and SqlScoreLookup implement different interfaces	mediawiki/extensions/ORES	master	+17 -29

Customize query in gerrit

Related Objects

Mentioned In: Blog Post: Status Update (May 2, 2018)

Event Timeline

Ladsgroup created this task.Jan 22 2018, 10:10 PM

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJan 22 2018, 10:10 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Ladsgroup moved this task from Incoming to In progress on the User-Ladsgroup board.Jan 27 2018, 11:50 AM

Change 406609 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/ORES@master] Make ScoreFetcher and SqlScoreLookup implement different interfaces

https://gerrit.wikimedia.org/r/406609

gerritbot added a project: Patch-For-Review.Jan 29 2018, 5:46 PM

Ladsgroup moved this task from Parked to Review on the Machine-Learning-Team (Active Tasks) board.Jan 29 2018, 5:46 PM

Change 406609 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Make ScoreFetcher and SqlScoreLookup implement different interfaces

https://gerrit.wikimedia.org/r/406609

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Jan 30 2018, 3:00 PM

awight moved this task from Review to Pending deployment on the Machine-Learning-Team (Active Tasks) board.Jan 30 2018, 5:39 PM

Did this get deployed?