Page MenuHomePhabricator

Transcode logging should also log the server on which the transcode process ran
Closed, ResolvedPublic

Description

Currently all transcoding jobs are logged to the transcode table. In case of an error, the error is logged to transcode_error, but there's no indication on which video scaler the error occurred.

That would be especially helpful for staged upgrades, e.g. when deploying a new ffmpeg release (e.g. for sec updates) where one canary server is upgraded ahead of the rest, as it would allow to monitor errors from that particular server.

Event Timeline

TheDJ triaged this task as Lowest priority.May 8 2019, 11:48 AM

Change #1018347 had a related patch set uploaded (by Bvibber; author: Bvibber):

[mediawiki/extensions/TimedMediaHandler@master] WIP transcode table updates

https://gerrit.wikimedia.org/r/1018347

Ive been thinking about this, do we really need a column for this ? We can just log it as a field in the error. Not pretty, but a lot less duplication of servernames.

Agreed that's probably easier and less spammy :) I'll adjust the patch in progress

[patch no longer addresses this with a column, separate patch will later in the error string]

Change #1020867 had a related patch set uploaded (by Bvibber; author: Bvibber):

[mediawiki/extensions/TimedMediaHandler@master] Include hostname in transcode error message

https://gerrit.wikimedia.org/r/1020867

Change #1020867 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] Include hostname in transcode error message

https://gerrit.wikimedia.org/r/1020867

closing as resolved, update should go out with next week's train and start applying on future ffmpeg failures