Thanks confirmation text does not wrap if longer than available space
Closed, DuplicatePublic
Actions

Assigned To

Authored By

	Ltrlg
	Feb 1 2018, 7:38 PM

Description

Example image is from frwiki:Histoire_des_maires_de_France.

Reproducing:

Using a medium-sized screen (mine has a 1366px width)
Enable JavaScript.
Log in to a wiki with Thanks enabled
Set interface language to French
Show a diff from a non-anonymous, non-bot user
click the “remercier” link (“thank”)
Wait for the nice animation to end.
The surface should now look like this:

Capture d’écran de 2018-02-01 20-18-13.png (268×608 px, 23 KB)

Expected behavior:
The text wraps so that I can click on any link.

Current behavior:
The end of the text is displayed outside the screen; I need to scroll horizontally in order to reach some links.

I think it should behave the same on any decent browser, given the existing CSS rules, but here is my UA string: "Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0"

Both I and Romainbehar have experienced this bug (reported by him offline).

((
This became worse for me recently because of a zoomed Timeless where I have to scroll even for the “yes” link:

Capture d’écran de 2018-02-01 20-32-29.png (343×716 px, 38 KB)

))

Details

	Subject	Repo	Branch	Lines +/-
	Wrap Thanks confirmation text when it exceeds the available space	mediawiki/extensions/Thanks	master	+9 -0

Customize query in gerrit

Related Objects

Mentioned Here: T159302: Rephrase confusing "thanks" message on diff page

Event Timeline

Ltrlg created this task.Feb 1 2018, 7:38 PM

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptFeb 1 2018, 7:38 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Aklapper added a project: CSS.Feb 5 2018, 3:08 PM

Trizek-WMF subscribed.Feb 6 2018, 7:17 PM

The text is liable to get longer in the near term because of T159302.

Trizek-WMF merged a task: T186166: Sometimes "thank user for this edit" JS link is hidden by the right column in diff previews.Feb 6 2018, 7:19 PM

Trizek-WMF added subscribers: Framawiki, Salix.

• jmatazzoni edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.Mar 6 2018, 8:18 PM

• jmatazzoni moved this task from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

Hagarshilo subscribed.Jun 19 2018, 4:31 PM

Change 441078 had a related patch set uploaded (by Hagar Shilo; owner: Hagar Shilo):
[mediawiki/extensions/Thanks@master] Wrap thanks confirmation text if longer than available space

https://gerrit.wikimedia.org/r/441078

gerritbot added a project: Patch-For-Review.Jun 19 2018, 6:22 PM

Hagarshilo moved this task from Ready for Pickup to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jun 19 2018, 6:25 PM

Hagarshilo claimed this task.Jun 26 2018, 9:13 AM

Hagarshilo moved this task from Needs Review to Code Review Started on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

matmarex closed this task as a duplicate of T111735: Non-breaking spaces break page layout when confirming thanks in diff view.Jun 29 2018, 11:50 PM

Change 441078 abandoned by Bartosz Dziewoński:

[mediawiki/extensions/Thanks@master] Wrap Thanks confirmation text when it exceeds the available space

Reason: