Some diffs are escaped thus appear in single line
http://www.mediawiki.org/wiki/Special:Code/MediaWiki/42010
I was unable to find the dependencies though :-/ - some diffs are OK, some are like this one.
Version: unspecified
Severity: major
Description
Description
Details
Details
- Reference
- bz16643
Event Timeline
Comment Actions
A null byte crept into the file in that diff, which seems to confuse the crap out of the particular json_decode implementation we happen to have live.
json_decode has the lovely behavior that sometimes, without easily being able to predict why, sometimes it returns your literal string, or... a slightly decoded literal string... instead of actually decoding it, if it's invalid, or sometimes if it seems to be valid but it doesn't like it, or wtf?
Anyway, I switched the proxy from using JSON to PHP serialization, and it just passes the string through correctly now. Whee!
r44643, r44644.