Page MenuHomePhabricator
Create Task
Maniphest T186494

jenkins-debian-glue should run the lintian version from cowbuilder instead of from host
Closed, ResolvedPublic
Actions

Description

When building a package for Stretch, lintian ends up complaining since we run the lintian version from the build hosts (Jessie). We should instead run the lintian version from the target distribution.

I did sent a couple patches upstream https://github.com/mika/jenkins-debian-glue/pull/191 only to find out someone else already did it already https://github.com/mika/jenkins-debian-glue/commit/e2beae591bada6a91ffd33a45e6c7a451dc33c3a

Need to rebuild our jenkins-debian-glue package 0.17.0 with that patch included.

Status

https://github.com/mika/jenkins-debian-glue/pull/193 is pending
Our Deb package 0.18.4-wmf2 has the patch included

Details

SubjectRepoBranchLines +/-
0.18.4-wmf2: add hook B90lintianoperations/debs/jenkins-debian-gluedebian/jessie-wikimedia+85 -0
0.18.4-wmf1: support process a lintian output fileoperations/debs/jenkins-debian-gluedebian/jessie-wikimedia+98 -1
Make debian-glue voting on debian-glue repointegration/configmaster+7 -1
support process a lintian output fileoperations/debs/jenkins-debian-gluepatch-queue/debian/jessie-wikimedia+25 -16
debian-glue: run lintian as a hookintegration/configmaster+24 -9
package_builder: ability to override HOOKDIRoperations/puppetproduction+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

hashar created this task.Feb 5 2018, 9:47 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 5 2018, 9:47 AM
Stashbot subscribed.Feb 5 2018, 9:48 AM

Mentioned in SAL (#wikimedia-releng) [2018-02-05T09:48:46Z] <hashar> operations/debs/jenkins-debian-glue create branches debian/jessie-wikimedia and patch-queue/debian/jessie-wikimedia based on v0.17.0 | T186494

gerritbot subscribed.Feb 5 2018, 9:49 AM

Change 408246 had a related patch set uploaded (by Hashar; owner: Victor Seva):
[operations/debs/jenkins-debian-glue@patch-queue/debian/jessie-wikimedia] support process a lintian output file

https://gerrit.wikimedia.org/r/408246

gerritbot added a project: Patch-For-Review.Feb 5 2018, 9:49 AM

Change 408247 had a related patch set uploaded (by Hashar; owner: Hashar):
[operations/debs/jenkins-debian-glue@debian/jessie-wikimedia] 0.17.0-wmf1: support process a lintian output file

https://gerrit.wikimedia.org/r/408247

hashar added a comment.Feb 5 2018, 9:55 AM

Rebuild using the same tarball we currently have on apt.wikimedia.org. Result on https://people.wikimedia.org/~hashar/debs/jenkins-debian-glue_0.17.0-wmf1/

hashar added a comment.Feb 5 2018, 10:49 AM

Our 0.17.0 original tarball includes upstream 0.17.0 and three other commits T141114#3945550

Will bump the version to latest tagged version.

hashar added a comment.Feb 5 2018, 10:58 AM

Build 0.18.4 using the upstream tarball and adding https://github.com/mika/jenkins-debian-glue/commit/e2beae591bada6a91ffd33a45e6c7a451dc33c3a

Result: https://people.wikimedia.org/~hashar/debs/jenkins-debian-glue_0.18.4-wmf1/

Stashbot added a comment.Feb 5 2018, 11:02 AM

Mentioned in SAL (#wikimedia-releng) [2018-02-05T11:02:31Z] <hashar> Upgrading jenkins-debian-glue to 0.18.4-wmf1 | T186494

Stashbot added a comment.Feb 5 2018, 11:04 AM

Mentioned in SAL (#wikimedia-operations) [2018-02-05T11:04:29Z] <hashar> Upgraded jenkins-debian-glue to 0.18.4-wmf1 | T186494

gerritbot added a comment.Feb 5 2018, 12:07 PM

Change 408261 had a related patch set uploaded (by Hashar; owner: Hashar):
[operations/debs/jenkins-debian-glue@debian/jessie-wikimedia] 0.18.4-wmf2: add hook B90lintian

https://gerrit.wikimedia.org/r/408261

gerritbot added a comment.Feb 5 2018, 1:15 PM

Change 408265 had a related patch set uploaded (by Hashar; owner: Hashar):
[operations/puppet@production] package_builder: ability to override HOOKDIR

https://gerrit.wikimedia.org/r/408265

gerritbot added a comment.Feb 5 2018, 1:24 PM

Change 408265 abandoned by Hashar:
package_builder: ability to override HOOKDIR

https://gerrit.wikimedia.org/r/408265

gerritbot added a comment.Feb 5 2018, 1:49 PM

Change 408268 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Run lintian has a hook

https://gerrit.wikimedia.org/r/408268

gerritbot added a comment.Feb 6 2018, 3:15 PM

Change 408268 merged by jenkins-bot:
[integration/config@master] debian-glue: run lintian as a hook

https://gerrit.wikimedia.org/r/408268

hashar claimed this task.Feb 6 2018, 3:15 PM
Restricted Application added a project: Release-Engineering-Team (Kanban). · View Herald TranscriptFeb 6 2018, 3:15 PM
hashar mentioned this in T186587: debian-glue lintian fails with: changes: bad-distribution-in-changes-file jessie-wikimedia.Feb 6 2018, 3:16 PM

Left to do: rebuild a jenkins-debian-glue Debian package

hashar moved this task from Backlog to In-progress on the Release-Engineering-Team (Kanban) board.Feb 7 2018, 2:34 PM
gerritbot added a comment.Feb 8 2018, 11:42 AM

Change 408246 merged by Hashar:
[operations/debs/jenkins-debian-glue@patch-queue/debian/jessie-wikimedia] support process a lintian output file

https://gerrit.wikimedia.org/r/408246

gerritbot added a comment.Feb 8 2018, 11:49 AM

Change 408999 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Make debian-glue voting on debian-glue repo

https://gerrit.wikimedia.org/r/408999

gerritbot added a comment.Feb 8 2018, 11:51 AM

Change 408999 merged by jenkins-bot:
[integration/config@master] Make debian-glue voting on debian-glue repo

https://gerrit.wikimedia.org/r/408999

gerritbot added a comment.Feb 8 2018, 11:54 AM

Change 408247 merged by jenkins-bot:
[operations/debs/jenkins-debian-glue@debian/jessie-wikimedia] 0.18.4-wmf1: support process a lintian output file

https://gerrit.wikimedia.org/r/408247

gerritbot added a comment.Feb 8 2018, 11:55 AM

Change 408261 merged by jenkins-bot:
[operations/debs/jenkins-debian-glue@debian/jessie-wikimedia] 0.18.4-wmf2: add hook B90lintian

https://gerrit.wikimedia.org/r/408261

hashar triaged this task as Medium priority.Feb 8 2018, 11:57 AM

Rebuild at https://people.wikimedia.org/~hashar/debs/jenkins-debian-glue_0.18.4-wmf2/

hashar mentioned this in T186786: Upload new zuul and jenkins-debian-glue packages to apt.wikimedia.org.Feb 8 2018, 12:08 PM
hashar added a subtask: T186786: Upload new zuul and jenkins-debian-glue packages to apt.wikimedia.org.
hashar moved this task from In-progress to Done (within RelEng) on the Release-Engineering-Team (Kanban) board.Feb 8 2018, 12:10 PM
hashar moved this task from Untriaged to Externally Blocked on the Continuous-Integration-Infrastructure board.
hashar mentioned this in T187405: jenkins-debian-glue is failing for unstable.Feb 15 2018, 7:51 AM
hashar moved this task from Done (within RelEng) to Blocked (externally) on the Release-Engineering-Team (Kanban) board.Mar 26 2018, 4:37 PM
hashar moved this task from Blocked (externally) to Done (within RelEng) on the Release-Engineering-Team (Kanban) board.
akosiaris closed subtask T186786: Upload new zuul and jenkins-debian-glue packages to apt.wikimedia.org as Resolved.Apr 4 2018, 8:27 AM
hashar changed the task status from Open to Stalled.Apr 4 2018, 8:43 AM
hashar updated the task description. (Show Details)
hashar edited projects, added Upstream; removed Patch-For-Review.

Pending upstream review/merge/release

hashar moved this task from Backlog to Patch proposed upstream on the Upstream board.Apr 4 2018, 8:43 AM
hashar added a parent task: T193906: debian-glue errors out with: hooks/B90lintian: line 21: realpath: command not found.Jan 2 2019, 11:05 AM
hashar mentioned this in T212774: Upgrade jenkins-debian-glue to v0.20.0.Jan 17 2019, 8:54 AM
hashar added a subtask: T212774: Upgrade jenkins-debian-glue to v0.20.0.
hashar added a comment.Mar 19 2019, 8:35 PM

The patch made it in v0.20.0 and it has been / is being deployed via T212774

hashar closed this task as Resolved.Mar 22 2019, 11:18 PM
hashar closed subtask T212774: Upgrade jenkins-debian-glue to v0.20.0 as Resolved.

It took a while to get it released by upstream and get the latest version available on apt.wikimedia.org and deploy. But finally that is done

antoine-approve

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL