Page MenuHomePhabricator
Create Task
Maniphest T186531

Visual editor gives erroneous warning about missing edit summary when switching editing modes
Open, HighPublic1 Estimated Story PointsBUG REPORT
Actions

Description

Reproduction steps:

  1. Turn on the Prompt me when entering a blank edit summary preference.
  2. Start editing a page in either editing mode (i.e. visual or source).
  3. Make some change to the text.
  4. Provide an edit summary.
  5. Switch to the other editing mode. Result: My edit summary is still filled in. [OK]
  6. Make another change to the text.
  7. Click Publish changes. Result: Warning "Reminder: You have not provided an edit summary...." is displayed. [BUG]
  8. Click Publish changes again. Result: My edit summary is saved together with the edit. [OK]

Possibly related to T144906.

Version: 1.41.0-wmf.1 (4de0415) at cs.wikipedia.org

Related Objects

Event Timeline

RoySmith created this task.Feb 5 2018, 3:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 5 2018, 3:42 PM
RoySmith renamed this task from Visual editor gives erroneous warning about missing edit summary when switch editing modes to Visual editor gives erroneous warning about missing edit summary when switching editing modes.Feb 5 2018, 3:43 PM
Kizule added a project: VisualEditor.Feb 5 2018, 9:54 PM
• Deskana triaged this task as Low priority.EditedFeb 13 2018, 7:52 PM
• Deskana set the point value for this task to 1.
• Deskana moved this task from To Triage to TR1: Releases on the VisualEditor board.
• Deskana subscribed.

Note that this does not occur if you are opted into the 2017 wikitext editor beta feature; this prevented me from reproducing the problem at first. You also need the "Prompt me when entering a blank edit summary" preference turned on.

• Deskana moved this task from TR1: Releases to Freezer on the VisualEditor board.Aug 17 2018, 10:08 AM
Tkarcher subscribed.Jul 31 2020, 8:58 PM

Reported again in https://de.wikipedia.org/wiki/Wikipedia:Technik/Text/Edit/VisualEditor/R%C3%BCckmeldungen#Bearbeitungskommentar

(same behaviour / bug as described above)

Tacsipacsi changed the subtype of this task from "Task" to "Bug Report".Jan 20 2021, 6:05 PM
Tacsipacsi subscribed.
petr.matas awarded a token.Mar 28 2023, 11:18 AM
petr.matas raised the priority of this task from Low to High.EditedMar 28 2023, 11:23 AM
petr.matas subscribed.

Everytime I switch the editing mode, I get the missing edit summary warning upon clicking Publish, even though I provided the summary before the switch. It is quite annoying and what is worse, it teaches me to ingore the warning.

petr.matas updated the task description. (Show Details)Mar 28 2023, 11:45 AM
petr.matas added a comment.Mar 28 2023, 11:48 AM

I have updated the task decription according to my experience. In case of being unable to reproduce the bug, please see the previous version of the description.

petr.matas updated the task description. (Show Details)Mar 28 2023, 11:54 AM
petr.matas updated the task description. (Show Details)Mar 28 2023, 11:58 AM
petr.matas updated the task description. (Show Details)Mar 28 2023, 12:13 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL