Page MenuHomePhabricator

SocialProfile errors when removing a gift
Closed, ResolvedPublic

Description

When removing a gift an error is thrown.

[1c916c388a6f60e87e654891] /index.php?title=Special:RemoveGift&gift_id=10 Error from line 86 of /var/www/html/extensions/SocialProfile/UserGifts/SpecialRemoveGift.php: Call to a member function addHTML() on string

Backtrace:

#0 /var/www/html/includes/specialpage/SpecialPage.php(522): RemoveGift->execute(NULL)
#1 /var/www/html/includes/specialpage/SpecialPageFactory.php(578): SpecialPage->run(NULL)
#2 /var/www/html/includes/MediaWiki.php(287): SpecialPageFactory::executePath(Title, RequestContext)
#3 /var/www/html/includes/MediaWiki.php(851): MediaWiki->performRequest()
#4 /var/www/html/includes/MediaWiki.php(523): MediaWiki->main()
#5 /var/www/html/index.php(43): MediaWiki->run()
#6 {main}

To reproduce:
Install PHP 7.1 and MediaWiki 1.30
Install SocialProfile
Create a main account and a test account.
Make sure the accounts have each other added as friends
Send a gift from the test account to the main account.
From the main account try to remove the gift
It fails with the above error.

Environment
PHP 7.1
MediaWiki 1.30
SocialProfile at latest commit on master branch.

Event Timeline

Restricted Application added a project: User-MacFan4000. · View Herald TranscriptFeb 6 2018, 11:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Restricted Application added a project: Social-Tools. · View Herald TranscriptFeb 6 2018, 11:39 PM

Change 409313 had a related patch set uploaded (by Jack Phoenix; owner: Jack Phoenix):
[mediawiki/extensions/SocialProfile@master] Fix E_FATAL when removing a gift

https://gerrit.wikimedia.org/r/409313

Change 409313 merged by jenkins-bot:
[mediawiki/extensions/SocialProfile@master] Fix E_FATAL when removing a gift

https://gerrit.wikimedia.org/r/409313

SamanthaNguyen closed this task as Resolved.Feb 9 2018, 10:35 PM
SamanthaNguyen assigned this task to ashley.
SamanthaNguyen triaged this task as Normal priority.
SamanthaNguyen removed a project: Patch-For-Review.
SamanthaNguyen moved this task from Backlog to Bugs on the SocialProfile board.
SamanthaNguyen removed a subscriber: gerritbot.