Page MenuHomePhabricator

exclamation mark on RC
Closed, ResolvedPublic

Description

Author: danny.leinad

Description:
On Special:RecentChanges pages from namespaces without FlaggedRevs appear with a red exclamation marks. A few days ago exclamation marks appears only with allowed namespaces of reviewable pages ($wgFlaggedRevsNamespaces).

Now RC are illegible.

I propose restore changes.


Version: unspecified
Severity: enhancement

Details

Reference
bz16724

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:26 PM
bzimport set Reference to bz16724.

danny.leinad wrote:

pl.wiki

We allow for reviewing only articles and templates, but now red exclamation marks also appears with category, user namespace etc.

danny.leinad wrote:

I'm not sure is it works fine...

On http://tools.wikimedia.pl/~leinad/testwiki I've got the same configuration of FlaggedRevs like on pl.wiki and I've just downloaded from SVN the latest revision of FR. Red exclamation marks still appears with not allowed namespaces of reviewable pages.

And second problem:
On RC and Watchlist filters have got wrong titels: "Hide/Show patrolled edits" -> "Hide/Show reviewed edits".

This is not retroactive.

New edits out of patrollable namespaces are automatically marked as patrolled, so they don't have marks on recent changes. Edits that already have been made would need a script to set rc_patrolled=1 to remove the marks. Either way, they will fall out of rotation like all RC items do as they get old.

Site synced. New RC items should not have ! marks.

danny.leinad wrote:

Ok, new edits out of patrollable namespaces are automatically marked as patrolled, but created new pages still appears with ! marks.

Examples:
(różn.) (hist.) . . N! Wikipedysta:Vol de nuit‎; 01:32:02 . . (+49) . . Vol de nuit (dyskusja | edycje | zablokuj) (Nowa strona: Wikipédia France)

(różn.) (hist.) . . N! Kategoria:Ludzie związani z Wojskiem Polskim‎; 01:32:13 . . (+52) . . Poznaniak1975 (dyskusja | edycje | zablokuj) (Nowa strona: Kategoria:Biografie Kategoria:Wojsko Polskie)

And can you improve on RC and Watchlist name of filter: "Hide/Show patrolled edits" to "Hide/Show reviewed edits"?

wgUseNPPatrol is on by default, so new pages will still start off with ! marks.

A reviewed edit is also "patrol", so to speak, so I'm not to worried about "Hide/Show patrolled edits". You can go to special::allmessages to change it though (well, a Sysop can).

danny.leinad wrote:

IMHO $wgUseNPPatrol should has got value 'false' when wiki enable FlaggedRevs.

When community decide enable FR, they discuss what namespaces they want checking for vandalism. Not allowed namespaces are not improtant, so there's no use to marking new pages as patrolled.

(In reply to comment #9)

IMHO $wgUseNPPatrol should has got value 'false' when wiki enable FlaggedRevs.

When community decide enable FR, they discuss what namespaces they want
checking for vandalism. Not allowed namespaces are not improtant, so there's no
use to marking new pages as patrolled.

If it annoys you, you can always try to get community consensus to get $wgUseNPPatrol disabled.