Page MenuHomePhabricator

Kartotherian is sending wrong etags and last-modified headers
Closed, ResolvedPublic

Description

etags and last-modified headers sent by Kartotherian are problematic:

  • etags is inconsistent between nodes, which might lead to more cache miss than needed
  • last-modified is always epoch(0) (january 1st 1970) which leads to tiles not being invalidated when they should be

Both could just be dropped.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Note that this is somewhat related to T186732 and T108435

Change 421522 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[operations/puppet@production] kartotherian/tilerator: set Last-Modified header

https://gerrit.wikimedia.org/r/421522

etags is inconsistent between nodes, which might lead to more cache miss than needed

I'm not sure what this means or if it's still true. I've tested maps-test2001, maps-test2002 and maps-test2003 for a specific tile (osm-intl/13/4284/2883.png) and all 3 returned the same ETag ("c3346c8890d85d6585b0ef5a7aca0410").

The ETag logic in tilelive-vector looks sane as long as a upstream source provides an etag as well. I've submitted https://github.com/kartotherian/cassandra/pull/5 to do just that in the cassandra source.

Change 421522 abandoned by Sbisson:
kartotherian/tilerator: set Last-Modified header

https://gerrit.wikimedia.org/r/421522