Close button for value popup when editing statements in Wikidata is positioned incorrectly with RTL UI
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Amire80
	Feb 15 2018, 1:45 PM

Description

To reproduce:

Switch Wikidata to Hebrew UI.
Go to https://www.wikidata.org/wiki/Q6639514
Scroll to birth date (P569, "תאריך לידה").
Add value (הוספת ערך).
Type the date.

Expected: The close button (X, class="ui-icon-close") must be on the left-hand side of the box.

Observed: The close button appears on the right-hand side of the box and overlaps the "will be displayed as" label (הצג בתור). See screenshot:

צילום מסך 2018.02.15 ב.15.42.20.png (826×2 px, 102 KB)

This affects all datatypes which have a popup value box with a close button: Dates, monolingual text, coordinates, quantities

Related Objects

Duplicates Merged Here: T290466: Wikidata coordinate editor - X button appears on the wrong side for RTL

Event Timeline

Amire80 created this task.Feb 15 2018, 1:45 PM

Restricted Application added a project: I18n. · View Herald TranscriptFeb 15 2018, 1:45 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Amire80 moved this task from Untriaged to RTL on the I18n board.Feb 15 2018, 1:53 PM

YonaB subscribed.Feb 15 2018, 3:21 PM

Nikki renamed this task from In Wikidata, the placement of the close button date input box is placed incorrectly with RTL UI to Close button for value popup when editing statements in Wikidata is positioned incorrectly with RTL UI.Feb 6 2023, 12:54 AM

Nikki updated the task description. (Show Details)

Restricted Application added a project: [DEPRECATED] wdwb-tech. · View Herald TranscriptFeb 6 2023, 12:54 AM

Nikki merged a task: T290466: Wikidata coordinate editor - X button appears on the wrong side for RTL.Feb 6 2023, 12:55 AM

Nikki added a subscriber: eranroz.

The problem is lines 42-45 here: https://github.com/wikimedia/data-values-value-view/blob/master/lib/jquery.ui/jquery.ui.inputextender.css#L42-L45

CSSJanus already handles flipping the values, so line 23 is turned into left: 0 for RTL languages and then these lines unflip it again. Either lines 42-45 should be removed, or /* @noflip */ should be added for lines 23, 43 and 44 (depending on whether this code is supposed to be usable without CSSJanus or not).

I've added some CSS to Wikidata's common.css (diff) to make it display properly. Once this has been fixed, it can be removed again.

	F13768498: צילום מסך 2018.02.15 ב.15.42.20.png
	Feb 15 2018, 1:45 PM

Close button for value popup when editing statements in Wikidata is positioned incorrectly with RTL UIOpen, Needs TriagePublicActions

Description

Related Objects

Event Timeline

Close button for value popup when editing statements in Wikidata is positioned incorrectly with RTL UI
Open, Needs TriagePublic
Actions