Page MenuHomePhabricator
Create Task
Maniphest T187713

Avoid jQuery.parseHTML
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Using $( '<div attr="val">' ) is many times slower than $( '<div>' ).attr( 'attr', 'val' ) according to https://jsperf.com/parse-html-vs-set-attributes-vs-jq-options

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (8c5b27028)mediawiki/extensions/VisualEditormaster+1 -1
Avoid jQuery.parseHTMLVisualEditor/VisualEditormaster+42 -37
Avoid jQuery.parseHTMLmediawiki/extensions/VisualEditormaster+4 -4
Avoid jQuery.parseHTMLmediawiki/extensions/Citemaster+5 -4
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Feb 19 2018, 12:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 19 2018, 12:18 PM
gerritbot subscribed.Feb 19 2018, 12:20 PM

Change 412681 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Cite@master] Avoid jQuery.parseHTML

https://gerrit.wikimedia.org/r/412681

gerritbot added a project: Patch-For-Review.Feb 19 2018, 12:20 PM
gerritbot added a comment.Feb 19 2018, 1:51 PM

Change 412700 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Avoid jQuery.parseHTML

https://gerrit.wikimedia.org/r/412700

gerritbot added a comment.Feb 19 2018, 3:41 PM

Change 412724 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Avoid jQuery.parseHTML

https://gerrit.wikimedia.org/r/412724

gerritbot added a comment.Feb 20 2018, 12:49 AM

Change 412681 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] Avoid jQuery.parseHTML

https://gerrit.wikimedia.org/r/412681

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)).Feb 20 2018, 1:01 AM
• Deskana assigned this task to Esanders.Feb 20 2018, 12:50 PM
• Deskana triaged this task as Medium priority.
• Deskana set the point value for this task to 1.
• Deskana moved this task from To Triage to Current work on the VisualEditor board.
• Deskana edited projects, added VisualEditor (Current work); removed VisualEditor.
• Deskana moved this task from Incoming to In progress on the VisualEditor (Current work) board.
gerritbot added a comment.Feb 20 2018, 4:50 PM

Change 412724 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Avoid jQuery.parseHTML

https://gerrit.wikimedia.org/r/412724

gerritbot added a comment.Feb 20 2018, 5:08 PM

Change 412700 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Avoid jQuery.parseHTML

https://gerrit.wikimedia.org/r/412700

gerritbot added a comment.Feb 20 2018, 5:18 PM

Change 412958 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (8c5b27028)

https://gerrit.wikimedia.org/r/412958

gerritbot added a comment.Feb 20 2018, 5:47 PM

Change 412958 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (8c5b27028)

https://gerrit.wikimedia.org/r/412958

Jdforrester-WMF moved this task from In progress to Product owner review on the VisualEditor (Current work) board.Feb 20 2018, 6:41 PM
Jdforrester-WMF removed a project: Patch-For-Review.Feb 20 2018, 6:58 PM
• Deskana closed this task as Resolved.Feb 22 2018, 11:42 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits