Page MenuHomePhabricator
Create Task
Maniphest T187791

Strip .pdf from arxiv identifiers before adding them
Closed, ResolvedPublic
Actions

Description

See https://en.wikipedia.org/w/index.php?title=Insertion_sort&diff=826540785&oldid=823450699 and https://en.wikipedia.org/w/index.php?title=Many-worlds_interpretation&type=revision&diff=826183381&oldid=825333139

In both cases, the bot adds something like "| arxiv = quant-ph/0211138v2.pdf", when it should just be " | arxiv = quant-ph/0211138v2", without the .pdf at the end

Related Objects

Event Timeline

Headbomb created this task.Feb 20 2018, 3:29 PM
Headbomb renamed this task from Strip .pdg from arxiv identifiers before adding them to Strip .pdf from arxiv identifiers before adding them.Feb 20 2018, 3:31 PM
Nemo_bis triaged this task as Medium priority.Apr 21 2018, 8:57 AM
Nemo_bis mentioned this in T163903: Detect if link ultimately goes to arxiv, and use arxiv link/parameter instead.
Nemo_bis subscribed.Apr 21 2018, 9:54 AM

I'm not sure if https://github.com/dissemin/oabot/commit/5361bf122c27ac6220fc113e1a3767fe7773f62b has been deployed already when this bug has been observed.

Headbomb added a comment.Apr 21 2018, 11:50 AM

It's not deployed now:

Nemo_bis closed this task as Resolved.Apr 30 2018, 10:44 AM
Nemo_bis claimed this task.

The problem with (.*)(.pdf)? is that the second part is optional while the first is greedy.

Let's just follow the identifier format: https://arxiv.org/help/arxiv_identifier
After https://github.com/dissemin/oabot/commit/de27de3fc40657ad2495cd892ab52576864ba8d5 , the edits look right.

Nemo_bis added a subscriber: Pintoch.May 7 2018, 5:39 AM

@Pintoch Was this edit made with the latest code/regex? https://en.wikipedia.org/w/index.php?title=Plasma_acceleration&diff=prev&oldid=839956715

Pintoch added a comment.May 7 2018, 6:00 AM

@Nemo_bis that's probably because the edits were cached and generated by an earlier version

Nemo_bis added a comment.May 7 2018, 6:23 AM
In T187791#4185633, @Pintoch wrote:

@Nemo_bis that's probably because the edits were cached and generated by an earlier version

Ah ok. Can I just run sed over the cache or are you working on an alternative fix?

Pintoch added a comment.May 7 2018, 6:28 AM

I won't work on this for the next 2 weeks, the floor is yours!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL