Page MenuHomePhabricator
Create Task
Maniphest T187917

Template autocomplete absent on wikis without TemplateData
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

On a wiki without TemplateData, the autocomplete in MWTemplateTitleInputWidget completely fails to work.

The only thing that TemplateData's API is being used for is getting the template descriptions, so we should at least have the name completion still working.

Details

SubjectRepoBranchLines +/-
MWTemplateTitleInputWidget: recover gracefully if TemplateData not presentmediawiki/extensions/VisualEditormaster+3 -0
Customize query in gerrit

Event Timeline

DLynch created this task.Feb 21 2018, 5:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 21 2018, 5:51 PM
DLynch moved this task from To Triage to Current work on the VisualEditor board.Feb 21 2018, 5:52 PM
DLynch edited projects, added VisualEditor (Current work); removed VisualEditor.
DLynch moved this task from Incoming to In progress on the VisualEditor (Current work) board.
gerritbot subscribed.Feb 21 2018, 5:54 PM

Change 413210 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] MWTemplateTitleInputWidget: recover gracefully if TemplateData not present

https://gerrit.wikimedia.org/r/413210

gerritbot added a project: Patch-For-Review.Feb 21 2018, 5:54 PM
DLynch moved this task from In progress to Code review on the VisualEditor (Current work) board.Feb 21 2018, 5:54 PM
gerritbot added a comment.Feb 21 2018, 6:14 PM

Change 413210 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] MWTemplateTitleInputWidget: recover gracefully if TemplateData not present

https://gerrit.wikimedia.org/r/413210

Jdforrester-WMF moved this task from Code review to Product owner review on the VisualEditor (Current work) board.Feb 21 2018, 6:15 PM
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)).Feb 21 2018, 7:00 PM
• Deskana closed this task as Resolved.Feb 22 2018, 4:31 PM
• Deskana triaged this task as Medium priority.
• Deskana added a project: TemplateData.
• Deskana set the point value for this task to 1.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits