...including exceptions. They are not terribly useful right now.
Description
Description
Details
Details
Related Changes in Gerrit:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | Tgr | T434294 [Hypothesis] PP3.5.4 OAuth Modernization | |||
| Open | Tgr | T418692 Epic: Improve observability of OAuth | |||
| Open | None | T157850 Interacting with Wikimedia logs should be a pleasant experience | |||
| Resolved | Tgr | T332663 Create an OAuth error dashboard | |||
| Resolved | • matmarex | T188848 All OAuth Logstash logs should include the consumer key |
Event Timeline
Comment Actions
This was mostly done in rEOAUa17a9abf248f: Log additional error details. Not done for exceptions that originate in a library (OAuthException as opposed to MWOAuthException for OAuth 1; not sure how much the OAuth 2 library uses exceptions) but I think those are relatively rare.
Comment Actions
Change #1310224 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/OAuth@master] Update all ->info() and ->warning() calls with consistent consumer info
Comment Actions
Change #1310226 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/OAuth@master] Make MWOAuthException log consistent consumer info
Comment Actions
I reviewed all uses of ->info() and ->warning() for logging (which are the only log levels I see logged in production), and all uses of new MWOAuthException, and added consistent log context to them (using a new method on Consumer) whenever we have a Consumer object already available or can easily fetch it. I think this is thorough enough that we'll be able to confidently close this task.
Comment Actions
Change #1310224 merged by jenkins-bot:
[mediawiki/extensions/OAuth@master] Update all ->info() and ->warning() calls with consistent consumer info
Comment Actions
Change #1310226 merged by jenkins-bot:
[mediawiki/extensions/OAuth@master] Make MWOAuthException log consistent consumer info