Page MenuHomePhabricator
Create Task
Maniphest T190575

Remove unused $useHeadElement property from skins
Closed, ResolvedPublic
Actions

Description

The history file of mediawiki/core contains the following sentence:

* BREAKING CHANGE: Skins built for MediaWiki 1.15 and earlier that do not use
  the "headelement" template key are no longer supported. Setting
  $useHeadElement = false; is no longer supported and will not cause old keys
  like "headlinks", "skinnameclass", etc. to be defined.

But many skins setting this property, which is unused and should be removed.

https://codesearch.wmflabs.org/search/?q=useHeadElement&i=nope&files=&repos=

Details

SubjectRepoBranchLines +/-
Remove unused $useHeadElement property from skinsmediawiki/skins/Truglassmaster+1 -1
Remove unused $useHeadElement property from skinsmediawiki/skins/WPtouchmaster+1 -1
Remove unused $useHeadElement property from skinsmediawiki/skins/Timelessmaster+1 -1
Remove unused $useHeadElement property from skinsmediawiki/skins/Refreshedmaster+0 -1
Remove unused $useHeadElement property from skinsmediawiki/skins/webplatformmaster+1 -2
Remove unused $useHeadElement property from skinsmediawiki/skins/p2wikimaster+1 -1
Remove unused $useHeadElement property from skinsmediawiki/skins/mediawiki-strappingmaster+1 -1
Remove unused $useHeadElement property from skinsmediawiki/skins/eruditemaster+1 -1
Remove unused $useHeadElement property from skinsmediawiki/skins/apexmaster+1 -1
Remove unused $useHeadElement property from skinsmediawiki/skins/WoOgLeShadesmaster+1 -1
Remove unused $useHeadElement property from skinsmediawiki/skins/Synagonismmaster+1 -1
Remove unused $useHeadElement property from skinsmediawiki/skins/BlueSkymaster+1 -1
Remove unused $useHeadElement property from skinsmediawiki/skins/Splashmaster+1 -1
Remove unused $useHeadElement property from skinsmediawiki/skins/Materialmaster+1 -2
Remove unused $useHeadElement property from skinsmediawiki/skins/Maskmaster+1 -1
Remove unused $useHeadElement property from skinsmediawiki/skins/HasSomeColoursmaster+1 -1
Remove unused $useHeadElement property from skinsmediawiki/skins/GreyStuffmaster+1 -1
Remove unused $useHeadElement property from skinsmediawiki/skins/Gamepressmaster+1 -1
Remove unused $useHeadElement property from skinsmediawiki/skins/DeskMessMirroredmaster+1 -1
Remove unused $useHeadElement property from skinsmediawiki/skins/BlueSpiceSkinmaster+0 -1
Remove unused $useHeadElement property from skinsmediawiki/skins/Duskmaster+1 -1
Remove unused $useHeadElement property from skinsmediawiki/skins/DuskToDawnmaster+1 -1
Remove unused $useHeadElement property from skinsmediawiki/skins/Daddiomaster+1 -1
Remove unused $useHeadElement property from skinsmediawiki/skins/Bouquetmaster+1 -1
Remove unused $useHeadElement property from skinsmediawiki/skins/Nimbusmaster+1 -1
Remove unused $useHeadElement property from skinsmediawiki/skins/Examplemaster+1 -1
Remove unused $useHeadElement property from skinsmediawiki/skins/MinervaNeuemaster+0 -2
Show related patches Customize query in gerrit

Related Objects

Event Timeline

Umherirrender created this task.Mar 23 2018, 9:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 23 2018, 9:07 PM
Kizule claimed this task.Mar 26 2018, 4:42 AM
Kizule subscribed.

I will take this.

Restricted Application added a project: User-Kizule. · View Herald TranscriptMar 26 2018, 4:42 AM
Kizule triaged this task as Medium priority.Mar 26 2018, 8:26 PM

For tomorrow.

Kizule added a comment.Mar 27 2018, 3:13 PM
In T190575#4082261, @Zoranzoki21 wrote:

For tomorrow.

I starting now with working on this. @Umherirrender Please review and deploy patches when you have free time.

gerritbot subscribed.Mar 27 2018, 3:19 PM

Change 422170 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/skins/MinervaNeue@master] Remove unused $useHeadElement property from skins

https://gerrit.wikimedia.org/r/422170

gerritbot added a project: Patch-For-Review.Mar 27 2018, 3:19 PM
gerritbot added a comment.Mar 27 2018, 3:23 PM

Change 422171 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/skins/BlueSky@master] Remove unused $useHeadElement property from skins

https://gerrit.wikimedia.org/r/422171

Kizule moved this task from Backlog to Doing on the good first task board.Mar 27 2018, 4:08 PM
gerritbot added a comment.Mar 27 2018, 5:08 PM

Change 422170 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Remove unused $useHeadElement property from skins

https://gerrit.wikimedia.org/r/422170

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)).Mar 27 2018, 6:00 PM
Kizule added a comment.EditedMar 27 2018, 6:55 PM

https://gerrit.wikimedia.org/r/#/c/422212/
https://gerrit.wikimedia.org/r/#/c/422214/

gerritbot added a comment.Mar 27 2018, 7:09 PM

Change 422225 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/skins/Gamepress@master] Remove unused $useHeadElement property from skins

https://gerrit.wikimedia.org/r/422225

gerritbot added a comment.Mar 27 2018, 7:12 PM

Change 422223 merged by jenkins-bot:
[mediawiki/skins/Example@master] Remove unused $useHeadElement property from skins

https://gerrit.wikimedia.org/r/422223

gerritbot added a comment.Mar 27 2018, 7:13 PM

Change 422212 merged by jenkins-bot:
[mediawiki/skins/Nimbus@master] Remove unused $useHeadElement property from skins

https://gerrit.wikimedia.org/r/422212

gerritbot added a comment.Mar 27 2018, 7:32 PM

Change 422214 merged by jenkins-bot:
[mediawiki/skins/Bouquet@master] Remove unused $useHeadElement property from skins

https://gerrit.wikimedia.org/r/422214

gerritbot added a comment.Mar 27 2018, 7:32 PM

Change 422216 merged by jenkins-bot:
[mediawiki/skins/Daddio@master] Remove unused $useHeadElement property from skins

https://gerrit.wikimedia.org/r/422216

gerritbot added a comment.Mar 27 2018, 7:32 PM

Change 422221 merged by jenkins-bot:
[mediawiki/skins/DuskToDawn@master] Remove unused $useHeadElement property from skins

https://gerrit.wikimedia.org/r/422221

gerritbot added a comment.Mar 27 2018, 7:32 PM

Change 422220 merged by jenkins-bot:
[mediawiki/skins/Dusk@master] Remove unused $useHeadElement property from skins

https://gerrit.wikimedia.org/r/422220

Kizule added a comment.Mar 27 2018, 7:37 PM

All is done. You can deploy patches: https://gerrit.wikimedia.org/r/#/q/topic:T190575+status:open (open, no merged or is queued for it)

Full (open + merged) https://gerrit.wikimedia.org/r/#/q/topic:T190575

gerritbot added a comment.Mar 27 2018, 7:43 PM

Change 422232 merged by jenkins-bot:
[mediawiki/skins/BlueSpiceSkin@master] Remove unused $useHeadElement property from skins

https://gerrit.wikimedia.org/r/422232

gerritbot added a comment.Mar 27 2018, 7:43 PM

Change 422218 merged by jenkins-bot:
[mediawiki/skins/DeskMessMirrored@master] Remove unused $useHeadElement property from skins

https://gerrit.wikimedia.org/r/422218

gerritbot added a comment.Mar 27 2018, 7:43 PM

Change 422225 merged by jenkins-bot:
[mediawiki/skins/Gamepress@master] Remove unused $useHeadElement property from skins

https://gerrit.wikimedia.org/r/422225

gerritbot added a comment.Mar 27 2018, 7:43 PM

Change 422226 merged by jenkins-bot:
[mediawiki/skins/GreyStuff@master] Remove unused $useHeadElement property from skins

https://gerrit.wikimedia.org/r/422226

gerritbot added a comment.Mar 27 2018, 7:43 PM

Change 422227 merged by jenkins-bot:
[mediawiki/skins/HasSomeColours@master] Remove unused $useHeadElement property from skins

https://gerrit.wikimedia.org/r/422227

gerritbot added a comment.Mar 27 2018, 7:44 PM

Change 422228 merged by jenkins-bot:
[mediawiki/skins/Mask@master] Remove unused $useHeadElement property from skins

https://gerrit.wikimedia.org/r/422228

gerritbot added a comment.Mar 27 2018, 7:44 PM

Change 422231 merged by jenkins-bot:
[mediawiki/skins/Material@master] Remove unused $useHeadElement property from skins

https://gerrit.wikimedia.org/r/422231

gerritbot added a comment.Mar 27 2018, 7:58 PM

Change 422233 merged by jenkins-bot:
[mediawiki/skins/Refreshed@master] Remove unused $useHeadElement property from skins

https://gerrit.wikimedia.org/r/422233

gerritbot added a comment.Mar 27 2018, 7:58 PM

Change 422234 merged by jenkins-bot:
[mediawiki/skins/Splash@master] Remove unused $useHeadElement property from skins

https://gerrit.wikimedia.org/r/422234

gerritbot added a comment.Mar 27 2018, 7:58 PM

Change 422235 merged by jenkins-bot:
[mediawiki/skins/Synagonism@master] Remove unused $useHeadElement property from skins

https://gerrit.wikimedia.org/r/422235

gerritbot added a comment.Mar 27 2018, 7:58 PM

Change 422237 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Remove unused $useHeadElement property from skins

https://gerrit.wikimedia.org/r/422237

gerritbot added a comment.Mar 27 2018, 7:58 PM

Change 422238 merged by jenkins-bot:
[mediawiki/skins/Truglass@master] Remove unused $useHeadElement property from skins

https://gerrit.wikimedia.org/r/422238

gerritbot added a comment.Mar 27 2018, 7:58 PM

Change 422240 merged by jenkins-bot:
[mediawiki/skins/WPtouch@master] Remove unused $useHeadElement property from skins

https://gerrit.wikimedia.org/r/422240

gerritbot added a comment.Mar 27 2018, 7:58 PM

Change 422241 merged by jenkins-bot:
[mediawiki/skins/WoOgLeShades@master] Remove unused $useHeadElement property from skins

https://gerrit.wikimedia.org/r/422241

gerritbot added a comment.Mar 27 2018, 7:58 PM

Change 422248 merged by jenkins-bot:
[mediawiki/skins/webplatform@master] Remove unused $useHeadElement property from skins

https://gerrit.wikimedia.org/r/422248

gerritbot added a comment.Mar 27 2018, 7:58 PM

Change 422247 merged by jenkins-bot:
[mediawiki/skins/p2wiki@master] Remove unused $useHeadElement property from skins

https://gerrit.wikimedia.org/r/422247

gerritbot added a comment.Mar 27 2018, 7:58 PM

Change 422245 merged by jenkins-bot:
[mediawiki/skins/mediawiki-strapping@master] Remove unused $useHeadElement property from skins

https://gerrit.wikimedia.org/r/422245

gerritbot added a comment.Mar 27 2018, 7:58 PM

Change 422244 merged by jenkins-bot:
[mediawiki/skins/erudite@master] Remove unused $useHeadElement property from skins

https://gerrit.wikimedia.org/r/422244

gerritbot added a comment.Mar 27 2018, 7:58 PM

Change 422243 merged by jenkins-bot:
[mediawiki/skins/apex@master] Remove unused $useHeadElement property from skins

https://gerrit.wikimedia.org/r/422243

gerritbot added a comment.Mar 27 2018, 7:58 PM

Change 422171 merged by jenkins-bot:
[mediawiki/skins/BlueSky@master] Remove unused $useHeadElement property from skins

https://gerrit.wikimedia.org/r/422171

Kizule closed this task as Resolved.Mar 27 2018, 7:59 PM

All resolved and merged

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)); removed MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)).Mar 27 2018, 8:00 PM
Kizule mentioned this in R1893:eaa081dbe9b9: Remove unused $useHeadElement property from skins.Mar 27 2018, 8:05 PM
Kizule mentioned this in R1893:a8ab53c2c609: Remove unused $useHeadElement property from skins.
Kizule mentioned this in rSEXAMPLE457077c44de8: Remove unused $useHeadElement property from skins.Mar 27 2018, 8:36 PM
Kizule mentioned this in rSEXAMPLE96d7627398a5: Remove unused $useHeadElement property from skins.
Kizule mentioned this in rMSMA079296cef493: Remove unused $useHeadElement property from skins.Mar 27 2018, 8:53 PM
Kizule mentioned this in rMSMA7abaaedca6e9: Remove unused $useHeadElement property from skins.
Kizule mentioned this in rSEXAMPLE8cf9e7973bac: Final NoteDb migration updates.Jun 9 2018, 2:28 PM
Kizule mentioned this in rSHAS2ce98cd6789c: Remove unused $useHeadElement property from skins.May 25 2023, 7:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits