Maniphest T191161

test_replace_tag_file is failing on Python 2.7.2
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Dalba
	Apr 1 2018, 8:47 AM

Description

https://ci.appveyor.com/project/Ladsgroup/pywikibot-g4xqx/build/1.0.225/job/83ny5p3qel5stcpi#L4717

======================================================================
ERROR: test_replace_tag_file (tests.textlib_tests.TestReplaceExcept)
Test replacing not inside file links.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "c:\projects\pywikibot-g4xqx\tests\textlib_tests.py", line 1305, in test_replace_tag_file
    'x', 'y', ['file'], site=self.site),
  File "c:\projects\pywikibot-g4xqx\pywikibot\textlib.py", line 377, in replaceExcept
    excMatch = dontTouchR.search(text, index)
MemoryError

This has occurred after the change in 8ede851d8c0655b7eb021e69003e96215da01231 (T191113)

It's a known bug in older versions of python, resolved in https://bugs.python.org/issue9669 (duplicate: https://bugs.python.org/issue12177)

Details

Subject	Repo	Branch	Lines +/-
Use the old FILE_LINK_REGEX regex for Python versions older than 2.7.4	pywikibot/core	master	+35 -23
textlib.py: Avoid zero-width matching groups	pywikibot/core	master	+6 -6
Draft	pywikibot/core	master	+2 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Dalba	T191161 test_replace_tag_file is failing on Python 2.7.2
		Resolved		Xqt	T191192 Drop support for python 2.7.2 and 2.7.3

Event Timeline

Dalba created this task.Apr 1 2018, 8:47 AM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptApr 1 2018, 8:47 AM

Dalba added a comment.Apr 1 2018, 8:51 AM

This comment was removed by Dalba.

Dalba added subtasks: T184508: Drop support for Python 3.3, T154771: Abandon support for Python 2.6.Apr 1 2018, 9:07 AM

Dalba added a parent task: T72987: Python 2.6 issues (tracking).

Xqt closed subtask T184508: Drop support for Python 3.3 as Resolved.Apr 1 2018, 11:29 AM

Xqt triaged this task as High priority.Apr 1 2018, 8:15 PM

Dalba closed this task as Resolved.Apr 2 2018, 1:38 AM

Dalba changed the task status from Resolved to Declined.

Dalba assigned this task to Xqt.

Dalba closed subtask T154771: Abandon support for Python 2.6 as Resolved.

Dalba reopened this task as Open.Apr 2 2018, 2:21 AM

This comment was removed by Dalba.

Dalba renamed this task from test_replace_tag_file is failing on Python 2.6 and 3.3 to test_replace_tag_file is failing on Python 2.7.2.Apr 2 2018, 2:23 AM

Dalba updated the task description. (Show Details)

Dalba removed a parent task: T72987: Python 2.6 issues (tracking).Apr 2 2018, 2:26 AM

Dalba removed subtasks: T154771: Abandon support for Python 2.6, T184508: Drop support for Python 3.3.

Dalba removed Xqt as the assignee of this task.Apr 2 2018, 2:46 AM

Dalba added a subscriber: Xqt.

According to changelogs the first versions of python with the fixed released are 2.7.4 release candidate 1, 3.3.1 release candidate 1, and 3.4.0 alpha 1.

3.4.0 alpha 1 is the first release of 3.4 series and we have dropped support for 3.3.
So we only have this issue with 2.7.2 and 2.7.3.
We could consider dropping support for them but we need a deprecation period. Till then, I suggest using the old regex for those versions.

On second thought, consuming 100% of CPU (T191113) is not that better than a MemoryError. There must be a better way.

Xqt mentioned this in T191192: Drop support for python 2.7.2 and 2.7.3.Apr 2 2018, 7:52 AM

Change 423447 had a related patch set uploaded (by Dalba; owner: Dalba):
[pywikibot/core@master] Draft

https://gerrit.wikimedia.org/r/423447

gerritbot added a project: Patch-For-Review.Apr 2 2018, 8:00 AM

Change 423447 abandoned by Dalba:
Draft

Reason:
Have not tested it yet, submitted by mistake

https://gerrit.wikimedia.org/r/423447

Dalba removed a project: Patch-For-Review.Apr 2 2018, 8:05 AM

Change 423451 had a related patch set uploaded (by Dalba; owner: Dalba):
[pywikibot/core@master] textlib.py: Do not use * quantifier in positive lookaheads of FILE_LINK_REGEX

https://gerrit.wikimedia.org/r/423451

gerritbot added a project: Patch-For-Review.Apr 2 2018, 8:41 AM

Dalba claimed this task.Apr 2 2018, 8:42 AM

Change 423451 merged by jenkins-bot:
[pywikibot/core@master] textlib.py: Avoid zero-width matching groups

https://gerrit.wikimedia.org/r/423451

The patch failed to resolve the issue.

Change 423463 had a related patch set uploaded (by Dalba; owner: Dalba):
[pywikibot/core@master] Use the old FILE_LINK_REGEX regex for Python versions older than 2.7.4

https://gerrit.wikimedia.org/r/423463

gerritbot added a project: Patch-For-Review.Apr 2 2018, 10:58 AM

Change 423463 merged by jenkins-bot:
[pywikibot/core@master] Use the old FILE_LINK_REGEX regex for Python versions older than 2.7.4

https://gerrit.wikimedia.org/r/423463

Dalba closed this task as Resolved.Apr 2 2018, 11:28 AM

Dalba claimed this task.

Dvorapa added a subtask: T191192: Drop support for python 2.7.2 and 2.7.3.May 20 2018, 11:36 AM

Xqt changed the status of subtask T191192: Drop support for python 2.7.2 and 2.7.3 from Stalled to Open.Dec 3 2018, 9:44 PM

Xqt closed subtask T191192: Drop support for python 2.7.2 and 2.7.3 as Resolved.Feb 18 2019, 4:02 PM