Page MenuHomePhabricator
Create Task
Maniphest T191254

Hierarchy issues on individual reading list views
Closed, ResolvedPublic
Actions

Description

Why are we doing this?
There is some duplicate information on the page as it is currently implemented and some spacing issues due to the removal of the 'updates available' feature.

Proposed solution

F 04.png (1×750 px, 350 KB)
Zeplin: https://zpl.io/aXYE4kE
  • Remove the header title from this screen, leaving only the bold title from the expanded header area
  • Remove the HR from between the expanded header and the search bar
  • Ensure that all list item text and background fills fit within the height of the thumbnail (see Zeplin for redlines and spacing)
  • Increase padding between list item text and thumbnail to 20pts

Related Objects

Event Timeline

cmadeo created this task.Apr 2 2018, 10:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 2 2018, 10:57 PM
cmadeo moved this task from Tasks from Product Backlog to Needs Engineering Sync on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Apr 2 2018, 10:57 PM
cmadeo triaged this task as Medium priority.Apr 2 2018, 11:01 PM
cmadeo updated the task description. (Show Details)Apr 2 2018, 11:18 PM
• NHarateh_WMF claimed this task.Apr 3 2018, 4:14 PM
• NHarateh_WMF moved this task from Needs Engineering Sync to Doing on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.
• NHarateh_WMF moved this task from Doing to Needs Code Review on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Apr 3 2018, 4:40 PM
• NHarateh_WMF mentioned this in rAPIOSf1da2be090c2: Merge branch 'develop' into bug/T191254.Apr 3 2018, 7:25 PM
• NHarateh_WMF mentioned this in rAPIOS67171d3b12d6: Merge branch 'develop' into bug/T191254.Apr 3 2018, 8:31 PM
cmadeo mentioned this in T186082: As a user of reading lists, I would like to be able to sort and search for articles within a reading list.Apr 3 2018, 11:07 PM
Diffusion mentioned this in rAPIOS262f793e5364: Merge branch 'develop' into bug/T191254.Apr 4 2018, 12:14 AM
Diffusion mentioned this in rAPIOS8d2dbc693d46: Merge pull request #2162 from wikimedia/bug/T191254.Apr 4 2018, 12:28 AM
• NHarateh_WMF moved this task from Needs Code Review to Waiting for Build on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Apr 4 2018, 2:56 PM
• NHarateh_WMF moved this task from Waiting for Build to Needs Design Review on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Apr 4 2018, 5:02 PM
cmadeo moved this task from Needs Design Review to Ready for Development on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Apr 4 2018, 5:57 PM

Hi @NHarateh_WMF, thanks so much for working on this!
This is looking really good, just two small tweaks:

  • Could we make the HR between the search bar and the top list item the same thickness as the list items HRs?
  • Could we have the Title of the reading list move into the header after the user has scrolled past the large title? (similar to the header in iOS settings)

Sorry about leaving this last point out on the original ticket, just realized now that it'd be nice for longer reading lists to have the title present on scroll.

• NHarateh_WMF moved this task from Ready for Development to Needs Code Review on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Apr 4 2018, 8:53 PM
• NHarateh_WMF mentioned this in rAPIOSc9d395c50171: Merge branch 'develop' into followup/T191254.Apr 4 2018, 8:57 PM
• NHarateh_WMF mentioned this in rAPIOSdadc7672969d: Merge branch 'develop' into followup/T191254.Apr 5 2018, 5:29 PM
Diffusion mentioned this in rAPIOSe10c77ded227: Merge pull request #2169 from wikimedia/followup/T191254.Apr 5 2018, 9:15 PM
• NHarateh_WMF moved this task from Needs Code Review to Needs Testing Criteria on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Apr 5 2018, 9:34 PM
Diffusion mentioned this in rAPIOS7b6eecfa563c: Merge pull request #2180 from wikimedia/followup/T191254.Apr 5 2018, 9:57 PM
• NHarateh_WMF moved this task from Needs Testing Criteria to Waiting for Build on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Apr 6 2018, 5:11 PM
• NHarateh_WMF moved this task from Waiting for Build to Needs Design Review on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Apr 6 2018, 7:38 PM
cmadeo moved this task from Needs Design Review to Ready for Development on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Apr 9 2018, 9:28 PM

@NHarateh_WMF this is looking awesome!

Would it be possible for the compacted header to reappear when the user scrolls back up (similar to the article view header?

cmadeo added a comment.Apr 9 2018, 10:35 PM
This comment was removed by cmadeo.
• NHarateh_WMF moved this task from Ready for Development to Needs Code Review on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Apr 10 2018, 2:39 PM
• NHarateh_WMF moved this task from Needs Code Review to Waiting for Build on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Apr 10 2018, 6:13 PM
Diffusion mentioned this in rAPIOS5ca6a187e786: Merge branch 'develop' into followup/T191254.Apr 10 2018, 6:19 PM
Diffusion mentioned this in rAPIOS760f63d22b74: Merge pull request #2193 from wikimedia/followup/T191254.
• NHarateh_WMF moved this task from Waiting for Build to Needs Design Review on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Apr 11 2018, 1:48 PM
cmadeo moved this task from Needs Design Review to Needs QA on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Apr 11 2018, 9:22 PM

@NHarateh_WMF thanks so much! This looks great :)

• JMinor moved this task from Needs QA to Ready for PM Signoff on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Apr 12 2018, 6:49 PM
• JMinor closed this task as Resolved.Apr 12 2018, 11:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL