Maniphest T191493

CirrusSearch should handle gracefully a missing plugins section in elasticsearch response
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	dcausse
	Apr 5 2018, 8:07 AM

Description

When scanning plugins and modules cirrus assumes that the response returned by elasticsearch will always include the plugins section. This is not necessarily the case on every installation (see this post on mw.org).

We should make the method \CirrusSearch\Maintenance\ConfigUtils::scanModulesOrPlugins resilient to such situation.

Details

	Subject	Repo	Branch	Lines +/-
	Gracefully handle missing plugin section	mediawiki/extensions/CirrusSearch	master	+71 -1

Customize query in gerrit

Event Timeline

dcausse created this task.Apr 5 2018, 8:07 AM

Restricted Application added projects: Discovery-ARCHIVED, Discovery-Search. · View Herald TranscriptApr 5 2018, 8:07 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

dcausse updated the task description. (Show Details)Apr 5 2018, 8:55 AM

• EBjune triaged this task as Medium priority.Apr 5 2018, 5:10 PM

• EBjune moved this task from needs triage to Up Next on the Discovery-Search board.

EBernhardson moved this task from Up Next to Current work on the Discovery-Search board.Sep 10 2018, 5:46 PM

EBernhardson edited projects, added Discovery-Search (Current work); removed Discovery-Search.

EBernhardson claimed this task.Sep 10 2018, 5:57 PM

EBernhardson moved this task from Incoming to not in use - please delete on the Discovery-Search (Current work) board.

Change 459609 had a related patch set uploaded (by EBernhardson; owner: EBernhardson):
[mediawiki/extensions/CirrusSearch@master] Gracefully handle missing plug

https://gerrit.wikimedia.org/r/459609

gerritbot added a project: Patch-For-Review.Sep 10 2018, 6:58 PM

EBernhardson moved this task from not in use - please delete to Needs review on the Discovery-Search (Current work) board.Sep 10 2018, 6:58 PM

Change 459609 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Gracefully handle missing plugin section

https://gerrit.wikimedia.org/r/459609

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)).Sep 11 2018, 10:00 AM

EBernhardson moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Sep 11 2018, 4:54 PM

debt closed this task as Resolved.Sep 13 2018, 9:18 PM