Page MenuHomePhabricator

CirrusSearch should handle gracefully a missing plugins section in elasticsearch response
Closed, ResolvedPublic

Description

When scanning plugins and modules cirrus assumes that the response returned by elasticsearch will always include the plugins section. This is not necessarily the case on every installation (see this post on mw.org).

We should make the method \CirrusSearch\Maintenance\ConfigUtils::scanModulesOrPlugins resilient to such situation.

Event Timeline

dcausse created this task.Apr 5 2018, 8:07 AM
Restricted Application added projects: Discovery, Discovery-Search. · View Herald TranscriptApr 5 2018, 8:07 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
dcausse updated the task description. (Show Details)Apr 5 2018, 8:55 AM
EBjune triaged this task as Normal priority.Apr 5 2018, 5:10 PM
EBjune moved this task from needs triage to Up Next on the Discovery-Search board.

Change 459609 had a related patch set uploaded (by EBernhardson; owner: EBernhardson):
[mediawiki/extensions/CirrusSearch@master] Gracefully handle missing plug

https://gerrit.wikimedia.org/r/459609

Change 459609 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Gracefully handle missing plugin section

https://gerrit.wikimedia.org/r/459609

debt closed this task as Resolved.Sep 13 2018, 9:18 PM