Page MenuHomePhabricator

Horizon should not show 'Launch' button on 'Images' page for non-project admins
Closed, ResolvedPublic

Description

As a project member, without being a project admin, I can open the page Compute > Images. In the list of images, a 'Lauch' button is shown for non-deprecated images. I can click that button, use the normal 'Lauch instance' dialogue to choose the instance name, image, flavor. When I click 'Launch instance' after the last step, it fails with the error

Policy doesn't allow os_compute_api:servers:create to be performed. (HTTP 403) (Request-ID: req-84fd74ae-991a-4186-bdc6-5322a85f7438)

The button "Launch" shouldn't be displayed on the list of images in the first place if I'm not allowed to use it (which I'm rightfully not, 'cause limiting this to project admins is intended).

Event Timeline

Andrew renamed this task from Horizon should not show 'Lauch' button on 'Images' page for non-project admins to Horizon should not show 'Launch' button on 'Images' page for non-project admins.Apr 13 2018, 10:20 PM
Andrew claimed this task.

Change 433445 had a related patch set uploaded (by Andrew Bogott; owner: Andrew Bogott):
[operations/puppet@production] horizon: Update policy rules for nova policies

https://gerrit.wikimedia.org/r/433445

Change 433445 merged by Andrew Bogott:
[operations/puppet@production] horizon: Update policy rules for nova policies

https://gerrit.wikimedia.org/r/433445

Change 437304 had a related patch set uploaded (by Andrew Bogott; owner: Andrew Bogott):
[openstack/horizon/horizon@master] Image panel: check instance create policy for 'Launch' button

https://gerrit.wikimedia.org/r/437304

Change 437305 had a related patch set uploaded (by Andrew Bogott; owner: Andrew Bogott):
[openstack/horizon/horizon@ocata] Image panel: check instance create policy for 'Launch' button

https://gerrit.wikimedia.org/r/437305

Change 437305 merged by Andrew Bogott:
[openstack/horizon/horizon@ocata] Image panel: check instance create policy for 'Launch' button

https://gerrit.wikimedia.org/r/437305

Change 437304 merged by Andrew Bogott:
[openstack/horizon/horizon@master] Image panel: check instance create policy for 'Launch' button

https://gerrit.wikimedia.org/r/437304

Change 437306 had a related patch set uploaded (by Andrew Bogott; owner: Andrew Bogott):
[openstack/horizon/deploy@ocata] Horizon: update ocata submodule

https://gerrit.wikimedia.org/r/437306

Change 437306 merged by Andrew Bogott:
[openstack/horizon/deploy@ocata] Horizon: update ocata submodule

https://gerrit.wikimedia.org/r/437306

Mentioned in SAL (#wikimedia-operations) [2018-06-04T20:27:15Z] <andrew@deploy1001> Started deploy [horizon/deploy@12aa2d3]: fix for T192179

Mentioned in SAL (#wikimedia-operations) [2018-06-04T20:30:50Z] <andrew@deploy1001> Finished deploy [horizon/deploy@12aa2d3]: fix for T192179 (duration: 03m 35s)