Page MenuHomePhabricator
Create Task
Maniphest T192278

Emptying the fileinfo resets the original file info
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

  • Submit a file to Special:fileimport
  • click "Edit File Info"
  • Empty the text in the editor
  • Save

-> Result: The old info is still there.

  • Submit a file to Special:fileimport
  • click "Edit File Info"
  • Change the text to something
  • click Save, you see the changed content rendered on the importpage
  • click "Edit File Info" again
  • Empty the text in the editor
  • Save

-> Result: The original info is there again.

Details

SubjectRepoBranchLines +/-
Use empty file info text if givenmediawiki/extensions/FileImportermaster+42 -2
Customize query in gerrit

Related Objects

Event Timeline

• MichaelSchoenitzer_WMDE created this task.Apr 16 2018, 1:10 PM
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptApr 16 2018, 1:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• MichaelSchoenitzer_WMDE added a comment.Apr 16 2018, 1:14 PM

Additional buggy consequence: The edit summary is editable but the edit summary content is not used…

• Lea_WMDE moved this task from Backlog to Tickets in preparation/investigation on the Move-Files-To-Commons board.Apr 23 2018, 8:26 AM
• Lea_WMDE set the point value for this task to 1.Apr 24 2018, 2:40 PM
gerritbot subscribed.Apr 24 2018, 6:24 PM

Change 428709 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/FileImporter@master] Use empty file info text if given

https://gerrit.wikimedia.org/r/428709

gerritbot added a project: Patch-For-Review.Apr 24 2018, 6:24 PM
WMDE-Fisch mentioned this in rEFLI2b526cc8d707: Use empty file info text if given.Apr 24 2018, 6:26 PM
WMDE-Fisch claimed this task.Apr 25 2018, 6:59 AM
WMDE-Fisch added a project: WMDE-QWERTY-Sprint-2018-04-17.
WMDE-Fisch moved this task from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2018-04-17 board.
WMDE-Fisch moved this task from Tickets in preparation/investigation to Tickets in sprint on the Move-Files-To-Commons board.
Tobi_WMDE_SW moved this task from Review to Demo on the WMDE-QWERTY-Sprint-2018-04-17 board.Apr 25 2018, 9:02 AM
gerritbot added a comment.Apr 25 2018, 9:04 AM

Change 428709 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Use empty file info text if given

https://gerrit.wikimedia.org/r/428709

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)).Apr 25 2018, 10:00 AM
• Lea_WMDE moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2018-04-17 board.Apr 25 2018, 1:53 PM
WMDE-Fisch closed this task as Resolved.May 3 2018, 7:26 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits