Maniphest T192538

mw 1.25+ supports booleans as parameter assignment
Closed, DeclinedPublic
Actions

Assigned To

None

Authored By

	Xqt
	Apr 19 2018, 10:29 AM

Description

Currently api._encoded_items() encodes boolean items of True to the empty list [''] which leads to "&apiparam=" in _http_param_string. This should be replaced to "&apiparam=True" for newer mw versions.

Related Objects
Search...

Status	Subtype	Assigned	Task
Declined		None	T192538 mw 1.25+ supports booleans as parameter assignment
Resolved	Release	Xqt	T306637 Drop support for MediaWiki < 1.27
Open		None	T343204 Drop rawcontinue and continue query parameter

Event Timeline

Xqt created this task.Apr 19 2018, 10:29 AM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptApr 19 2018, 10:29 AM

See https://gerrit.wikimedia.org/r/#/c/197901/

I've not tested, but I think mediawiki interprets &apiparam=False as a true value, i.e. passing the parameter means true and it must be omitted for false.
If so, then I personally find &apiparam=True a little misleading and would prefer to continue using &apiparam= for true values. Others may disagree of-course.

Xqt added a subtask: T306637: Drop support for MediaWiki < 1.27.Apr 21 2022, 4:04 PM

Xqt moved this task from Backlog to Next main release on the Pywikibot board.Apr 25 2022, 8:02 AM

Xqt added a parent task: T308258: Pywikibot 8 tasks (Tracking).May 12 2022, 4:18 PM

Xqt closed subtask T306637: Drop support for MediaWiki < 1.27 as Resolved.Oct 30 2022, 3:23 PM

Xqt reopened subtask T306637: Drop support for MediaWiki < 1.27 as Open.

Xqt closed subtask T306637: Drop support for MediaWiki < 1.27 as Resolved.Sep 9 2023, 8:17 PM

Xqt removed a parent task: T308258: Pywikibot 8 tasks (Tracking).Dec 6 2023, 6:11 PM

Per Dalba's comment